From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E733422333772 for ; Tue, 23 Jan 2018 02:13:25 -0800 (PST) Received: by mail-wm0-x242.google.com with SMTP id g1so726706wmg.2 for ; Tue, 23 Jan 2018 02:18:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=n6JzpsTHkR+P5+9llsQB+uz+dmeRj54gXAsaO85O9D0=; b=GOZh8PJAypE4EXJlIlYDemx+aMA/U6WzQVXyN8ITImLSDJi5c/s6ew7NQOWM6nNX+2 enreJb4Ii8Kd8FHz9/QP7suC6munGZJuB/G2BqVwBMI8dV8ry29EKQyWLeLsU0c9N3Z9 CLUVmM82JE0bLjHBPOFQsGccoQdF2SN/IvDQY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=n6JzpsTHkR+P5+9llsQB+uz+dmeRj54gXAsaO85O9D0=; b=RxuvASPM7x7mZbgBvgwJskRVb0i1Thc0BhVf+vKx37ESQXjeVeEEt2aSfmoFljFX3t E80cCgfm17p6EJB8WqRFtus52pDvOde/WDWfblcN53MeR3oEWkkdwU8OsA4SUds5fca7 c1lyaQgu5EPN9MzooZkyAHB/EubS6YFP5a9bl/8HXwCBz4PUROYm7zvIpX6kTZqlAsPZ iwMvZbTIgKUu0ewfbobn/9JcXXibKYW/x0TFYcA8Jhk8WMTcdLRdPz/T8yLEXilMMVQC r7Y/jhcBzqIvRLVB52rnmmXQ+YFtVrFrVdCSBZPiaEnVoyX5gY3PL+0ylrYCXtOx/MLr uR2g== X-Gm-Message-State: AKwxyte21OjHgwjU6mg3QeMMGYtNuu6+TjKVeNxMGaupFENzgdEB1Kqh ETyyHjaJq3mX+DHT8/HXYrWhJw== X-Google-Smtp-Source: AH8x22536ItJzdL0/1dNo9q4HoKb8oC9ujZVbZU/EtVPGLmK6sBxzPHZurxp5cIUZ2Ua+52+3DBEXg== X-Received: by 10.28.216.149 with SMTP id p143mr1520851wmg.140.1516702730702; Tue, 23 Jan 2018 02:18:50 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v191sm7510241wmf.25.2018.01.23.02.18.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jan 2018 02:18:49 -0800 (PST) Date: Tue, 23 Jan 2018 10:18:47 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, mengfanrong@huawei.com, waip23@126.com Message-ID: <20180123101847.p65tfoeskt7jc7q7@bivouac.eciton.net> References: <1516287703-35516-1-git-send-email-huangming23@huawei.com> <1516287703-35516-15-git-send-email-huangming23@huawei.com> MIME-Version: 1.0 In-Reply-To: <1516287703-35516-15-git-send-email-huangming23@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 14/14] Hisilicon D03/D05: Update firmware version to 18.02 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jan 2018 10:13:26 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 18, 2018 at 11:01:43PM +0800, Ming Huang wrote: > Replace the old string with short one. The old one is > too long that can not be show integrallty in Setup nemu. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo NAK Anything that is not an official Linaro reference platform release is a development build. The fallback string needs to indicate this. The current one does this. The modified version does not. / Leif > --- > Platform/Hisilicon/D03/D03.dsc | 2 +- > Platform/Hisilicon/D05/D05.dsc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > index 6f1164e..b6b8086 100644 > --- a/Platform/Hisilicon/D03/D03.dsc > +++ b/Platform/Hisilicon/D03/D03.dsc > @@ -171,7 +171,7 @@ > !ifdef $(FIRMWARE_VER) > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > !else > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build base on Hisilicon D03 UEFI 17.10 Release" > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"RP 18.02 for Hisilicon D03" > !endif > > gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > index 52ffad5..a599c08 100644 > --- a/Platform/Hisilicon/D05/D05.dsc > +++ b/Platform/Hisilicon/D05/D05.dsc > @@ -190,7 +190,7 @@ > !ifdef $(FIRMWARE_VER) > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > !else > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build base on Hisilicon D05 UEFI 17.10 Release" > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"RP 18.02 for Hisilicon D05" > !endif > > gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" > -- > 1.9.1 >