From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E9AC422333784 for ; Tue, 23 Jan 2018 02:23:13 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id f71so801782wmf.0 for ; Tue, 23 Jan 2018 02:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OK8WlqUe13jbh1upwKO1aIATdqfdnFU9FmZlSvlbuR0=; b=KO60rcwFyoqwpmG262cqAyl5Jhr0iK9M5QzFtr3pXNWOHje0b6Jp13dM/h+7bz1HZK m729Rla0FAFgBJYwEQj3bHQAT+9h3iODXPP1iLtpD/DgZtsj6tLNW17Gu7lXUD4JqYPm J0okwqMvn3njbD+TwrbYIHW2xdqz2ppnxrDPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OK8WlqUe13jbh1upwKO1aIATdqfdnFU9FmZlSvlbuR0=; b=quSi/P5YbzLL9LD4ryKUdURKOM5XDmaHDsGlWp4DBEfZjsdcxvB3xfPs0p9aeBGdXd 4+kNauUmNM8eUGXgTwv22Vs2/R85AFKSzFW2KHYndXvz3ZipJ26VXLq7kG+pk4jEd3rw Lh1j4OWWefzBhMaJs7E7cU516ML7/5kQqRZ7uLW5eU8OTjRv/JPAWuv9/6XQj5h37YCq Kc/n9tqCu8riT4UjI1L+mh3X4WXJBGI2+kMNfkFkThATyNlASpyzXDxvIWGOQefLP2yf L4BZHjEe5GFyy7dIRs/owJi5nb91ObtkPAlAvWxdTjtTLw3Il+SJBfhT0yGZvmwoUoJF V8Cw== X-Gm-Message-State: AKwxytcOeZGj+gFlRRHj4SCQoqgNtTJL+Ny+je6O6eWQIDYNQL7gOa0j ZjJIuDfPge3PhPTXSs0jJiYAUQ== X-Google-Smtp-Source: AH8x224xIHnbFuQe4gqeXr6y5WLE2Lz6f7sGRelvvN8vfOMO/+Wzy82JX/VbbJAoohOrxSswebXiLg== X-Received: by 10.28.1.73 with SMTP id 70mr1379542wmb.49.1516703319584; Tue, 23 Jan 2018 02:28:39 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id s206sm8950948wme.4.2018.01.23.02.28.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jan 2018 02:28:38 -0800 (PST) Date: Tue, 23 Jan 2018 10:28:36 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, mengfanrong@huawei.com, waip23@126.com Message-ID: <20180123102836.nkl4bkjgb7tp7nz7@bivouac.eciton.net> References: <1516287703-35516-1-git-send-email-huangming23@huawei.com> <1516287703-35516-4-git-send-email-huangming23@huawei.com> MIME-Version: 1.0 In-Reply-To: <1516287703-35516-4-git-send-email-huangming23@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 03/14] Hisilicon D03/D05: Optimize the feature of BMC set boot option X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jan 2018 10:23:14 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I don't agree with this subject line - there is no optimization going on here. "Break BMC SetBoot option out into separate library" would be a more accurate subject line. For the record, I think this is good cleanup even without the dual-BDS support. On Thu, Jan 18, 2018 at 11:01:32PM +0800, Ming Huang wrote: > diff --git a/Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf b/Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf > new file mode 100644 > index 0000000..7e407b4 > --- /dev/null > +++ b/Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf > @@ -0,0 +1,51 @@ > +#/** @file > +# > +# Copyright (c) 2015, Hisilicon Limited. All rights reserved. > +# Copyright (c) 2015, Linaro Limited. All rights reserved. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +#**/ > + > +[Defines] > + INF_VERSION = 0x00010005 0x0001001a > + BASE_NAME = BmcConfigBootLib > + FILE_GUID = f174d192-7208-46c1-b9d1-65b2db06ad3b > + MODULE_TYPE = BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = BmcConfigBootLib > + > +[Sources.common] > + BmcConfigBootLib.c > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec MdeM before MdeP / Leif > + Silicon/Hisilicon/HisiPkg.dec > + > +[LibraryClasses] > + BaseLib > + BaseMemoryLib > + DebugLib > + DevicePathLib > + IpmiCmdLib > + PcdLib > + PrintLib > + UefiBootManagerLib > + > +[BuildOptions] > + > +[Pcd] > + > +[Guids] > + gEfiEventReadyToBootGuid > + > +[Protocols] > + gEfiDevicePathToTextProtocolGuid ## CONSUMES > + gEfiSimpleFileSystemProtocolGuid ## CONSUMES