Re: [PATCH edk2-platforms v1 07/14] Hisilicon/Smbios: modify type 4

[Leif Lindholm <leif.lindholm@linaro.org>]

The patch is good, but the subject is too broad, and the message could
be more descriptive.

Subject should say something like "Indicate use of ProcessorFamily2 in
type 4 table".

Message should point out that ProcessorFamily2 is already specified as
ProcessorFamilyARM in the existing table.

Regards,

Leif

On Thu, Jan 18, 2018 at 11:01:36PM +0800, Ming Huang wrote:
> modify processorFamily of type 4 to ProcessorFamilyIndicatorFamily2,
> indicator to obtain the processor family from the Processor Family 2 field.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> ---
>  Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> index 61473e8..c9903ba 100644
> --- a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> +++ b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> @@ -125,7 +125,7 @@ SMBIOS_TABLE_TYPE4   mSmbiosProcessorTable[] = {
>          },
>          1,                                              //Socket
>          CentralProcessor,                               //ProcessorType
> -        ProcessorFamilyOther,                           //ProcessorFamily
> +        ProcessorFamilyIndicatorFamily2,                //ProcessorFamily
>          2,                                              //ProcessorManufacture
>          {                                               //ProcessorId
>              {                                               //Signature
> @@ -172,7 +172,7 @@ SMBIOS_TABLE_TYPE4   mSmbiosProcessorTable[] = {
>          },
>          1,                                              //Socket
>          CentralProcessor,                               //ProcessorType
> -        ProcessorFamilyOther,                           //ProcessorFamily
> +        ProcessorFamilyIndicatorFamily2,                //ProcessorFamily
>          2,                                              //ProcessorManufacture
>          {                                               //ProcessorId
>              {                                               //Signature
> -- 
> 1.9.1
>