From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2223A2233377E for ; Tue, 23 Jan 2018 06:09:37 -0800 (PST) Received: by mail-wr0-x242.google.com with SMTP id w50so708384wrc.11 for ; Tue, 23 Jan 2018 06:15:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5YgWbVJHIKR9v6sUbv2K/wGengM3rxtUCGEHUFgt20Q=; b=KgehyOhN7fMuvE9eCYNtyUPjntxeqwIy8RWcI5v3vh5hj9DkeNwOHRXOO1rGhKt2Ml sv2V43pgXLUvG0NS09JfPDAeIr1K2N/Ge7Q/95iC5V1ul2SY+dS7TIoMSfKIemZDA3H3 BmQaSyzhhGvv1tUYX4ddmjgTuSQqXAL+YXm7A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5YgWbVJHIKR9v6sUbv2K/wGengM3rxtUCGEHUFgt20Q=; b=mJJg+OwEVQdSLPlNjU+G8ov9rt9siD4/vyuZhlhdNu2xysFEYpWzlKOWN0DYbl5J5U BBeoNF2BzwkEU7HrBQOgHCA75yY+nQbTLntUMGAy5OuDxyROLaAodyY+xfJ9UqNjIFcG thvhZJ8Yjtk+AT3OeUPWIab7H6lvH5lIGHeZBb62w6t0ONEAWWOIZe8ZIrTdzOLxajcL EU6hVjmqr4f1Kk3A6tBw8T5y9SL9Ot1ry+CuACFqj9Nc78K1tTzuwCgoS/y7yV6oT00B /Ysma7vv8NXFp4PEMQ6oCVPlxY1C+MhfIVn/mkpUjUNfOM6tM7rey7ZptH2mblRSRlFj Olmw== X-Gm-Message-State: AKwxytc+MDpAWhiGehE7hzfockUvqB142sozeb+rjbKtHYHSupXpIrgp DTz4euTJI/pe/vMd+TPkqQvc+w== X-Google-Smtp-Source: AH8x227OC9PCrYEW9fC4T9wvvAKWtOYowXrnNjRaiVYr0IvmAvnMvBSRA+wuSfRHP8AM2qE4Pq2a/w== X-Received: by 10.223.128.110 with SMTP id 101mr2426649wrk.177.1516716903633; Tue, 23 Jan 2018 06:15:03 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g60sm666913wrd.92.2018.01.23.06.15.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jan 2018 06:15:02 -0800 (PST) Date: Tue, 23 Jan 2018 14:15:00 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, mengfanrong@huawei.com, waip23@126.com Message-ID: <20180123141500.2lhaxkjpxuy3o25n@bivouac.eciton.net> References: <1516287703-35516-1-git-send-email-huangming23@huawei.com> <1516287703-35516-8-git-send-email-huangming23@huawei.com> MIME-Version: 1.0 In-Reply-To: <1516287703-35516-8-git-send-email-huangming23@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 07/14] Hisilicon/Smbios: modify type 4 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jan 2018 14:09:38 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The patch is good, but the subject is too broad, and the message could be more descriptive. Subject should say something like "Indicate use of ProcessorFamily2 in type 4 table". Message should point out that ProcessorFamily2 is already specified as ProcessorFamilyARM in the existing table. Regards, Leif On Thu, Jan 18, 2018 at 11:01:36PM +0800, Ming Huang wrote: > modify processorFamily of type 4 to ProcessorFamilyIndicatorFamily2, > indicator to obtain the processor family from the Processor Family 2 field. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > index 61473e8..c9903ba 100644 > --- a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > +++ b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > @@ -125,7 +125,7 @@ SMBIOS_TABLE_TYPE4 mSmbiosProcessorTable[] = { > }, > 1, //Socket > CentralProcessor, //ProcessorType > - ProcessorFamilyOther, //ProcessorFamily > + ProcessorFamilyIndicatorFamily2, //ProcessorFamily > 2, //ProcessorManufacture > { //ProcessorId > { //Signature > @@ -172,7 +172,7 @@ SMBIOS_TABLE_TYPE4 mSmbiosProcessorTable[] = { > }, > 1, //Socket > CentralProcessor, //ProcessorType > - ProcessorFamilyOther, //ProcessorFamily > + ProcessorFamilyIndicatorFamily2, //ProcessorFamily > 2, //ProcessorManufacture > { //ProcessorId > { //Signature > -- > 1.9.1 >