public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] Silicon/SynQuacer/PlatformDxe: enable spread spectrum mode for ASM1061 SATA
Date: Wed, 24 Jan 2018 11:47:17 +0000	[thread overview]
Message-ID: <20180124114717.6svda6qhg2eydtst@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu-PoYm+9mBXyME1WCOA0EmA5AyM3dPcKSB=6B=smM2ZUg@mail.gmail.com>

On Wed, Jan 24, 2018 at 11:13:17AM +0000, Ard Biesheuvel wrote:
> >> +    if (PciVidPid[1] == ASM1061_PID) {
> >> +      //
> >> +      // The ASM1061 SATA controller as integrated into the DeveloperBox design
> >> +      // emits too much electromagnetic radiation. So enable spread spectrum
> >> +      // mode.
> >> +      //
> >> +      EnableAsm1061SpreadSpectrum (PciIo);
> >> +    } else if (PciVidPid[1] == ASM1182E_PID || PciVidPid[1] == ASM1184E_PID) {
> >
> > Does this "else if" prevent the SATA controller from training GEN2?
> > Could it be just another if?
> >
> 
> Only if PciVidPid[1] equals ASM1061_PID and ASM1182E_PID/ASM1184E_PID
> at the same time.

Ah, gotcha.
The flattened topology threw me off :)

/
    Leif


      reply	other threads:[~2018-01-24 11:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 10:40 [PATCH] Silicon/SynQuacer/PlatformDxe: enable spread spectrum mode for ASM1061 SATA Ard Biesheuvel
2018-01-24 11:10 ` Leif Lindholm
2018-01-24 11:13   ` Ard Biesheuvel
2018-01-24 11:47     ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180124114717.6svda6qhg2eydtst@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox