From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::22a; helo=mail-wr0-x22a.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x22a.google.com (mail-wr0-x22a.google.com [IPv6:2a00:1450:400c:c0c::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 822F0222A3375 for ; Wed, 24 Jan 2018 03:41:53 -0800 (PST) Received: by mail-wr0-x22a.google.com with SMTP id x1so3718040wrb.5 for ; Wed, 24 Jan 2018 03:47:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1xYKolI25J8WVdVTLSHHcm6qKVdCrA/zhCcHxY7vh4o=; b=aQL+3+YSE3ByD3OsQjZZAg9rH3yU1mxIh/3uuxSbdswio6u9dHiua+tLs5CLwqrc+H h4zc7jQJknuQi3/5OBH4iYePHjHbI4jnvOP2qxfUZ83THIaSsmT+T0xbNmoMO9OmGYXn jGYvieq2x8zU+fZ0HOdGRyYIeP3w9JMcybdnw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1xYKolI25J8WVdVTLSHHcm6qKVdCrA/zhCcHxY7vh4o=; b=KeuCHtUmAGTWazE4JVSYSN3pCkb+vv+/AYGTe5hiGf8lc421aZmJR7DsEJ74ZFMeKn AYl145/FG7cVRCQtUyVT6VqDcACsbZKPOvuMn8jfOvw18wEDlAruFQqUijrtrwp9pS1E PJ6yEbf98A34lZ64/5HI/SVaZfAYzT8zX25ZUusLJeMsZwhZQ2DKpiBavwO240WIMw4g Xe+pGMyy/nL5smqrDS39/bRzSpmj4vs7S72/Llka42ejdTj1Ybx4+HF/aJk+8Lych7AJ i+hUbNbGNUwR5b4hLPpvj0htoW1MobrflpV/j2JFjC1YeeUyAl0HM0uqj9YtAsu2KYXI nPiA== X-Gm-Message-State: AKwxytfUsCk6kz7SwsorkgW+zI0n3M8f3faRJdApjZLMmgURhxNDOKc0 ApA2qtdzGoKizTUEiZI06zHkMA== X-Google-Smtp-Source: AH8x225/kvliLwZ0HKMtl3WUs1+6Hq7bzP6BdnIC9qBPFKvFr2+0E6iUIn25homLVJXl+l/dNfICIQ== X-Received: by 10.223.134.85 with SMTP id 21mr5749099wrw.283.1516794440151; Wed, 24 Jan 2018 03:47:20 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z71sm2834971wrc.11.2018.01.24.03.47.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jan 2018 03:47:19 -0800 (PST) Date: Wed, 24 Jan 2018 11:47:17 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20180124114717.6svda6qhg2eydtst@bivouac.eciton.net> References: <20180124104052.9920-1-ard.biesheuvel@linaro.org> <20180124111010.2u7e44zs3whxzeb7@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] Silicon/SynQuacer/PlatformDxe: enable spread spectrum mode for ASM1061 SATA X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 11:41:54 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 24, 2018 at 11:13:17AM +0000, Ard Biesheuvel wrote: > >> + if (PciVidPid[1] == ASM1061_PID) { > >> + // > >> + // The ASM1061 SATA controller as integrated into the DeveloperBox design > >> + // emits too much electromagnetic radiation. So enable spread spectrum > >> + // mode. > >> + // > >> + EnableAsm1061SpreadSpectrum (PciIo); > >> + } else if (PciVidPid[1] == ASM1182E_PID || PciVidPid[1] == ASM1184E_PID) { > > > > Does this "else if" prevent the SATA controller from training GEN2? > > Could it be just another if? > > > > Only if PciVidPid[1] equals ASM1061_PID and ASM1182E_PID/ASM1184E_PID > at the same time. Ah, gotcha. The flattened topology threw me off :) / Leif