public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH edk2-platforms 2/8] Silicon: fix typo in gPcf8563RealTimeClockLibI2cMasterProtocolGuid
Date: Thu, 25 Jan 2018 12:51:04 +0000	[thread overview]
Message-ID: <20180125125104.vcolxysglmvgld73@bivouac.eciton.net> (raw)
In-Reply-To: <20180125122736.5427-3-ard.biesheuvel@linaro.org>

On Thu, Jan 25, 2018 at 12:27:30PM +0000, Ard Biesheuvel wrote:
> Do a global replace of gPcf8563RealTimeClockLibI2cMasterProtolGuid with
> gPcf8563RealTimeClockLibI2cMasterProtocolGuid.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.c   | 2 +-
>  Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.dec | 2 +-
>  Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.inf | 4 ++--
>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c           | 2 +-
>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf         | 2 +-
>  5 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.c b/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.c
> index 67f8e7de4025..6bc4aef28849 100644
> --- a/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.c
> +++ b/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.c
> @@ -373,7 +373,7 @@ LibRtcInitialize (
>    //
>    BufferSize = sizeof (EFI_HANDLE);
>    Status = gBS->LocateHandle (ByProtocol,
> -                  &gPcf8563RealTimeClockLibI2cMasterProtolGuid, NULL,
> +                  &gPcf8563RealTimeClockLibI2cMasterProtocolGuid, NULL,
>                    &BufferSize, &mI2cMasterHandle);
>    ASSERT_EFI_ERROR (Status);
>  
> diff --git a/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.dec b/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.dec
> index 3849056f164a..94c4a3f1ef4c 100644
> --- a/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.dec
> +++ b/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.dec
> @@ -22,7 +22,7 @@ [Guids]
>    gPcf8563RealTimeClockLibTokenSpaceGuid = { 0xaaf5b169, 0x93a0, 0x4d60, { 0xba, 0xe4, 0x06, 0x07, 0x92, 0x8e, 0x63, 0xdd }}
>  
>  [Protocols]
> -  gPcf8563RealTimeClockLibI2cMasterProtolGuid = { 0xa6af18ae, 0x3bd5, 0x4af9, { 0xbb, 0x6a, 0xdb, 0x85, 0x07, 0x62, 0x81, 0x38 }}
> +  gPcf8563RealTimeClockLibI2cMasterProtocolGuid = { 0xa6af18ae, 0x3bd5, 0x4af9, { 0xbb, 0x6a, 0xdb, 0x85, 0x07, 0x62, 0x81, 0x38 }}
>  
>  [PcdsFixedAtBuild]
>    gPcf8563RealTimeClockLibTokenSpaceGuid.PcdI2cSlaveAddress|0x51|UINT8|0x00000001
> diff --git a/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.inf b/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.inf
> index 9907e343ba78..1a9a6f6c9cf3 100644
> --- a/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.inf
> +++ b/Silicon/NXP/Library/Pcf8563RealTimeClockLib/Pcf8563RealTimeClockLib.inf
> @@ -42,11 +42,11 @@ [Guids]
>  [Protocols]
>    gEfiDriverBindingProtocolGuid                   ## CONSUMES
>    gEfiI2cMasterProtocolGuid                       ## CONSUMES
> -  gPcf8563RealTimeClockLibI2cMasterProtolGuid     ## CONSUMES
> +  gPcf8563RealTimeClockLibI2cMasterProtocolGuid   ## CONSUMES
>  
>  [FixedPcd]
>    gPcf8563RealTimeClockLibTokenSpaceGuid.PcdI2cSlaveAddress
>    gPcf8563RealTimeClockLibTokenSpaceGuid.PcdI2cBusFrequency
>  
>  [Depex]
> -  gPcf8563RealTimeClockLibI2cMasterProtolGuid
> +  gPcf8563RealTimeClockLibI2cMasterProtocolGuid
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> index 098a4dbd324e..91c1b66ea1f8 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> @@ -183,7 +183,7 @@ PlatformDxeEntryPoint (
>    // through the I2C driver stack (which cannot be used at runtime)
>    //
>    Status = gBS->InstallProtocolInterface (&Handle,
> -                  &gPcf8563RealTimeClockLibI2cMasterProtolGuid,
> +                  &gPcf8563RealTimeClockLibI2cMasterProtocolGuid,
>                    EFI_NATIVE_INTERFACE, NULL);
>    ASSERT_EFI_ERROR (Status);
>  
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> index 766f4041c826..4d6a1d637922 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> @@ -53,7 +53,7 @@ [Guids]
>  [Protocols]
>    gEdkiiNonDiscoverableDeviceProtocolGuid         ## PRODUCES
>    gEfiPciIoProtocolGuid                           ## CONSUMES
> -  gPcf8563RealTimeClockLibI2cMasterProtolGuid     ## PRODUCES
> +  gPcf8563RealTimeClockLibI2cMasterProtocolGuid   ## PRODUCES
>  
>  [FixedPcd]
>    gSynQuacerTokenSpaceGuid.PcdNetsecEepromBase
> -- 
> 2.11.0
> 


  reply	other threads:[~2018-01-25 12:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25 12:27 [PATCH edk2-platforms 0/8] Socionext SynQuacer updates Ard Biesheuvel
2018-01-25 12:27 ` [PATCH edk2-platforms 1/8] Silicon/SynQuacer/PlatformDxe: enable spread spectrum mode for ASM1061 SATA Ard Biesheuvel
2018-01-25 12:27 ` [PATCH edk2-platforms 2/8] Silicon: fix typo in gPcf8563RealTimeClockLibI2cMasterProtocolGuid Ard Biesheuvel
2018-01-25 12:51   ` Leif Lindholm [this message]
2018-01-25 12:27 ` [PATCH edk2-platforms 3/8] Silicon/NXP/Pcf8563RealTimeClockLib: avoid driver binding protocol Ard Biesheuvel
2018-01-25 12:54   ` Leif Lindholm
2018-01-25 13:07     ` Ard Biesheuvel
2018-01-25 12:27 ` [PATCH edk2-platforms 4/8] Silicon/SynQuacerI2cDxe: remove spurious format specifier Ard Biesheuvel
2018-01-25 12:55   ` Leif Lindholm
2018-01-25 12:27 ` [PATCH edk2-platforms 5/8] Silicon/SynQuacer: load I2C driver before platform DXE driver Ard Biesheuvel
2018-01-25 12:57   ` Leif Lindholm
2018-01-25 12:27 ` [PATCH edk2-platforms 6/8] Silicon/SynQuacer/DeviceTree: align uart DT nodes Ard Biesheuvel
2018-01-25 12:58   ` Leif Lindholm
2018-01-25 12:27 ` [PATCH edk2-platforms 7/8] Silicon/SynQuacer/DeviceTree: update NETSEC DT node to latest binding Ard Biesheuvel
2018-01-25 13:00   ` Leif Lindholm
2018-01-25 13:05     ` Ard Biesheuvel
2018-01-25 12:27 ` [PATCH edk2-platforms 8/8] Silicon/Socionext/SynQuacer: implement menu option to set max PCIe speed Ard Biesheuvel
2018-01-25 18:51 ` [PATCH edk2-platforms 0/8] Socionext SynQuacer updates Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180125125104.vcolxysglmvgld73@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox