From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5D4FB2035D324 for ; Thu, 25 Jan 2018 04:51:53 -0800 (PST) Received: by mail-wm0-x243.google.com with SMTP id b21so14747824wme.4 for ; Thu, 25 Jan 2018 04:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NjKbiaSu4FCFBijxSdQiCGGTT9Y4yByWmSQ136y4o6g=; b=fvuGHnWloCnWzRS1JOcSPWbr+lL+SPYBBBK+FuGGiDRprYWcKsoVPx0mjPtmTeJD22 zcVKioZVIhkvdvS0DZhhT+3h5DJMNiAfyTc/iq83vJtxXiu9UiMn7ym0ZK+9Sy6RPYky LZbtz2H7sBG5+LGkpz7XU9C6YglR5oybfwyxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NjKbiaSu4FCFBijxSdQiCGGTT9Y4yByWmSQ136y4o6g=; b=oDKtMpysykUV/PFBLuKlc3WFUfBQF8v+qUo637j7OtmXv/qpcvcCcC9y0HMKWF8PYk ZJAOO9vQ0uJynu7y90XedZwdbB51Bi0vieyF3VkV7U/2haqdAb9TcOOHheoUnC+y+ZPZ oHXmRmzfPX3IgmJKJuj2VOuLXRq75qzbEDvRnVcVnnYl+NWJ4g9ks+0Z7dVonTWikWb3 WWIE82/1Bd8I2vcwBfNiBWeSXaH/PEBbP6mcpn/OgK+99vwIg2gJbSD5uQkGZqXspBF0 66xh8H9CCk/smfpTCYSvpAt46iAkdfZgj88dujPPIpEui7NqleUIfvQBBGwFB+3jILyY ts7w== X-Gm-Message-State: AKwxytdIQnaAlVaAUuBjUjj2v99GpP7m6Os4q+2JTPJsQM4ufb1kdJ59 Sew49udtGl+1YXy3sDfFcCN1mA== X-Google-Smtp-Source: AH8x225i3APJ7tveO8tRM8ksXK8iNvCs++kHyGLnYdvnWMLDQeHN6Ju45RIHFE2i4qy5ttZStLO1Pw== X-Received: by 10.28.208.76 with SMTP id h73mr7885695wmg.35.1516885041328; Thu, 25 Jan 2018 04:57:21 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 94sm7275207wrb.40.2018.01.25.04.57.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Jan 2018 04:57:20 -0800 (PST) Date: Thu, 25 Jan 2018 12:57:18 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20180125125718.x6x2hajxov24rrz6@bivouac.eciton.net> References: <20180125122736.5427-1-ard.biesheuvel@linaro.org> <20180125122736.5427-6-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180125122736.5427-6-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 5/8] Silicon/SynQuacer: load I2C driver before platform DXE driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 12:51:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 25, 2018 at 12:27:33PM +0000, Ard Biesheuvel wrote: > To ensure that the I2C master protocol is installed immediately onto > the handles created by PlatformDxe in its entry point, force the > SynQuacerI2cDxe driver to be loaded before PlatformDxe. These handles > are recursively connected by the DXE core as soon as they appear, and > so ensuring that the I2C master protocol driver is available at this > time will ensure that these handles will be connected to it right away. > > This is useful when implementations of architectural protocols such as > RTC or the EFI variable store, which should become available long before > the ordinary dispatch of UEFI driver model drivers is started at the end > of DXE, are based on I2C. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf | 2 +- > Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.inf | 2 +- > Silicon/Socionext/SynQuacer/SynQuacer.dec | 2 ++ > 3 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf > index 4d6a1d637922..f075957d7456 100644 > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf > @@ -17,7 +17,7 @@ > [Defines] > INF_VERSION = 0x0001001A > BASE_NAME = PlatformDxe > - FILE_GUID = ac422cc1-d916-489a-b165-536fdfc633c2 > + FILE_GUID = ac422cc1-d916-489a-b165-536fdfc633c2 # gSynQuacerPlatformDxeFileGuid > MODULE_TYPE = DXE_DRIVER > VERSION_STRING = 1.0 > ENTRY_POINT = PlatformDxeEntryPoint > diff --git a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.inf > index fa715366878c..325816ba0b88 100644 > --- a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.inf > +++ b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.inf > @@ -56,4 +56,4 @@ [FixedPcd] > gSynQuacerTokenSpaceGuid.PcdI2cReferenceClock > > [Depex] > - TRUE > + BEFORE gSynQuacerPlatformDxeFileGuid > diff --git a/Silicon/Socionext/SynQuacer/SynQuacer.dec b/Silicon/Socionext/SynQuacer/SynQuacer.dec > index a21f12b5bc32..76529e3c2164 100644 > --- a/Silicon/Socionext/SynQuacer/SynQuacer.dec > +++ b/Silicon/Socionext/SynQuacer/SynQuacer.dec > @@ -25,6 +25,8 @@ [Guids] > gSynQuacerNonDiscoverableI2cMasterGuid = { 0x364ee675, 0x9e44, 0x42b7, { 0xa5, 0xe4, 0x92, 0x84, 0xdb, 0x85, 0xda, 0x09 } } > gSynQuacerNonDiscoverableRuntimeI2cMasterGuid = { 0x5f35aa9b, 0x8c6f, 0x4828, { 0xbd, 0x44, 0x7c, 0xc0, 0xeb, 0x2d, 0xfe, 0xb9 } } > > + gSynQuacerPlatformDxeFileGuid = { 0xac422cc1, 0xd916, 0x489a, { 0xb1, 0x65, 0x53, 0x6f, 0xdf, 0xc6, 0x33, 0xc2 } } > + > [Ppis] > gSynQuacerDramInfoPpiGuid = { 0x3e1d7356, 0xdda4, 0x4b1a, { 0x93, 0x46, 0xbf, 0x89, 0x1c, 0x86, 0x46, 0xcc } } > > -- > 2.11.0 >