* [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg
@ 2018-01-26 17:30 Leif Lindholm
2018-01-26 17:31 ` Ard Biesheuvel
0 siblings, 1 reply; 5+ messages in thread
From: Leif Lindholm @ 2018-01-26 17:30 UTC (permalink / raw)
To: edk2-devel; +Cc: ard.biesheuvel
Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of
the unfortunate ARM-specific variant of PcdFirmwareVendor.
However, BeagleBoard was still using it, so the change broke the build.
Fix this by moving BeagleBoard to use the MdeModulePkg one instead.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
index 5d87ee3891..cef2e095d4 100644
--- a/BeagleBoardPkg/BeagleBoardPkg.dsc
+++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
@@ -262,7 +262,7 @@ [PcdsFeatureFlag.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
[PcdsFixedAtBuild.common]
- gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
+ gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000
gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg
2018-01-26 17:30 [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg Leif Lindholm
@ 2018-01-26 17:31 ` Ard Biesheuvel
2018-01-26 17:34 ` Leif Lindholm
0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2018-01-26 17:31 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On 26 January 2018 at 17:30, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of
> the unfortunate ARM-specific variant of PcdFirmwareVendor.
>
> However, BeagleBoard was still using it, so the change broke the build.
> Fix this by moving BeagleBoard to use the MdeModulePkg one instead.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
> index 5d87ee3891..cef2e095d4 100644
> --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
> +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
> @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common]
> gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
>
> [PcdsFixedAtBuild.common]
> - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
That should probably be L"Beagle Board"
>
> gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000
> gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg
2018-01-26 17:31 ` Ard Biesheuvel
@ 2018-01-26 17:34 ` Leif Lindholm
2018-01-26 17:35 ` Ard Biesheuvel
0 siblings, 1 reply; 5+ messages in thread
From: Leif Lindholm @ 2018-01-26 17:34 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
On Fri, Jan 26, 2018 at 05:31:25PM +0000, Ard Biesheuvel wrote:
> On 26 January 2018 at 17:30, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of
> > the unfortunate ARM-specific variant of PcdFirmwareVendor.
> >
> > However, BeagleBoard was still using it, so the change broke the build.
> > Fix this by moving BeagleBoard to use the MdeModulePkg one instead.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> > BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
> > index 5d87ee3891..cef2e095d4 100644
> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
> > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common]
> > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> >
> > [PcdsFixedAtBuild.common]
> > - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
>
> That should probably be L"Beagle Board"
Good point.
Happy with me folding that in?
>
> >
> > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000
> > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000
> > --
> > 2.11.0
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg
2018-01-26 17:34 ` Leif Lindholm
@ 2018-01-26 17:35 ` Ard Biesheuvel
2018-01-26 17:38 ` Leif Lindholm
0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2018-01-26 17:35 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On 26 January 2018 at 17:34, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Fri, Jan 26, 2018 at 05:31:25PM +0000, Ard Biesheuvel wrote:
>> On 26 January 2018 at 17:30, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> > Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of
>> > the unfortunate ARM-specific variant of PcdFirmwareVendor.
>> >
>> > However, BeagleBoard was still using it, so the change broke the build.
>> > Fix this by moving BeagleBoard to use the MdeModulePkg one instead.
>> >
>> > Contributed-under: TianoCore Contribution Agreement 1.1
>> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>> > ---
>> > BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
>> > index 5d87ee3891..cef2e095d4 100644
>> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
>> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
>> > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common]
>> > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
>> >
>> > [PcdsFixedAtBuild.common]
>> > - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
>> > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
>>
>> That should probably be L"Beagle Board"
>
> Good point.
> Happy with me folding that in?
>
Sure
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg
2018-01-26 17:35 ` Ard Biesheuvel
@ 2018-01-26 17:38 ` Leif Lindholm
0 siblings, 0 replies; 5+ messages in thread
From: Leif Lindholm @ 2018-01-26 17:38 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
On Fri, Jan 26, 2018 at 05:35:38PM +0000, Ard Biesheuvel wrote:
> >> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
> >> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
> >> > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common]
> >> > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> >> >
> >> > [PcdsFixedAtBuild.common]
> >> > - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
> >> > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
> >>
> >> That should probably be L"Beagle Board"
> >
> > Good point.
> > Happy with me folding that in?
>
> Sure
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks - pushed as 06c1f423e1.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-26 17:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-26 17:30 [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg Leif Lindholm
2018-01-26 17:31 ` Ard Biesheuvel
2018-01-26 17:34 ` Leif Lindholm
2018-01-26 17:35 ` Ard Biesheuvel
2018-01-26 17:38 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox