From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1292C2222C253 for ; Fri, 26 Jan 2018 09:29:18 -0800 (PST) Received: by mail-wr0-x241.google.com with SMTP id d9so1186821wre.3 for ; Fri, 26 Jan 2018 09:34:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dTNvbO2VyFQ7oUevTA1z1sG5vJWaE9LockYGPZT5mlg=; b=JOTBnLXku6njQaJeAYI5Yw5dRn/GAZT6vuO0t6vOc9fflQaHgOxBwy4BFQUo7w1fFX RWihJV8mNXKt4vB/0Uwq/2kUf/yUuJt7ma2QcQn3KFv6X3grgSUUwuiLErVPpV5/LxAF 57iGrkUxrUpQqvCANV64WNfe/wnkVxLo7t4ZM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dTNvbO2VyFQ7oUevTA1z1sG5vJWaE9LockYGPZT5mlg=; b=U+iW/yPYbybYvsIBdQQ1MH7uJNoPVHu3fOLVJfuYh+6EXOfDjl5mXCxZ24VOyBvdPr nSbko5YG1ynOt/73LwSh0OJzu8j8xfsA6VguNZj+83+6w+jrwUsnYjtfw0CXH07vzKPB 8+0J9Ur1DjkimSFCWnCPNQfAL3drKM2LakEbnVf8rztJk5PC8LVwCOKVL97GQ4HxeBN4 EcVEPPPCBZ+WRiZ/mc4d800/JdvYsjQ1iiIxOz9OMXq152iuAn6pN1l08Jlf8UAB0Y03 Sa0nZ2FoZ6vJRQG6FcRvzxYcf7ChxDjWi+LcyjbiMC1MGT/HtSqzIC+g5xtQQmT6608C MGFg== X-Gm-Message-State: AKwxytcms+ayv7RSpI5dizFJzokz8AhjIJVqb8pBr5MMjO6cEg7fPIFk UCwPHESHBWmzOqN4ClPiOtFSpSxKqLQ= X-Google-Smtp-Source: AH8x22736Ol4U5j8u+tBHHJWwtnQuq8xD1taR/kmu9WSG7WtMH1TorPwGkNiFmCObaz+BlCeuHAueg== X-Received: by 10.223.184.28 with SMTP id h28mr5208248wrf.215.1516988088021; Fri, 26 Jan 2018 09:34:48 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 44sm11026917wrt.46.2018.01.26.09.34.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 09:34:46 -0800 (PST) Date: Fri, 26 Jan 2018 17:34:45 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20180126173445.kmtaktrnxq5j7hh7@bivouac.eciton.net> References: <20180126173006.17324-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 17:29:19 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 26, 2018 at 05:31:25PM +0000, Ard Biesheuvel wrote: > On 26 January 2018 at 17:30, Leif Lindholm wrote: > > Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of > > the unfortunate ARM-specific variant of PcdFirmwareVendor. > > > > However, BeagleBoard was still using it, so the change broke the build. > > Fix this by moving BeagleBoard to use the MdeModulePkg one instead. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm > > --- > > BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc > > index 5d87ee3891..cef2e095d4 100644 > > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc > > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc > > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common] > > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > > > > [PcdsFixedAtBuild.common] > > - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board" > > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board" > > That should probably be L"Beagle Board" Good point. Happy with me folding that in? > > > > > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 > > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000 > > -- > > 2.11.0 > >