From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg
Date: Fri, 26 Jan 2018 17:38:19 +0000 [thread overview]
Message-ID: <20180126173819.avekovrzw5rvzk45@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu-roMzWEhWwsiv-L2Y5yiObxnG=xhdAxL+eJYGvMzB5qA@mail.gmail.com>
On Fri, Jan 26, 2018 at 05:35:38PM +0000, Ard Biesheuvel wrote:
> >> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
> >> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
> >> > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common]
> >> > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> >> >
> >> > [PcdsFixedAtBuild.common]
> >> > - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
> >> > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
> >>
> >> That should probably be L"Beagle Board"
> >
> > Good point.
> > Happy with me folding that in?
>
> Sure
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks - pushed as 06c1f423e1.
prev parent reply other threads:[~2018-01-26 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 17:30 [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg Leif Lindholm
2018-01-26 17:31 ` Ard Biesheuvel
2018-01-26 17:34 ` Leif Lindholm
2018-01-26 17:35 ` Ard Biesheuvel
2018-01-26 17:38 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126173819.avekovrzw5rvzk45@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox