From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::22d; helo=mail-wr0-x22d.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x22d.google.com (mail-wr0-x22d.google.com [IPv6:2a00:1450:400c:c0c::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AE9F42222C24A for ; Fri, 26 Jan 2018 09:32:52 -0800 (PST) Received: by mail-wr0-x22d.google.com with SMTP id w50so1200448wrc.2 for ; Fri, 26 Jan 2018 09:38:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8FcZYYnz4/R+vfJvwgVGUlN/4Gy9lDvMCeLBN7mG6kA=; b=jeJPcA2qolwXXtPj+GSW1OBqkyaQ8/tZFpppNbTTrel6cCzotsDYAtuGVeRqvbneS+ Br3dpWOAdWZpGrnoUEtOCKSEaR79s19/gRTyfHPcqZ1Ahe9B5IdI00G6JDgLB7zMkbRV Y7U/94dWU7lbsn4QYixgEvKiv88fBsPnk1v5c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8FcZYYnz4/R+vfJvwgVGUlN/4Gy9lDvMCeLBN7mG6kA=; b=krgPSd+vqjN9bFwkWVNg1x2XJmLZwFtWOj7idMvBvgeV69Letbxexv+TXJ7ucmr4T2 qC8zjdcVoBi6iqCsiy4/7U/BwhSdIFqoLjG7TM6y4oLFpv2CR7ZI6Sr9XgieY7ji92nq Dt3XuVwgne2fWbyXDTLtMZzEkNcjTDMPP7/QZ3g1aa6FjWa+5o0lYQGxw/KCgx6paACo vw3EBZ9wooVFanrOZ/vcwgE0pIuEdGYb3lVGweXct2XXmBuvz2blxqhMmUS1o88gzX8l mVzhVQ6ImKSb9saWEUQ6QrMUYx5JvVNSmMS4jBSKfLjmJKiPN68PXdEL8Ul+2RFJXqxL ujvA== X-Gm-Message-State: AKwxyteWqbDFZpbdByoWtYbbVDwRhFUIBDiJWclOFH+dAmp3oOaq9bTy pTbqTSwustKSPF/l5OPsgNOErw== X-Google-Smtp-Source: AH8x227UzqNmeo1OFtWPTA7lTqw+GVoZn13Yjje3Nnt3AG3HP31npQoagEYp0PjExynXGuDpNzDgtw== X-Received: by 10.223.179.193 with SMTP id x1mr11872637wrd.171.1516988301830; Fri, 26 Jan 2018 09:38:21 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z41sm24653wrb.50.2018.01.26.09.38.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2018 09:38:21 -0800 (PST) Date: Fri, 26 Jan 2018 17:38:19 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20180126173819.avekovrzw5rvzk45@bivouac.eciton.net> References: <20180126173006.17324-1-leif.lindholm@linaro.org> <20180126173445.kmtaktrnxq5j7hh7@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 17:32:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 26, 2018 at 05:35:38PM +0000, Ard Biesheuvel wrote: > >> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc > >> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc > >> > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common] > >> > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > >> > > >> > [PcdsFixedAtBuild.common] > >> > - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board" > >> > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board" > >> > >> That should probably be L"Beagle Board" > > > > Good point. > > Happy with me folding that in? > > Sure > > Reviewed-by: Ard Biesheuvel Thanks - pushed as 06c1f423e1.