From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=graeme.gregory@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9C31722364880 for ; Tue, 30 Jan 2018 06:24:42 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id v123so1516847wmd.5 for ; Tue, 30 Jan 2018 06:30:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dIB/4aKaVGuq0OJiMiYV2FrC3BRbhTgRV+KfNdDoJo8=; b=CoxYo2qp76yubi795baKXP+ogNnLO3Th0y6frdgLXAach48QViGcnjEi3vKo7E1F34 7+7GC9dYuuTUgmlLkLXuhrbxj/k95GjA4ff/1JsAIIrTo01LniNhDeMpQzGilLckDUjQ 2IoXmkxMcMJJeWEuFdfqyWjzNSNxUicphcBws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dIB/4aKaVGuq0OJiMiYV2FrC3BRbhTgRV+KfNdDoJo8=; b=ecgpPmc8EpOUNsPtCE1th8wzcEsawgYDkKFnwZThjr3aa4+8spIBk4WJQRj22EwkVT nDqDwQn0JFj1qKs9xuIgzg4TPvyeraU275EmxXnM+ErZ9f/SM+qPcCTbWzWTz6VbHPgN N48lWFqM2IRs31b1eTyk7UfcwrfohY6gf44F8rlNOt93ZWi/AFD20dysItvm9npgvVdH Np/Ek16Xv2ADwARQeVlWnuss+c/T25K5tbXqt9WYonfeo+HuGlpqWy9KpQ5eRxCg1ePl uzTUBU4WC7lGA35UdT2Y/PzOyqTAMfsH1eYgETnkc75adFRRVZl6iWa2H9sfwC97Y+Zc YHWw== X-Gm-Message-State: AKwxytcrlv84KbMwZRYzW23j03hn9reLxYmUeqd9n4UDL1Jdbt5Uye/H aoOvJ2lYdgzWMlQ0zzyvQ2ZuYA== X-Google-Smtp-Source: AH8x227aweSUEN/CKIxETw9j8I/ENUJswcDwFmdWDRfVyjPbR9Ch4I3QrIApoY0k8PwUl7C6OSt+eQ== X-Received: by 10.28.51.12 with SMTP id z12mr19747098wmz.16.1517322616277; Tue, 30 Jan 2018 06:30:16 -0800 (PST) Received: from localhost (host-92-20-151-143.as13285.net. [92.20.151.143]) by smtp.gmail.com with ESMTPSA id 75sm18502078wrl.88.2018.01.30.06.30.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jan 2018 06:30:15 -0800 (PST) Date: Tue, 30 Jan 2018 14:30:14 +0000 From: graeme.gregory@linaro.org To: Ming Huang Cc: leif.lindholm@linaro.org, linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, mengfanrong@huawei.com, huangdaode@hisilicon.com, waip23@126.com Message-ID: <20180130143014.GC26342@xora-haswell> References: <1516953650-57980-1-git-send-email-huangming23@huawei.com> <1516953650-57980-14-git-send-email-huangming23@huawei.com> MIME-Version: 1.0 In-Reply-To: <1516953650-57980-14-git-send-email-huangming23@huawei.com> User-Agent: Mutt/1.9.2 (2017-12-15) Subject: Re: [PATCH edk2-platforms v2 13/15] Hisilicon/D05/ACPI: Add ITS PXM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2018 14:24:43 -0000 X-Groupsio-MsgNum: 20704 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jousvV0MzM2p6OtC" Content-Disposition: inline --jousvV0MzM2p6OtC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 26, 2018 at 04:00:48PM +0800, Ming Huang wrote: > Add ITS affinity structure in SRAT. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- Looks sane to me. Reviewed-by: Graeme Gregory > Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc | 10 ++++++++++ > Silicon/Hisilicon/Include/Library/AcpiNextLib.h | 10 +++++++++- > 2 files changed, 19 insertions(+), 1 deletion(-) >=20 > diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc b/Silico= n/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc > index b448a29..8ea0c4b 100644 > --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc > +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc > @@ -121,6 +121,16 @@ EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE Srat =3D { > EFI_ACPI_6_1_GICC_AFFINITY_STRUCTURE_INIT(0x00000003,0x0000003E,0x00= 000001,0x00000000), //GICC Affinity Processor 62 > EFI_ACPI_6_1_GICC_AFFINITY_STRUCTURE_INIT(0x00000003,0x0000003F,0x00= 000001,0x00000000) //GICC Affinity Processor 63 > }, > + { > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000000, 0x00000000), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000001, 0x00000001), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000000, 0x00000002), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000001, 0x00000003), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000002, 0x00000004), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000003, 0x00000005), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000002, 0x00000006), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000003, 0x00000007) > + }, > }; > =20 > // > diff --git a/Silicon/Hisilicon/Include/Library/AcpiNextLib.h b/Silicon/Hi= silicon/Include/Library/AcpiNextLib.h > index 60f9925..fd05a3b 100644 > --- a/Silicon/Hisilicon/Include/Library/AcpiNextLib.h > +++ b/Silicon/Hisilicon/Include/Library/AcpiNextLib.h > @@ -39,6 +39,13 @@ > ACPIProcessorUID, Flags, ClockDomain = \ > } > =20 > +#define EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT( = \ > + ProximityDomain, ItsId) = \ > + { = \ > + 4, sizeof (EFI_ACPI_6_2_GIC_ITS_AFFINITY_STRUCTURE), ProximityDomain= , \ > + {EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE}, ItsId = \ > + } > + > #define EFI_ACPI_6_1_MEMORY_AFFINITY_STRUCTURE_INIT( = \ > ProximityDomain, AddressBaseLow, AddressBaseHigh, LengthLow, LengthH= igh, Flags) \ > { = \ > @@ -70,12 +77,13 @@ > // > #define EFI_ACPI_PROCESSOR_LOCAL_GICC_AFFINITY_STRUCTURE_COUNT 64 > #define EFI_ACPI_MEMORY_AFFINITY_STRUCTURE_COUNT 10 > - > +#define EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_COUNT 8 > =20 > typedef struct { > EFI_ACPI_6_0_SYSTEM_RESOURCE_AFFINITY_TABLE_HEADER Header; > EFI_ACPI_6_0_MEMORY_AFFINITY_STRUCTURE Memory[EFI= _ACPI_MEMORY_AFFINITY_STRUCTURE_COUNT]; > EFI_ACPI_6_0_GICC_AFFINITY_STRUCTURE Gicc[EFI_A= CPI_PROCESSOR_LOCAL_GICC_AFFINITY_STRUCTURE_COUNT]; > + EFI_ACPI_6_2_GIC_ITS_AFFINITY_STRUCTURE Its[EFI_AC= PI_6_2_ITS_AFFINITY_STRUCTURE_COUNT]; > } EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE; > =20 > #pragma pack() > --=20 > 1.9.1 >=20 --jousvV0MzM2p6OtC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEenb+qYJ1KjE/UpmZkGKawB22KXYFAlpwgXYACgkQkGKawB22 KXZpCg//VmJ5+DSOn97fzmAe4YAn94c/40USg1tBD6hgyc7Mocd3vet7PQJjdh8B ZVSwB8muagaLNkSpxi5QO73TKHVo9XoECljQwNbPqlFtakAsG9FKwy+NrdMq2VSP UjTWRqWfXL9uqBTgKeXcgT7OXhf9Sqa5RJGsP0VqTKADwR6Qeyj/y1niqDUtCjOM ZVwGeSgYEBXD5YdstdWdfkIEGQyT4bNku+I55gK95yRiCoFKIKAxOlMdT1o5t1x9 5b5xQUIRME4dFr05BkOuFZThlLotMQTr6p661UAn6EBqlFGDRJicMZDutaxMsuyo iLqiivnCV2aeV0yzSk0UJojDV7VTOneR5sJZJJ3MTZQ1JNododWkosVadN4D7XNB 9+rgEWatsj78rJyM1ZBLMy/0AeV3+G9N6AH5+zfk17+/mCsnjdcydifzrYGQhaD0 cP+kPhGv/E1Rkje2EZyRAy6EDuhMKa9kngSdSzfOvwThbLm7GPr1Sb0DTMK9k9aP sMmzbjt75EC+dPtwpdH66uGn9p83HFBj2fhPW9h2A3HCpSZADKk/u3EIB3MChrDb L27fN5sud8OgIXlgzvTk92KRhlUsLeAeoX7PLJo8NoMGogJu16vlhuqF2KzW126D UA/kMluxrzywxYANGKjcCyAQEpdWk0YyLAHidsUMmKji37Dm0eU= =tdUS -----END PGP SIGNATURE----- --jousvV0MzM2p6OtC--