Re: [PATCH edk2-platforms v2 14/15] Hisilicon/D05/ACPI: Add Pcie, HNS and SAS PXM

[graeme.gregory@linaro.org]

[-- Attachment #1: Type: text/plain, Size: 4532 bytes --]

On Fri, Jan 26, 2018 at 04:00:49PM +0800, Ming Huang wrote:
> Add PXM method for Pcie device, HNS device and SAS device.
> Add STA method for HNS.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: hensonwang <wanghuiqiang@huawei.com>
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> ---

Looks sane to me

Reviewed-by: Graeme Gregory <graeme@xora.org.uk>

>  Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl |  9 ++++++
>  Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Pci.asl | 34 ++++++++++++++++++--
>  Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl | 19 +++++++++--
>  3 files changed, 57 insertions(+), 5 deletions(-)
> 
> diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl
> index 11c28ba..7aa04af 100644
> --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl
> +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl
> @@ -233,6 +233,15 @@ Scope(_SB)
>        }
>      })
>  
> +    Method (_PXM, 0, NotSerialized)
> +    {
> +      Return(0x00)
> +    }
> +    Method (_STA, 0, NotSerialized)
> +    {
> +      Return(0x0F)
> +    }
> +
>      //reset XGE port
>      //Arg0 : XGE port index in dsaf
>      //Arg1 : 0 reset, 1 cancle reset
> diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Pci.asl b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Pci.asl
> index 55c7f50..122e4f0 100644
> --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Pci.asl
> +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Pci.asl
> @@ -141,7 +141,10 @@ Scope(_SB)
>      {
>        Return (0xf)
>      }
> -
> +    Method (_PXM, 0, NotSerialized)
> +    {
> +      Return(0x00)
> +    }
>    } // Device(PCI2)
>  
>    Device (RES2)
> @@ -240,7 +243,10 @@ Scope(_SB)
>      {
>        Return (RBYV())
>      }
> -
> +    Method (_PXM, 0, NotSerialized)
> +    {
> +      Return(0x01)
> +    }
>    } // Device(PCI4)
>    Device (RES4)
>    {
> @@ -338,6 +344,10 @@ Scope(_SB)
>      {
>        Return (RBYV())
>      }
> +    Method (_PXM, 0, NotSerialized)
> +    {
> +      Return(0x01)
> +    }
>    } // Device(PCI5)
>    Device (RES5)
>    {
> @@ -435,6 +445,10 @@ Scope(_SB)
>      {
>        Return (RBYV())
>      }
> +    Method (_PXM, 0, NotSerialized)
> +    {
> +      Return(0x01)
> +    }
>    } // Device(PCI6)
>    Device (RES6)
>    {
> @@ -531,6 +545,10 @@ Scope(_SB)
>      {
>        Return (RBYV())
>      }
> +    Method (_PXM, 0, NotSerialized)
> +    {
> +      Return(0x01)
> +    }
>    } // Device(PCI7)
>    Device (RES7)
>    {
> @@ -690,6 +708,10 @@ Scope(_SB)
>      {
>        Return (0xf)
>      }
> +    Method (_PXM, 0, NotSerialized)
> +    {
> +      Return(0x02)
> +    }
>    } // Device(PCIa)
>    Device (RESa)
>    {
> @@ -810,6 +832,10 @@ Scope(_SB)
>      {
>        Return (RBYV())
>      }
> +    Method (_PXM, 0, NotSerialized)
> +    {
> +      Return(0x03)
> +    }
>    } // Device(PCIc)
>  
>    Device (RESc)
> @@ -907,6 +933,10 @@ Scope(_SB)
>      {
>        Return (RBYV())
>      }
> +    Method (_PXM, 0, NotSerialized)
> +    {
> +      Return(0x03)
> +    }
>    } // Device(PCId)
>    Device (RESd)
>    {
> diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl
> index 6455130..d5b7e2f 100644
> --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl
> +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl
> @@ -88,7 +88,10 @@ Scope(_SB)
>        Store(0x7ffff, CLK)
>        Sleep(1)
>      }
> -
> +    Method (_PXM, 0, NotSerialized)
> +    {
> +      Return(0x00)
> +    }
>  	Method (_STA, 0, NotSerialized)
>  	{
>  	  Return (0x0)
> @@ -169,8 +172,15 @@ Scope(_SB)
>        Store(0x7ffff, CLK)
>        Sleep(1)
>      }
> +    Method (_PXM, 0, NotSerialized)
> +    {
> +      Return(0x00)
> +    }
> +    Method (_STA, 0, NotSerialized)
> +    {
> +      Return(0x0F)
> +    }
>    }
> -
>    Device(SAS2) {
>      Name(_HID, "HISI0162")
>      Name(_CCA, 1)
> @@ -244,7 +254,10 @@ Scope(_SB)
>        Store(0x7ffff, CLK)
>        Sleep(1)
>      }
> -
> +    Method (_PXM, 0, NotSerialized)
> +    {
> +      Return(0x00)
> +    }
>  	Method (_STA, 0, NotSerialized)
>  	{
>  	  Return (0x0)
> -- 
> 1.9.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]