From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=graeme.gregory@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D8F6F22364880 for ; Tue, 30 Jan 2018 06:25:58 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id g1so1551099wmg.2 for ; Tue, 30 Jan 2018 06:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sD1cEzMKHS/ix6m+YeY1MEmbj335MS8Fm+KGGySXBek=; b=Hzr43/O03IVV3H14hTGWaOgeNpU3SW4xvlLrh/m4Sswvx7Y+y9oHU7Lz9RLISn+M10 FZx4NlmbukLU4oFklRkxIZizK60MVLbUi6Um3J4YS4pTRn9r4MS1xweH2fVkmVtYaGfW NmTtBkT3l/VOTB6W8lXJShaEaE7uStF6472W8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sD1cEzMKHS/ix6m+YeY1MEmbj335MS8Fm+KGGySXBek=; b=t284rU6ccfbmvLUYwnvj4YaUMyNLV49IN57+gnlK3TWME8AwJ/RnYV+hmJOjOgYt/r aNmdiZTCsh/cPwe0tY3EkhUeP1pj5Nzjngtw94QPSS3e7mm2kE2/lc/O60dnXR7J9W/Q en6lO2GOUZjSq1MRmjx6X/JObUcaJXzcDZippb+BjhPQANE6tac+Ic7C6ImkCMJR02No beF0gXg/LVK3qRfGu3MOj8uSJbYeHCYSsRn800Nb2zGwjH5NxUuiHVKLu295yZjWA2gS X9eTioeRjvi6EiK8TBbyrb9j24BKXImsRxML5UPHyjjV0zjtgb1dZlwLAHG6XBWr8m7z aG/A== X-Gm-Message-State: AKwxytcTFiqrmaa8wLHXUt/M8vAxd7JRLpzoWQDHQTQBTL4O5a7sOI/o tmk8uhhnFYSMq0oh6aBKTMQdzQ== X-Google-Smtp-Source: AH8x225b3cVaG5RV45WrcDMqFQPdLbRoGhxFtOx6D2L4PCG05J67IAHn0Qv61sUyIMy4uqG1NKDFVQ== X-Received: by 10.28.198.132 with SMTP id w126mr20313963wmf.37.1517322692475; Tue, 30 Jan 2018 06:31:32 -0800 (PST) Received: from localhost (host-92-20-151-143.as13285.net. [92.20.151.143]) by smtp.gmail.com with ESMTPSA id t141sm8792472wmd.34.2018.01.30.06.31.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jan 2018 06:31:31 -0800 (PST) Date: Tue, 30 Jan 2018 14:31:30 +0000 From: graeme.gregory@linaro.org To: Ming Huang Cc: leif.lindholm@linaro.org, linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, mengfanrong@huawei.com, huangdaode@hisilicon.com, waip23@126.com Message-ID: <20180130143130.GD26342@xora-haswell> References: <1516953650-57980-1-git-send-email-huangming23@huawei.com> <1516953650-57980-15-git-send-email-huangming23@huawei.com> MIME-Version: 1.0 In-Reply-To: <1516953650-57980-15-git-send-email-huangming23@huawei.com> User-Agent: Mutt/1.9.2 (2017-12-15) Subject: Re: [PATCH edk2-platforms v2 14/15] Hisilicon/D05/ACPI: Add Pcie, HNS and SAS PXM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2018 14:25:59 -0000 X-Groupsio-MsgNum: 20705 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DrWhICOqskFTAXiy" Content-Disposition: inline --DrWhICOqskFTAXiy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 26, 2018 at 04:00:49PM +0800, Ming Huang wrote: > Add PXM method for Pcie device, HNS device and SAS device. > Add STA method for HNS. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: hensonwang > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- Looks sane to me Reviewed-by: Graeme Gregory > Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl | 9 ++++++ > Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Pci.asl | 34 ++++++++++++= ++++++-- > Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl | 19 +++++++++-- > 3 files changed, 57 insertions(+), 5 deletions(-) >=20 > diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl b/Sil= icon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl > index 11c28ba..7aa04af 100644 > --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl > +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Hns.asl > @@ -233,6 +233,15 @@ Scope(_SB) > } > }) > =20 > + Method (_PXM, 0, NotSerialized) > + { > + Return(0x00) > + } > + Method (_STA, 0, NotSerialized) > + { > + Return(0x0F) > + } > + > //reset XGE port > //Arg0 : XGE port index in dsaf > //Arg1 : 0 reset, 1 cancle reset > diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Pci.asl b/Sil= icon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Pci.asl > index 55c7f50..122e4f0 100644 > --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Pci.asl > +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Pci.asl > @@ -141,7 +141,10 @@ Scope(_SB) > { > Return (0xf) > } > - > + Method (_PXM, 0, NotSerialized) > + { > + Return(0x00) > + } > } // Device(PCI2) > =20 > Device (RES2) > @@ -240,7 +243,10 @@ Scope(_SB) > { > Return (RBYV()) > } > - > + Method (_PXM, 0, NotSerialized) > + { > + Return(0x01) > + } > } // Device(PCI4) > Device (RES4) > { > @@ -338,6 +344,10 @@ Scope(_SB) > { > Return (RBYV()) > } > + Method (_PXM, 0, NotSerialized) > + { > + Return(0x01) > + } > } // Device(PCI5) > Device (RES5) > { > @@ -435,6 +445,10 @@ Scope(_SB) > { > Return (RBYV()) > } > + Method (_PXM, 0, NotSerialized) > + { > + Return(0x01) > + } > } // Device(PCI6) > Device (RES6) > { > @@ -531,6 +545,10 @@ Scope(_SB) > { > Return (RBYV()) > } > + Method (_PXM, 0, NotSerialized) > + { > + Return(0x01) > + } > } // Device(PCI7) > Device (RES7) > { > @@ -690,6 +708,10 @@ Scope(_SB) > { > Return (0xf) > } > + Method (_PXM, 0, NotSerialized) > + { > + Return(0x02) > + } > } // Device(PCIa) > Device (RESa) > { > @@ -810,6 +832,10 @@ Scope(_SB) > { > Return (RBYV()) > } > + Method (_PXM, 0, NotSerialized) > + { > + Return(0x03) > + } > } // Device(PCIc) > =20 > Device (RESc) > @@ -907,6 +933,10 @@ Scope(_SB) > { > Return (RBYV()) > } > + Method (_PXM, 0, NotSerialized) > + { > + Return(0x03) > + } > } // Device(PCId) > Device (RESd) > { > diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl b/Sil= icon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl > index 6455130..d5b7e2f 100644 > --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl > +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl > @@ -88,7 +88,10 @@ Scope(_SB) > Store(0x7ffff, CLK) > Sleep(1) > } > - > + Method (_PXM, 0, NotSerialized) > + { > + Return(0x00) > + } > Method (_STA, 0, NotSerialized) > { > Return (0x0) > @@ -169,8 +172,15 @@ Scope(_SB) > Store(0x7ffff, CLK) > Sleep(1) > } > + Method (_PXM, 0, NotSerialized) > + { > + Return(0x00) > + } > + Method (_STA, 0, NotSerialized) > + { > + Return(0x0F) > + } > } > - > Device(SAS2) { > Name(_HID, "HISI0162") > Name(_CCA, 1) > @@ -244,7 +254,10 @@ Scope(_SB) > Store(0x7ffff, CLK) > Sleep(1) > } > - > + Method (_PXM, 0, NotSerialized) > + { > + Return(0x00) > + } > Method (_STA, 0, NotSerialized) > { > Return (0x0) > --=20 > 1.9.1 >=20 --DrWhICOqskFTAXiy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEenb+qYJ1KjE/UpmZkGKawB22KXYFAlpwgcIACgkQkGKawB22 KXZqfRAAsnqShIlg/4AB3eLxpIIo7J6DR0w29o0BrpjygyJK8WoR86/+x5n/CIgO SxhMcNRnrWe6f2tECldg2+V10iYbv7rUV4CtCCAMYR6xJu2TyG+bofLDjv3oUAiw W6H68v4sw1T1PY75qVRXyre9f3z//sjd4h+Tt1rlYnBugGLUqGRvDEqIGoB0I1ih UV4fI5ShEVnhyiKkiGzd23GDgBnmFwlk+1G3fzf0EXkixx/u+8++pKTqs3udMNXG 35k7y/gKRa7lLqPIWXK5IJcPVCG+HPmELgbhxkmfl7aLXF8wpRy2ivaRxigRYv7C OLoT05bm4KpnNyfllRfB3UHDplaJh39Eu9s1NyQpCddr3NsTV0qkUN+unXzumwof PGjoNN4cgnmTA85xeAahoskT7rtonrXkDt/QY5pzq/2F6pnT5QWx3/Wkuve1Hd+5 aXcZAiShbY2zUbax+ZOexDfcf8E9NuGIenh/yTDuBXv/kM64DGVfdarRm7n/W8vG dgyju6JUPElKn0JX5XJrWxUd/10QgdTvenKCRk24HRUkNsX1/nvK81RXeGXx/N/T qEgfCmyL/7ADQARhAoAQHwALBOHqQuU82Ww/q2XgGEe3rK9ZKm2yL1SoBXDfQDm2 iLC/PJZ2QQj2mQI6KvYxjJCENKVvMjksBDVN6JHepjY232HtcfU= =MUGo -----END PGP SIGNATURE----- --DrWhICOqskFTAXiy--