Re: [PATCH edk2-non-osi 2/2] Silicon/AMD/Styx: update ArmTrustedFirmware.bin

[Marc Zyngier <marc.zyngier@arm.com>]

On Thu, 1 Feb 2018 16:42:53 +0000
Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

> On 1 February 2018 at 16:04, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > The ARM Trusted Firmware build we have been using up until now was built
> > with optimizations disabled (which means every variable manipulation
> > involves a load, the operation itself and a store), and runs with the
> > MMU disabled, making it needlessly slow.
> >
> > This appears to be due to the fact that
> > a) the page tables are not set up correctly, so not all memory can be
> >    accessed from EL3
> > b) the handling of SMC service calls does not take into account that
> >    these calls may be made with the MMU off (e.g., by UEFI PEI).
> >
> > These issues have been fixed in the source code, which should hopefully
> > remove any performance bottlenecks that may become more noticeable now
> > that we are going to call into the secure firmware more often to perform
> > Spectre variant 2 mitigations, which have been backported as well.
> >
> > So update the binary image to a RELEASE build that was created with
> > optimizations enabled, and has the above fixes incorporated.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> >  Silicon/AMD/Styx/ArmTrustedFirmware.bin | Bin 75344 -> 34320 bytes
> >  1 file changed, 0 insertions(+), 0 deletions(-)
> >  
> 
> Note to Marc: this is the exact image I shared with you as
> bl31.bin-release earlier today, so if that works as expected, could
> you report back here please? Thanks.

To confirm, this firmware boots perfectly on Cello, and the new SMCCC
1.1 is now reported by the kernel (with in-flight patches):

[    0.000000] psci: probing for conduit method from DT.
[    0.000000] psci: PSCIv1.0 detected in firmware.
[    0.000000] psci: Using standard PSCI v0.2 function IDs
[    0.000000] psci: MIGRATE_INFO_TYPE not supported.
[    0.000000] psci: SMC Calling Convention v1.1

as well as ARM_SMCCC_ARCH_WORKAROUND_1, allowing for efficient
mitigation of Spectre v2. I guess we have quite a few Seattle/Overdrive
and OD1000 that now need this to be deployed.

Thanks a lot Ard!

	M.
-- 
Without deviation from the norm, progress is not possible.