public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org,
	ard.biesheuvel@linaro.org
Subject: Re: [edk2-non-osi][PATCH 1/2] Platform/Hisilicon/HiKey: add mcuimage
Date: Tue, 6 Feb 2018 13:55:33 +0000	[thread overview]
Message-ID: <20180206135533.ixs73nnhbkzl4bov@bivouac.eciton.net> (raw)
In-Reply-To: <1517819190-20700-1-git-send-email-haojian.zhuang@linaro.org>

On Mon, Feb 05, 2018 at 04:26:29PM +0800, Haojian Zhuang wrote:
> The MCU of Hisilicon 6220 SoC is used to control multiple cores
> power states, and scale core frequency. mcuimage.bin is the
> firmware of MCU.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> ---
>  Platform/Hisilicon/HiKey/mcuimage.bin | Bin 0 -> 146688 bytes
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  create mode 100644 Platform/Hisilicon/HiKey/mcuimage.bin
> 
> diff --git a/Platform/Hisilicon/HiKey/mcuimage.bin b/Platform/Hisilicon/HiKey/mcuimage.bin
> new file mode 100644
> index 0000000000000000000000000000000000000000..dcaa78651351b16bd27677aab13f50feec369565
> GIT binary patch
> literal 146688

*snip*

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

No need to resend this, or 2/2, I am happy with them, and will push
them once I get around to it.

However, for future contributions to edk2-non-osi, can you please
ensure to pass --no-binary to git format-patch and provide a branch in
some public repository where I can get the patches from?

Regards,

Leif


  parent reply	other threads:[~2018-02-06 13:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05  8:26 [edk2-non-osi][PATCH 1/2] Platform/Hisilicon/HiKey: add mcuimage Haojian Zhuang
2018-02-05  8:26 ` [edk2-non-osi][PATCH 2/2] Platform/Hisilicon/HiKey960: add mcu firmware Haojian Zhuang
2018-02-06 13:56   ` Leif Lindholm
2018-02-06 13:55 ` Leif Lindholm [this message]
2018-02-06 14:12   ` [edk2-non-osi][PATCH 1/2] Platform/Hisilicon/HiKey: add mcuimage Haojian Zhuang
2018-02-19 14:45 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180206135533.ixs73nnhbkzl4bov@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox