From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 444B3223972B0 for ; Tue, 6 Feb 2018 06:59:09 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id g1so4342121wmg.2 for ; Tue, 06 Feb 2018 07:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4qBLaLdkTxubawIPrKIjInIO1jOssC06oj3apI+Bbpc=; b=TXuAVdPdpnxUNy2jiB+zNG7pOisBKyFImnzqpYr6kuHf0Le6tnuZywmh4NLHoPyRv/ RAEarI+32A5UZE6ceei+OhwDPLq79fGF1z9nmZ/iyt3cyu+AFFg/n6jBmYvPQFkTVDET 540K24oa5NKbqAK4q4VfJ8EUDffHhuWxfrxEA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4qBLaLdkTxubawIPrKIjInIO1jOssC06oj3apI+Bbpc=; b=VMJEatjtI3qhXJfU4s9vsDsseFdEk2/JyuxU8Ib5lX6+U+T6qcEG9fVyecGFr8mdzP RUo5r6I7n/KpbrEp0p8iRI3L4l3xdm5XTYv0aBBxz/1VuxdKiRXJ7yMQUhFMVV3oRsGG YqxH5lD6af8MgulAOdcb6pe7s3xvvuvdFYdlmmUvUYC26afdOAeJA0r8dEf+OeXHqiGF bjDpJ+w6Ik4NqI4Ha4D4TakKwWIZHuR4XendN5qVmddEyuastJhx6dJGTmKU73ryBaIE sbPB9RuF5NIdHFfH4JTuXreJ+Z3c2urdahF6VJLqXSEcTCZ6ozpeHH3Yu6P6x6ar3/9h z1Uw== X-Gm-Message-State: APf1xPBuPVugcjUYpoQRgr8xxVzCO7jrbye73Fv4uNRhIrlOcsObq+nC Gp8eGRuoYYiKV1+hnM9X6aKy1w== X-Google-Smtp-Source: AH8x225lt15QTMFFB9cjB85OAVJN36TMZ80qV0s+OnByrujmqUB8TAmCQLKPuAruLJkr9nloSSYVWQ== X-Received: by 10.28.165.4 with SMTP id o4mr2069848wme.66.1517929491226; Tue, 06 Feb 2018 07:04:51 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 89sm13627647wrq.16.2018.02.06.07.04.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Feb 2018 07:04:50 -0800 (PST) Date: Tue, 6 Feb 2018 15:04:48 +0000 From: Leif Lindholm To: Heyi Guo Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, mengfanrong@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, waip23@126.com Message-ID: <20180206150448.45aomg5fqwrln36l@bivouac.eciton.net> References: <1517573143-11451-1-git-send-email-heyi.guo@linaro.org> <1517573143-11451-14-git-send-email-heyi.guo@linaro.org> MIME-Version: 1.0 In-Reply-To: <1517573143-11451-14-git-send-email-heyi.guo@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v3 13/15] Hisilicon/D05/ACPI: Add ITS PXM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 14:59:10 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 02, 2018 at 08:05:41PM +0800, Heyi Guo wrote: > Add ITS affinity structure in SRAT. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > Reviewed-by: Ard Biesheuvel > Reviewed-by: Graeme Gregory Err, a comment - and apologies if I missed this in other patches: this should probably be Graeme Gregory For my part: Reviewed-by: Leif Lindholm > --- > Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc | 10 ++++++++++ > Silicon/Hisilicon/Include/Library/AcpiNextLib.h | 10 +++++++++- > 2 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc b/Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc > index b448a29..8ea0c4b 100644 > --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc > +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc > @@ -121,6 +121,16 @@ EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE Srat = { > EFI_ACPI_6_1_GICC_AFFINITY_STRUCTURE_INIT(0x00000003,0x0000003E,0x00000001,0x00000000), //GICC Affinity Processor 62 > EFI_ACPI_6_1_GICC_AFFINITY_STRUCTURE_INIT(0x00000003,0x0000003F,0x00000001,0x00000000) //GICC Affinity Processor 63 > }, > + { > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000000, 0x00000000), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000001, 0x00000001), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000000, 0x00000002), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000001, 0x00000003), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000002, 0x00000004), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000003, 0x00000005), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000002, 0x00000006), > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000003, 0x00000007) > + }, > }; > > // > diff --git a/Silicon/Hisilicon/Include/Library/AcpiNextLib.h b/Silicon/Hisilicon/Include/Library/AcpiNextLib.h > index 60f9925..fd05a3b 100644 > --- a/Silicon/Hisilicon/Include/Library/AcpiNextLib.h > +++ b/Silicon/Hisilicon/Include/Library/AcpiNextLib.h > @@ -39,6 +39,13 @@ > ACPIProcessorUID, Flags, ClockDomain \ > } > > +#define EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT( \ > + ProximityDomain, ItsId) \ > + { \ > + 4, sizeof (EFI_ACPI_6_2_GIC_ITS_AFFINITY_STRUCTURE), ProximityDomain, \ > + {EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE}, ItsId \ > + } > + > #define EFI_ACPI_6_1_MEMORY_AFFINITY_STRUCTURE_INIT( \ > ProximityDomain, AddressBaseLow, AddressBaseHigh, LengthLow, LengthHigh, Flags) \ > { \ > @@ -70,12 +77,13 @@ > // > #define EFI_ACPI_PROCESSOR_LOCAL_GICC_AFFINITY_STRUCTURE_COUNT 64 > #define EFI_ACPI_MEMORY_AFFINITY_STRUCTURE_COUNT 10 > - > +#define EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_COUNT 8 > > typedef struct { > EFI_ACPI_6_0_SYSTEM_RESOURCE_AFFINITY_TABLE_HEADER Header; > EFI_ACPI_6_0_MEMORY_AFFINITY_STRUCTURE Memory[EFI_ACPI_MEMORY_AFFINITY_STRUCTURE_COUNT]; > EFI_ACPI_6_0_GICC_AFFINITY_STRUCTURE Gicc[EFI_ACPI_PROCESSOR_LOCAL_GICC_AFFINITY_STRUCTURE_COUNT]; > + EFI_ACPI_6_2_GIC_ITS_AFFINITY_STRUCTURE Its[EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_COUNT]; > } EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE; > > #pragma pack() > -- > 1.9.1 >