From: Leif Lindholm <leif.lindholm@linaro.org>
To: edk2-devel@lists.01.org
Cc: ard.biesheuvel@linaro.org
Subject: [PATCH 2/6] BeagleBoardPkg: drop unused EmbeddedPkg Pcds
Date: Tue, 6 Feb 2018 17:21:58 +0000 [thread overview]
Message-ID: <20180206172202.11667-3-leif.lindholm@linaro.org> (raw)
In-Reply-To: <20180206172202.11667-1-leif.lindholm@linaro.org>
Drop a bunch of unused EmbeddedPkg Pcds, including one used
in local code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
BeagleBoardPkg/BeagleBoardPkg.dsc | 18 ------------------
BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardMem.c | 6 +-----
2 files changed, 1 insertion(+), 23 deletions(-)
diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
index 039c4ad62d..348624a038 100644
--- a/BeagleBoardPkg/BeagleBoardPkg.dsc
+++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
@@ -235,20 +235,6 @@ [PcdsFeatureFlag.common]
gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE
gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE
- #
- # Control what commands are supported from the UI
- # Turn these on and off to add features or save size
- #
- gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|TRUE
- gEmbeddedTokenSpaceGuid.PcdEmbeddedDirCmd|TRUE
- gEmbeddedTokenSpaceGuid.PcdEmbeddedHobCmd|TRUE
- gEmbeddedTokenSpaceGuid.PcdEmbeddedHwDebugCmd|TRUE
- gEmbeddedTokenSpaceGuid.PcdEmbeddedPciDebugCmd|TRUE
- gEmbeddedTokenSpaceGuid.PcdEmbeddedIoEnable|FALSE
- gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE
-
- gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE
-
# Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress
gArmTokenSpaceGuid.PcdRelocateVectorTable|FALSE
@@ -309,10 +295,6 @@ [PcdsFixedAtBuild.common]
gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07
- gEmbeddedTokenSpaceGuid.PcdEmbeddedAutomaticBootCommand|""
- gEmbeddedTokenSpaceGuid.PcdEmbeddedDefaultTextColor|0x07
- gEmbeddedTokenSpaceGuid.PcdEmbeddedMemVariableStoreSize|0x10000
-
#
# Optional feature to help prevent EFI memory map fragments
# Turned on and off via: PcdPrePiProduceMemoryTypeInformationHob
diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardMem.c b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardMem.c
index b77b069930..3a81ef54a2 100644
--- a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardMem.c
+++ b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardMem.c
@@ -48,11 +48,7 @@ ArmPlatformGetVirtualMemoryMap (
return;
}
- if (FeaturePcdGet(PcdCacheEnable) == TRUE) {
- CacheAttributes = DDR_ATTRIBUTES_CACHED;
- } else {
- CacheAttributes = DDR_ATTRIBUTES_UNCACHED;
- }
+ CacheAttributes = DDR_ATTRIBUTES_CACHED;
// ReMap (Either NOR Flash or DRAM)
VirtualMemoryTable[Index].PhysicalBase = PcdGet64 (PcdSystemMemoryBase);
--
2.11.0
next prev parent reply other threads:[~2018-02-06 17:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 17:21 [PATCH 0/6] Delete unused EmbeddedPkg code, Pcds and guids Leif Lindholm
2018-02-06 17:21 ` [PATCH 1/6] ArmVirtPkg: drop unused PcdCacheEnable Leif Lindholm
2018-02-06 17:21 ` Leif Lindholm [this message]
2018-02-06 17:21 ` [PATCH 3/6] ArmPkg: delete references to unused guids/Pcds from CpuDxe Leif Lindholm
2018-02-06 17:22 ` [PATCH 4/6] EmbeddedPkg: drop unused Pcds from package .dsc Leif Lindholm
2018-02-06 17:22 ` [PATCH 5/6] EmbeddedPkg: delete unused HalRuntimeServicesExampleLib Leif Lindholm
2018-02-06 17:22 ` [PATCH 6/6] EmbeddedPkg: delete unused Pcds and guids Leif Lindholm
2018-02-06 17:24 ` [PATCH 0/6] Delete unused EmbeddedPkg code, " Ard Biesheuvel
2018-02-06 18:04 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206172202.11667-3-leif.lindholm@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox