From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 0/6] Delete unused EmbeddedPkg code, Pcds and guids
Date: Tue, 6 Feb 2018 18:04:50 +0000 [thread overview]
Message-ID: <20180206180450.ws3zwzbzvqnxf5sp@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu8kJLi6WA7J_F-HiUVa+AyFaxJVQxmsJ-Vv-hWs07+Z=A@mail.gmail.com>
On Tue, Feb 06, 2018 at 05:24:49PM +0000, Ard Biesheuvel wrote:
> On 6 February 2018 at 17:21, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > This series cleans up a set of unused Pcds, mostly related to Ebl,
> > that have been copied around to various platforms. With a single
> > exception they were all unused (but explicitly set, and hence
> > deleting their definitions caused build failure), and that
> > exception had a tiny conditional to excise.
> >
> > As part of cleaning out that, I also found some other unused bits
> > to get rid of.
> >
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks!
Pushed as 34a4ddda4d..e537d87817.
>
> > Leif Lindholm (6):
> > ArmVirtPkg: drop unused PcdCacheEnable
> > BeagleBoardPkg: drop unused EmbeddedPkg Pcds
> > ArmPkg: delete references to unused guids/Pcds from CpuDxe
> > EmbeddedPkg: drop unused Pcds from package .dsc
> > EmbeddedPkg: delete unused HalRuntimeServicesExampleLib
> > EmbeddedPkg: delete unused Pcds and guids
> >
> > ArmPkg/Drivers/CpuDxe/CpuDxe.h | 1 -
> > ArmPkg/Drivers/CpuDxe/CpuDxe.inf | 2 -
> > ArmVirtPkg/ArmVirt.dsc.inc | 2 -
> > BeagleBoardPkg/BeagleBoardPkg.dsc | 18 -
> > BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardMem.c | 6 +-
> > EmbeddedPkg/EmbeddedPkg.dec | 17 -
> > EmbeddedPkg/EmbeddedPkg.dsc | 15 -
> > EmbeddedPkg/Include/Protocol/DebugSupportPeriodicCallback.h | 42 -
> > EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Capsule.c | 288 -------
> > EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Mtc.c | 226 -----
> > EmbeddedPkg/Library/HalRuntimeServicesExampleLib/ReportStatusCode.c | 198 -----
> > EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Reset.c | 63 --
> > EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Rtc.c | 862 --------------------
> > EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Variable.c | 306 -------
> > 14 files changed, 1 insertion(+), 2045 deletions(-)
> > delete mode 100644 EmbeddedPkg/Include/Protocol/DebugSupportPeriodicCallback.h
> > delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Capsule.c
> > delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Mtc.c
> > delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/ReportStatusCode.c
> > delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Reset.c
> > delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Rtc.c
> > delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Variable.c
> >
> > --
> > 2.11.0
> >
prev parent reply other threads:[~2018-02-06 17:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 17:21 [PATCH 0/6] Delete unused EmbeddedPkg code, Pcds and guids Leif Lindholm
2018-02-06 17:21 ` [PATCH 1/6] ArmVirtPkg: drop unused PcdCacheEnable Leif Lindholm
2018-02-06 17:21 ` [PATCH 2/6] BeagleBoardPkg: drop unused EmbeddedPkg Pcds Leif Lindholm
2018-02-06 17:21 ` [PATCH 3/6] ArmPkg: delete references to unused guids/Pcds from CpuDxe Leif Lindholm
2018-02-06 17:22 ` [PATCH 4/6] EmbeddedPkg: drop unused Pcds from package .dsc Leif Lindholm
2018-02-06 17:22 ` [PATCH 5/6] EmbeddedPkg: delete unused HalRuntimeServicesExampleLib Leif Lindholm
2018-02-06 17:22 ` [PATCH 6/6] EmbeddedPkg: delete unused Pcds and guids Leif Lindholm
2018-02-06 17:24 ` [PATCH 0/6] Delete unused EmbeddedPkg code, " Ard Biesheuvel
2018-02-06 18:04 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206180450.ws3zwzbzvqnxf5sp@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox