Re: [PATCH edk2-platforms 3/3] Silicon/Marvell: drop unused EmbeddedPkg Pcds

[Leif Lindholm <leif.lindholm@linaro.org>]

On Tue, Feb 06, 2018 at 05:24:33PM +0000, Ard Biesheuvel wrote:
> On 6 February 2018 at 17:12, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > A set of mostly Ebl-related Pcds are about to be deleted from
> > edk2. Delete references to them here to keep platforms building.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> For the series:
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks! Pushed as 4297639904..b75684ef78.

> > ---
> >  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 19 -------------------
> >  1 file changed, 19 deletions(-)
> >
> > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> > index bf11e7c813..ef70b52167 100644
> > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> > @@ -203,21 +203,6 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64]
> >  ################################################################################
> >
> >  [PcdsFeatureFlag.common]
> > -
> > -  #
> > -  # Control what commands are supported from the UI
> > -  # Turn these on and off to add features or save size
> > -  #
> > -  gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|TRUE
> > -  gEmbeddedTokenSpaceGuid.PcdEmbeddedDirCmd|TRUE
> > -  gEmbeddedTokenSpaceGuid.PcdEmbeddedHobCmd|TRUE
> > -  gEmbeddedTokenSpaceGuid.PcdEmbeddedHwDebugCmd|TRUE
> > -  gEmbeddedTokenSpaceGuid.PcdEmbeddedPciDebugCmd|TRUE
> > -  gEmbeddedTokenSpaceGuid.PcdEmbeddedIoEnable|FALSE
> > -  gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE
> > -
> > -  gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE
> > -
> >    # Use the Vector Table location in CpuDxe.
> >    # We will not copy the Vector Table at PcdCpuVectorBaseAddress
> >    gArmTokenSpaceGuid.PcdRelocateVectorTable|FALSE
> > @@ -314,10 +299,6 @@ [PcdsFixedAtBuild.common]
> >    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F
> >  !endif
> >
> > -  gEmbeddedTokenSpaceGuid.PcdEmbeddedAutomaticBootCommand|""
> > -  gEmbeddedTokenSpaceGuid.PcdEmbeddedDefaultTextColor|0x07
> > -  gEmbeddedTokenSpaceGuid.PcdEmbeddedMemVariableStoreSize|0x10000
> > -
> >    #
> >    # Optional feature to help prevent EFI memory map fragments
> >    # Turned on and off via: PcdPrePiProduceMemoryTypeInformationHob
> > --
> > 2.11.0
> >