From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=graeme.gregory@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 302BF223972A6 for ; Wed, 7 Feb 2018 02:31:57 -0800 (PST) Received: by mail-wm0-x243.google.com with SMTP id v71so2360892wmv.2 for ; Wed, 07 Feb 2018 02:37:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=L0EVhI3FJ2DdlSBz3QbU6wdITH4lV+T+jyg2Wsp+GDU=; b=ePLXyEq+CHT9CON8TgeoKuc2aNWMoSw3vDg9EFdUeSCB9bei4dcug+WICsSBIKYzmZ ZLv9UVhU8LKgbAH9800VcU0FFTu8B9gu8BNVoAFV7SKHu3g6UD7aTXwXiycv9z0Y5vYw ne1ioE1av4D4luUH82q/gDU+gSoDrYihh+el0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=L0EVhI3FJ2DdlSBz3QbU6wdITH4lV+T+jyg2Wsp+GDU=; b=rLifHQaKrM5Q61xr87oQsNXinMSCnqLlNxP0JHsGgPIXNTmr0qcsgsArhC1o0Ovb/4 ikVHC4/tqgo/Zj6Wop2rCgVkxVi+/VJCDTSsWihz3IkSs1Pq46c30kdtFJNeqCJ9m775 7CBZ/x/xKu6AePJ4jIGWosz6Yeecd74ZCpmlkHDjxTiNo4+1ceujbBTTv89Y1gKtuYTi QKw5zCqBtcRvyqSZQ25obnN314zYDq1mKB23y+aaS5xgyJeJu1INl0O6mCQfkNR0YkFv NjbV+DAuUp/1T9I/IxkDxM6J5HIvC2A9wiQIR2iWLYks69zSPr0d6BMF/K8nj8nksv0t onaQ== X-Gm-Message-State: APf1xPDzyYV63mBqhQRosCs6tKmkyG/npnPkpGcg6ugVb9Z8hfctJCoC 9CrcsBqoGMNeXOxnNQe1jZLfsA== X-Google-Smtp-Source: AH8x225cuzjp8GSoqp8Ou7qjAmXIe7uc3Mjtf1nxHGhBjTXJ5jGtkKDIDOKV1FfzTCOd6uCh9mazPA== X-Received: by 10.28.116.4 with SMTP id p4mr4204863wmc.82.1517999860408; Wed, 07 Feb 2018 02:37:40 -0800 (PST) Received: from localhost (host-92-20-151-143.as13285.net. [92.20.151.143]) by smtp.gmail.com with ESMTPSA id 42sm1400971wrw.15.2018.02.07.02.37.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Feb 2018 02:37:39 -0800 (PST) Date: Wed, 7 Feb 2018 10:37:37 +0000 From: graeme.gregory@linaro.org To: Leif Lindholm Cc: Heyi Guo , linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, mengfanrong@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, waip23@126.com Message-ID: <20180207103737.GA6051@xora-haswell> References: <1517573143-11451-1-git-send-email-heyi.guo@linaro.org> <1517573143-11451-14-git-send-email-heyi.guo@linaro.org> <20180206150448.45aomg5fqwrln36l@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: <20180206150448.45aomg5fqwrln36l@bivouac.eciton.net> User-Agent: Mutt/1.9.2 (2017-12-15) Subject: Re: [PATCH edk2-platforms v3 13/15] Hisilicon/D05/ACPI: Add ITS PXM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 10:31:58 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 06, 2018 at 03:04:48PM +0000, Leif Lindholm wrote: > On Fri, Feb 02, 2018 at 08:05:41PM +0800, Heyi Guo wrote: > > Add ITS affinity structure in SRAT. > >=20 > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ming Huang > > Signed-off-by: Heyi Guo > > Reviewed-by: Ard Biesheuvel > > Reviewed-by: Graeme Gregory >=20 > Err, a comment - and apologies if I missed this in other patches: this > should probably be > Graeme Gregory >=20 > For my part: > Reviewed-by: Leif Lindholm >=20 Apologies yes, it should be the @linaro.org version, I must have kicked off the wrong macro in vi. Graeme > > --- > > Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc | 10 ++++++++++ > > Silicon/Hisilicon/Include/Library/AcpiNextLib.h | 10 +++++++++- > > 2 files changed, 19 insertions(+), 1 deletion(-) > >=20 > > diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc b/Sili= con/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc > > index b448a29..8ea0c4b 100644 > > --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc > > +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc > > @@ -121,6 +121,16 @@ EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE Srat =3D { > > EFI_ACPI_6_1_GICC_AFFINITY_STRUCTURE_INIT(0x00000003,0x0000003E,0x= 00000001,0x00000000), //GICC Affinity Processor 62 > > EFI_ACPI_6_1_GICC_AFFINITY_STRUCTURE_INIT(0x00000003,0x0000003F,0x= 00000001,0x00000000) //GICC Affinity Processor 63 > > }, > > + { > > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000000, 0x00000000), > > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000001, 0x00000001), > > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000000, 0x00000002), > > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000001, 0x00000003), > > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000002, 0x00000004), > > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000003, 0x00000005), > > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000002, 0x00000006), > > + EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT(0x00000003, 0x00000007) > > + }, > > }; > > =20 > > // > > diff --git a/Silicon/Hisilicon/Include/Library/AcpiNextLib.h b/Silicon/= Hisilicon/Include/Library/AcpiNextLib.h > > index 60f9925..fd05a3b 100644 > > --- a/Silicon/Hisilicon/Include/Library/AcpiNextLib.h > > +++ b/Silicon/Hisilicon/Include/Library/AcpiNextLib.h > > @@ -39,6 +39,13 @@ > > ACPIProcessorUID, Flags, ClockDomain = \ > > } > > =20 > > +#define EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_INIT( = \ > > + ProximityDomain, ItsId) = \ > > + { = \ > > + 4, sizeof (EFI_ACPI_6_2_GIC_ITS_AFFINITY_STRUCTURE), ProximityDoma= in, \ > > + {EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE}, ItsId = \ > > + } > > + > > #define EFI_ACPI_6_1_MEMORY_AFFINITY_STRUCTURE_INIT( = \ > > ProximityDomain, AddressBaseLow, AddressBaseHigh, LengthLow, Lengt= hHigh, Flags) \ > > { = \ > > @@ -70,12 +77,13 @@ > > // > > #define EFI_ACPI_PROCESSOR_LOCAL_GICC_AFFINITY_STRUCTURE_COUNT 64 > > #define EFI_ACPI_MEMORY_AFFINITY_STRUCTURE_COUNT 10 > > - > > +#define EFI_ACPI_6_2_ITS_AFFINITY_STRUCTURE_COUNT 8 > > =20 > > typedef struct { > > EFI_ACPI_6_0_SYSTEM_RESOURCE_AFFINITY_TABLE_HEADER Header; > > EFI_ACPI_6_0_MEMORY_AFFINITY_STRUCTURE Memory[E= FI_ACPI_MEMORY_AFFINITY_STRUCTURE_COUNT]; > > EFI_ACPI_6_0_GICC_AFFINITY_STRUCTURE Gicc[EFI= _ACPI_PROCESSOR_LOCAL_GICC_AFFINITY_STRUCTURE_COUNT]; > > + EFI_ACPI_6_2_GIC_ITS_AFFINITY_STRUCTURE Its[EFI_= ACPI_6_2_ITS_AFFINITY_STRUCTURE_COUNT]; > > } EFI_ACPI_STATIC_RESOURCE_AFFINITY_TABLE; > > =20 > > #pragma pack() > > --=20 > > 1.9.1 > >=20