From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6B14721F0DA58 for ; Wed, 7 Feb 2018 08:22:29 -0800 (PST) Received: by mail-wr0-x243.google.com with SMTP id t94so1691471wrc.5 for ; Wed, 07 Feb 2018 08:28:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=41O0eaGveNJwCIdpyBgKc0Di+ScCEa+ugoB8hnjIYms=; b=OeRaYhviGvhWXiy7NwIjFuW60zARdPXt+6M94ZIJFJkNLUpubp5izUu9jn/saEzaQW 0FKzfjqc8OLmJ/d2+FOHpDqH3hvi8PYqJShgCQWIprwEZNqKtE950yERCwpJupbxN155 YQtkQtjhl47ImWFeBmJk22u/OAA/fUDFg+44k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=41O0eaGveNJwCIdpyBgKc0Di+ScCEa+ugoB8hnjIYms=; b=PfTgJpOpVhOpCaljW9l+5M8xQcq+9zFqDTwwNPaK4WmNYx2AuPFeh/egC5k+SHVT4K us6QQO+y8rETRCdvonkdu22GUCf9b17NIUcq32ntJeEPohjYeqLVQGOdgFwKlffvSV4Q PoajtCkCtXkRHf0QnfiGjtJRnqgBKCPAWngAd1TbJKAxZCEWDI2m0Ehyn3zQuanBXBVl pDcQptfYK0K/OCgwVbxqPyI8tjjVLcxFmvBhwGThOQo/zuOrPLW44L0/pI+d/+P58bRP HCDTrbDYGTIlzMqcu0lDpZUe5i5LUQKR1ZYs1e3XGuzz/D7LuPgAFBAYVWmrR34h6sGL aELw== X-Gm-Message-State: APf1xPASyZUCcpIINf3gcaMvYlCcUc3yTJ8xClRa0/I97HiwTuKSspvx rV1XTnl6U58Y5/do1eit7mVejg== X-Google-Smtp-Source: AH8x225QLBzT3KHSWTNYHpmX/RpYR73ahZlbq1xHOGr+nN8B5m0LXYVTfsbWUrRtnZIoowriUtATHQ== X-Received: by 10.223.139.131 with SMTP id o3mr6108365wra.279.1518020892013; Wed, 07 Feb 2018 08:28:12 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 7sm2608193wmq.42.2018.02.07.08.28.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Feb 2018 08:28:10 -0800 (PST) Date: Wed, 7 Feb 2018 16:28:08 +0000 From: Leif Lindholm To: Haojian Zhuang Cc: "edk2-devel@lists.01.org" , Linaro UEFI Mailman List , Ard Biesheuvel Message-ID: <20180207162808.add3kz52g2vho3bk@bivouac.eciton.net> References: <1517819152-20583-1-git-send-email-haojian.zhuang@linaro.org> <20180206172956.buzy2wyiionbugxt@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 16:22:30 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 07, 2018 at 11:45:54PM +0800, Haojian Zhuang wrote: > On 7 February 2018 at 01:29, Leif Lindholm wrote: > > On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote: > >> Add skeleton of HiKey960 platform. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Haojian Zhuang > >> --- > >> + gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE > >> + > >> + gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE > > > > The above Pcds are all obsolete. > > Seeing this patch made me go through and clean up EmbeddedPkg and > > platform templates. > > > > Could you generate a new version of this patch that applies and builds > > cleanly against the cleanup series I just posted to edk2-devel?: > > https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=embeddedpkg-cleanup > > and > > https://git.linaro.org/people/leif.lindholm/edk2-platforms.git/log/?h=embeddedpkg-cleanup > > > > OK. I'll rebase on it. Thanks. (These have now been pushed to Tianocore master, so no need to work against my tree.) / Leif > > (I would be even happier if you could break the common parts of > > Hikey/Hikey960 descriptions into a common .dsc, like the d02,3,5 > > platforms do with Silicon/Hisilicon/Hisilicon.dsc.inc.) > > > > OK. > > Best Regards > Haojian