public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel@lists.01.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Brijesh Singh <brijesh.singh@amd.com>, Gary Lin <glin@suse.com>,
	Jaben Carsey <jaben.carsey@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ruiyu Ni <ruiyu.ni@intel.com>
Subject: [PATCH v2 0/2] sync some function definitions with their declarations
Date: Wed,  7 Feb 2018 23:44:33 +0100	[thread overview]
Message-ID: <20180207224435.10730-1-lersek@redhat.com> (raw)

Repo:   https://github.com/lersek/edk2.git
Branch: sync_defs_to_decls_v2

This is version 2 of the series that I posted earlier. Because that
series didn't reach the list at all, due to SMTP issues on my end, I'm
including the v1 blurb here:

> The patches say it all, just a side remark up here:
>
> These errors would have been caught long ago if we had enabled the
> "-Wmissing-prototypes" gcc option.
>
> (Unfortunately, we can't enable that option even now, because it --
> laudably -- forces the programmer to give internal linkage ("STATIC")
> to their helper / local functions, and -- as we've learned -- some
> versions of the the Visual Studio debugger choke on STATIC functions.
> Thus, core modules basically never make their internal functions
> STATIC.)

The v2 changes are noted per patch.

(This posting should hopefully reach the list; while the original SMTP
issue remains undiagnosed, I attempted to put a work-around in place.
Let's see if it works.)

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Gary Lin <glin@suse.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks,
Laszlo

Laszlo Ersek (2):
  ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with
    decl.
  OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with
    declaration

 OvmfPkg/PlatformPei/AmdSev.c                           |  3 ++-
 ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c | 14 ++++++++------
 ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h |  1 -
 3 files changed, 10 insertions(+), 8 deletions(-)

-- 
2.14.1.3.gb7cf6e02401b



             reply	other threads:[~2018-02-07 22:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 22:44 Laszlo Ersek [this message]
2018-02-07 22:44 ` [PATCH v2 1/2] ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with decl Laszlo Ersek
2018-02-08  3:25   ` Gary Lin
2018-02-07 22:44 ` [PATCH v2 2/2] OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with declaration Laszlo Ersek
2018-02-08 15:14 ` [PATCH v2 0/2] sync some function definitions with their declarations Carsey, Jaben
2018-02-08 17:26   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180207224435.10730-1-lersek@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox