From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 353C1222DE133 for ; Wed, 7 Feb 2018 14:38:56 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7FC5E4E4C3; Wed, 7 Feb 2018 22:44:40 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-123.phx2.redhat.com [10.3.117.123]) by smtp.corp.redhat.com (Postfix) with ESMTP id B63BD5D6A8; Wed, 7 Feb 2018 22:44:38 +0000 (UTC) From: Laszlo Ersek To: edk2-devel@lists.01.org Cc: Ard Biesheuvel , Brijesh Singh , Gary Lin , Jaben Carsey , Jordan Justen , Ruiyu Ni Date: Wed, 7 Feb 2018 23:44:33 +0100 Message-Id: <20180207224435.10730-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 07 Feb 2018 22:44:40 +0000 (UTC) Subject: [PATCH v2 0/2] sync some function definitions with their declarations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 22:38:57 -0000 Repo: https://github.com/lersek/edk2.git Branch: sync_defs_to_decls_v2 This is version 2 of the series that I posted earlier. Because that series didn't reach the list at all, due to SMTP issues on my end, I'm including the v1 blurb here: > The patches say it all, just a side remark up here: > > These errors would have been caught long ago if we had enabled the > "-Wmissing-prototypes" gcc option. > > (Unfortunately, we can't enable that option even now, because it -- > laudably -- forces the programmer to give internal linkage ("STATIC") > to their helper / local functions, and -- as we've learned -- some > versions of the the Visual Studio debugger choke on STATIC functions. > Thus, core modules basically never make their internal functions > STATIC.) The v2 changes are noted per patch. (This posting should hopefully reach the list; while the original SMTP issue remains undiagnosed, I attempted to put a work-around in place. Let's see if it works.) Cc: Ard Biesheuvel Cc: Brijesh Singh Cc: Gary Lin Cc: Jaben Carsey Cc: Jordan Justen Cc: Ruiyu Ni Thanks, Laszlo Laszlo Ersek (2): ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with decl. OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with declaration OvmfPkg/PlatformPei/AmdSev.c | 3 ++- ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c | 14 ++++++++------ ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h | 1 - 3 files changed, 10 insertions(+), 8 deletions(-) -- 2.14.1.3.gb7cf6e02401b