Re: [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960

[Guo Heyi <heyi.guo@linaro.org>]

On Thu, Feb 08, 2018 at 04:02:39PM +0000, Ard Biesheuvel wrote:
> On 8 February 2018 at 16:01, Haojian Zhuang <haojian.zhuang@linaro.org> wrote:
> > On 7 February 2018 at 01:29, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >> On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote:
> >>> Add skeleton of HiKey960 platform.
> >>>
> >>> Contributed-under: TianoCore Contribution Agreement 1.1
> >>> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> >>> ---
> >>>  Platform/Hisilicon/HiKey960/HiKey960.dsc           | 457 +++++++++++++++++++++
> >>>  Platform/Hisilicon/HiKey960/HiKey960.fdf           | 343 ++++++++++++++++
> >>>  .../HiKey960/Library/HiKey960Lib/HiKey960.c        | 144 +++++++
> >>>  .../HiKey960/Library/HiKey960Lib/HiKey960Helper.S  |  52 +++
> >>>  .../HiKey960/Library/HiKey960Lib/HiKey960Lib.inf   |  47 +++
> >>>  .../HiKey960/Library/HiKey960Lib/HiKey960Mem.c     | 167 ++++++++
> >>>  6 files changed, 1210 insertions(+)
> >>>  create mode 100644 Platform/Hisilicon/HiKey960/HiKey960.dsc
> >>>  create mode 100644 Platform/Hisilicon/HiKey960/HiKey960.fdf
> >>>  create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960.c
> >>>  create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960Helper.S
> >>>  create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960Lib.inf
> >>>  create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960Mem.c
> >>>
> >>
> >> (I would be even happier if you could break the common parts of
> >> Hikey/Hikey960 descriptions into a common .dsc, like the d02,3,5
> >> platforms do with Silicon/Hisilicon/Hisilicon.dsc.inc.)
> >>
> >
> > Hi Leif,
> >
> > I met an issue that blocks me. Hisilicon.dsc.inc makes use of dynamic
> > PCD value on PcdPlatformBootTimeOut.
> > And this PCD value is expected to store in variable storage device. As you know,
> > we haven't enabled variable storage device on HiKey yet.
> >
> > This one makes UEFI hang on HiKey.

Hi Haojian,

Even if we don't have non-volatile variable store on Hikey, we should have some
emulated variable store, like memory emulated, which is necessary to complete
UEFI architecture, isn't it? I think dynamic PCD will never know whether the
variable store is real non-volatile or some emulated one, so I'm curious why it
hangs on HiKey.

Heyi

> >
> 
> Can't you just redeclare it as fixed in your .DSC ?