From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B8A2C21E256B1 for ; Thu, 8 Feb 2018 17:48:42 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id 196so8870279iti.5 for ; Thu, 08 Feb 2018 17:54:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G8NsGruzU6qsiI0Hs9FRPUpfzLw4j6l3nKyyg7f8c40=; b=XxMRwwF+udb/2tRAq2TZgxwGl+p+V09TzVFL+QHAlYJjgiM3wAo4ZwMCCpfYRnNCmc MwtPoqW3gkAA8M5x8Z7aOChDZuXL6KhZ1sW1xdlZLlAXby3KqcGfECNKXaGkOfDGfzWi BVySM1Nt42fSyf+gwDxVHzyVxU2ei+dV5iyEg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G8NsGruzU6qsiI0Hs9FRPUpfzLw4j6l3nKyyg7f8c40=; b=CD2NXIm7u6CKauUALkCPnMOy+G4Q1qdD+HqL+bFX2JV45xVaD1dBvHwXgGRs33Wd8Z eOqXrD0BePUeUg5NxDf7YldaBYk6ncQmoAG1/agt5+3UiPzQ+8IPI0n23esVbH0v3h/j 9Z4a9/mMm0JXLnhWqTUo36DbM99rMPaN+xgwCgtwWZquCfxHz2dJHbPRXkzyH3ExbUL/ pPZLOm1olQIMAVCossIdUIa7jqgmtSErgvdc38jLGI+DafVvyezXB1+Mcqnle9gQDDwT tUBkTZjzVAmJ9WqVvsZg00HLB/KKQmOmhyat1IWu32lWa8npkQoscZqAxBzCQxFf1yUi aOGg== X-Gm-Message-State: APf1xPA7uVMpiXc5QTGf5WzsGuEDAcMRqfBO0S6MTGh6YnyGk8ApaCCk 75PcdFEVkhSWvzOqM9CDEWKe8w== X-Google-Smtp-Source: AH8x226JBQvBlslz2WjS2fr6hGsPsvmMK2dounrOE4IytXKMqyfN11E3g8u3Ful3uxNsOALLh95gfA== X-Received: by 10.36.89.68 with SMTP id p65mr1457002itb.98.1518141267186; Thu, 08 Feb 2018 17:54:27 -0800 (PST) Received: from SZX1000114654 ([104.237.91.79]) by smtp.gmail.com with ESMTPSA id k134sm1110215itb.34.2018.02.08.17.54.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2018 17:54:26 -0800 (PST) From: Guo Heyi X-Google-Original-From: Guo Heyi Date: Fri, 9 Feb 2018 09:54:22 +0800 To: Ard Biesheuvel Cc: Haojian Zhuang , Leif Lindholm , "edk2-devel@lists.01.org" , Linaro UEFI Mailman List , Heyi Guo Message-ID: <20180209015422.GB122996@SZX1000114654> References: <1517819152-20583-1-git-send-email-haojian.zhuang@linaro.org> <20180206172956.buzy2wyiionbugxt@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2018 01:48:43 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 08, 2018 at 04:02:39PM +0000, Ard Biesheuvel wrote: > On 8 February 2018 at 16:01, Haojian Zhuang wrote: > > On 7 February 2018 at 01:29, Leif Lindholm wrote: > >> On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote: > >>> Add skeleton of HiKey960 platform. > >>> > >>> Contributed-under: TianoCore Contribution Agreement 1.1 > >>> Signed-off-by: Haojian Zhuang > >>> --- > >>> Platform/Hisilicon/HiKey960/HiKey960.dsc | 457 +++++++++++++++++++++ > >>> Platform/Hisilicon/HiKey960/HiKey960.fdf | 343 ++++++++++++++++ > >>> .../HiKey960/Library/HiKey960Lib/HiKey960.c | 144 +++++++ > >>> .../HiKey960/Library/HiKey960Lib/HiKey960Helper.S | 52 +++ > >>> .../HiKey960/Library/HiKey960Lib/HiKey960Lib.inf | 47 +++ > >>> .../HiKey960/Library/HiKey960Lib/HiKey960Mem.c | 167 ++++++++ > >>> 6 files changed, 1210 insertions(+) > >>> create mode 100644 Platform/Hisilicon/HiKey960/HiKey960.dsc > >>> create mode 100644 Platform/Hisilicon/HiKey960/HiKey960.fdf > >>> create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960.c > >>> create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960Helper.S > >>> create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960Lib.inf > >>> create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960Mem.c > >>> > >> > >> (I would be even happier if you could break the common parts of > >> Hikey/Hikey960 descriptions into a common .dsc, like the d02,3,5 > >> platforms do with Silicon/Hisilicon/Hisilicon.dsc.inc.) > >> > > > > Hi Leif, > > > > I met an issue that blocks me. Hisilicon.dsc.inc makes use of dynamic > > PCD value on PcdPlatformBootTimeOut. > > And this PCD value is expected to store in variable storage device. As you know, > > we haven't enabled variable storage device on HiKey yet. > > > > This one makes UEFI hang on HiKey. Hi Haojian, Even if we don't have non-volatile variable store on Hikey, we should have some emulated variable store, like memory emulated, which is necessary to complete UEFI architecture, isn't it? I think dynamic PCD will never know whether the variable store is real non-volatile or some emulated one, so I'm curious why it hangs on HiKey. Heyi > > > > Can't you just redeclare it as fixed in your .DSC ?