From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2BFE5223DB799 for ; Fri, 9 Feb 2018 01:35:48 -0800 (PST) Received: by mail-wm0-x241.google.com with SMTP id t74so14312024wme.3 for ; Fri, 09 Feb 2018 01:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lFN6jh8mfpMLVKj2ZMnAlMzfSLQFhrdanR26raCXxoo=; b=ehRwTQ86AlFR7WYSJOY5EmDG8BbOia5KJhtGAO5c5Xb3GFEcpKxflUjOnFJ8+6vKo/ iH4inEaXPZUhKt1/A3AoVVDMn8HwEIMOqNBPRyZR7Vuvqz8vHz9GhbtYNJAmqMPLuXlA QhP9sVyFjSg9cyTymfYQ7jE/TvZ50IIitLTo0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lFN6jh8mfpMLVKj2ZMnAlMzfSLQFhrdanR26raCXxoo=; b=Ijy/GYJHXYc/yAU/x+GfkiqvRTBZvPLfT5M8YQREJqZ4LFekz/T8xL4TfxbI5Tonkp kE2LSXE7FWLQe/3P7Jf4Cg1LIOQTrb2lTrOAASz1A6snhSg2Foydqoi6NpPxqlaaRWWY zJGz1VZX+2jvsBPasH8V/9Pp6BXJ/fl+A155JqqzostxxlUNSKW0yHo/SpgsJGLCFQwX MNs97/hh7knV2mRDZ+mUkQgl5FuQIfsKtzKVX4jzaAV3uJS/+2bJQEjwLkWnlYgF3nN6 b10Fu0Ndo4X1Vjcc/E/rLV/KHYXnxGGbIcmvCcqC+G8GbjglK3uh5GQlE8Th1eI3DpXn ZRWw== X-Gm-Message-State: APf1xPCUYA8vdXTOKS9g8Mq2dbJQPhR0PZbyKiVUVSEqtbN6AdcNt7vB Hi0ZetdOmUaQZt7scaV/HbH5BQ== X-Google-Smtp-Source: AH8x226/Pc86TcBsdD3ZW696NeCKia3j/Z/dmbibn6kT+LGu4iH6Dk/75OzNj04Eb9HsLteHxewJZw== X-Received: by 10.28.245.25 with SMTP id t25mr1362730wmh.77.1518169293176; Fri, 09 Feb 2018 01:41:33 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d73sm2527451wma.25.2018.02.09.01.41.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Feb 2018 01:41:32 -0800 (PST) Date: Fri, 9 Feb 2018 09:41:30 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20180209094130.vwfx3hlz3wd6ci3r@bivouac.eciton.net> References: <20180208193021.24524-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 1/3] Platform/(AMD|LeMaker|SoftIron), Silicon/AMD: drop unused PcdCacheEnabled X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2018 09:35:49 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 08, 2018 at 07:46:49PM +0000, Ard Biesheuvel wrote: > On 8 February 2018 at 19:30, Leif Lindholm wrote: > > PcdCacheEnabled was never useful for these platforms, but they copied it > > over from other platforms used as templates. > > Delete it here to keep the platforms building once the Pcd is removed > > from EmbeddedPkg. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm > > For the series: > Reviewed-by: Ard Biesheuvel Thanks! Pushed as 69f992e854..ebe08785ae. > > --- > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 3 --- > > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 3 --- > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 --- > > Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf | 3 --- > > Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf | 3 --- > > Silicon/AMD/Styx/Library/AmdStyxLib/StyxMem.c | 6 +----- > > 6 files changed, 1 insertion(+), 20 deletions(-) > > > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > index 21edcc8798..48018abc69 100644 > > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > @@ -282,9 +282,6 @@ [BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,Buil > > ################################################################################ > > > > [PcdsFeatureFlag.common] > > - # All pages are cached by default > > - gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE > > - > > # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress > > gArmTokenSpaceGuid.PcdRelocateVectorTable|FALSE > > > > diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > > index cf3df86514..2468583c0d 100644 > > --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc > > +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > > @@ -270,9 +270,6 @@ [BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,Buil > > ################################################################################ > > > > [PcdsFeatureFlag.common] > > - # All pages are cached by default > > - gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE > > - > > # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress > > gArmTokenSpaceGuid.PcdRelocateVectorTable|FALSE > > > > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > index 0abec8120a..f0a7e97941 100644 > > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > @@ -272,9 +272,6 @@ [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > > ################################################################################ > > > > [PcdsFeatureFlag.common] > > - # All pages are cached by default > > - gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE > > - > > # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress > > gArmTokenSpaceGuid.PcdRelocateVectorTable|FALSE > > > > diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf b/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf > > index 6b7481ec6d..3a38f294eb 100644 > > --- a/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf > > +++ b/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLib.inf > > @@ -53,9 +53,6 @@ [Guids] > > [Ppis] > > gArmMpCoreInfoPpiGuid > > > > -[FeaturePcd] > > - gEmbeddedTokenSpaceGuid.PcdCacheEnable > > - > > [Pcd] > > gArmTokenSpaceGuid.PcdSystemMemoryBase > > gArmTokenSpaceGuid.PcdSystemMemorySize > > diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf b/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf > > index b313d4baad..b24ffd469a 100644 > > --- a/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf > > +++ b/Silicon/AMD/Styx/Library/AmdStyxLib/AmdStyxLibSec.inf > > @@ -49,9 +49,6 @@ [Sources.AARCH64] > > [Guids] > > gAmdStyxMpCoreInfoGuid ## CONSUMER > > > > -[FeaturePcd] > > - gEmbeddedTokenSpaceGuid.PcdCacheEnable > > - > > [Ppis] > > gArmMpCoreInfoPpiGuid > > > > diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/StyxMem.c b/Silicon/AMD/Styx/Library/AmdStyxLib/StyxMem.c > > index 3b82132d08..479a40627d 100644 > > --- a/Silicon/AMD/Styx/Library/AmdStyxLib/StyxMem.c > > +++ b/Silicon/AMD/Styx/Library/AmdStyxLib/StyxMem.c > > @@ -78,11 +78,7 @@ ArmPlatformGetVirtualMemoryMap ( > > return; > > } > > > > - if (FeaturePcdGet(PcdCacheEnable) == TRUE) { > > - CacheAttributes = DDR_ATTRIBUTES_CACHED; > > - } else { > > - CacheAttributes = DDR_ATTRIBUTES_UNCACHED; > > - } > > + CacheAttributes = DDR_ATTRIBUTES_CACHED; > > > > DEBUG ((EFI_D_ERROR, " Memory Map\n------------------------------------------------------------------------\n")); > > DEBUG ((EFI_D_ERROR, "Description : START - END [ SIZE ] { ATTR }\n")); > > -- > > 2.11.0 > >