From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 879D0223DB7A1 for ; Fri, 9 Feb 2018 01:36:12 -0800 (PST) Received: by mail-wm0-x243.google.com with SMTP id j21so3130962wmh.1 for ; Fri, 09 Feb 2018 01:41:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=++ZSBqVCzI070IOGJN5w6oZYP5xFrqIXF9w2WUJksWo=; b=JD53dWw7AsphyGsNpdIvz/5jj/ibt2lanyC9lyPMnp+jrZTEmBUOh9FZyCY2cSbLAs 1K35mNDBxIua0ma7KjCISmxKjZ1wZxfKzRy5lKLWsyXSBjhVw1dLrGWRZVneXoFw4VFA YUDL0KefMGa77N1yH8ULDgD3iuiKmi4LS7cwQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=++ZSBqVCzI070IOGJN5w6oZYP5xFrqIXF9w2WUJksWo=; b=XCc9t0ybR3DtetPrB6YxpP0AsTIiAOhMvlR6BbYQCxUvMEcZvvaHLCLwoNBJGyJyGg 9xkr7e2hsc1+KNPPBzmdsBkHYeMCfRr9Ab+AXKHbAu8nEkmymOOj1yH30Qmp9TH0Ch6l qLM6WWXL0MvuHUMF0FO+AnzojVc9oc8yyDs9xsco1/2AWY+3dzPtXZkY+piw5miCKb3g r6wsErnLINb9w2Gi/1yCASYeYv54XBcSUMvNPUf5V9aNID/sdGI/N5kXe1y/RcpDOzEk UqUURkQJfZh1wmG1hfHRtgV8WanTI0vwMiGu1Vl9v/+4l53qGNhClbWg6UAE4o5xcGUd Rn1w== X-Gm-Message-State: APf1xPDHKSFfqlsQ/jIA8o192Brxofubvj3goYmtLc97ezbFEI12bYBg u4ZIVtdqncjD8QSVF4EO45v3NNg9Cc8= X-Google-Smtp-Source: AH8x226n4Ud6QO+BBPTN2NWFEndj1WZzHk48QbAzNlaxwdB62Ofk4H3nWIw3e/h6/x6vvX5mMuMC9A== X-Received: by 10.28.105.80 with SMTP id e77mr1556595wmc.123.1518169317063; Fri, 09 Feb 2018 01:41:57 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v13sm2594364wrf.71.2018.02.09.01.41.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Feb 2018 01:41:56 -0800 (PST) Date: Fri, 9 Feb 2018 09:41:54 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20180209094154.xnkdkvgzagqjrqug@bivouac.eciton.net> References: <20180208191925.24269-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2018 09:36:13 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 08, 2018 at 07:22:33PM +0000, Ard Biesheuvel wrote: > On 8 February 2018 at 19:19, Leif Lindholm wrote: > > Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to > > actually drop it as a dependency for BeagleBoardLib. > > > > Get rid of it, so the module will still build when the Pcd is _really_ > > removed. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm > > For the series: > Reviewed-by: Ard Biesheuvel Thanks! Pushed as ce2818e418..6791175f05. > > --- > > BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf > > index e004d6f10b..3b62f3cbf7 100644 > > --- a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf > > +++ b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf > > @@ -44,9 +44,6 @@ [Sources.common] > > BeagleBoardHelper.S | GCC > > BeagleBoardHelper.asm | RVCT > > > > -[FeaturePcd] > > - gEmbeddedTokenSpaceGuid.PcdCacheEnable > > - > > [FixedPcd] > > gArmTokenSpaceGuid.PcdFdBaseAddress > > gArmTokenSpaceGuid.PcdFdSize > > -- > > 2.11.0 > >