[PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency

[PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency

[Leif Lindholm]

Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to
actually drop it as a dependency for BeagleBoardLib.

Get rid of it, so the module will still build when the Pcd is _really_
removed.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
index e004d6f10b..3b62f3cbf7 100644
--- a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
+++ b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
@@ -44,9 +44,6 @@ [Sources.common]
   BeagleBoardHelper.S    | GCC
   BeagleBoardHelper.asm  | RVCT
 
-[FeaturePcd]
-  gEmbeddedTokenSpaceGuid.PcdCacheEnable
-
 [FixedPcd]
   gArmTokenSpaceGuid.PcdFdBaseAddress
   gArmTokenSpaceGuid.PcdFdSize
-- 
2.11.0

[PATCH 2/2] EmbeddedPkg: _really_ delete PcdCacheEnable from .dec

[Leif Lindholm]

Commit e537d878 meant to, but failed to, remove PcdCacheEnable.
Address this, and get rid of this obsolete flag.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 EmbeddedPkg/EmbeddedPkg.dec | 1 -
 1 file changed, 1 deletion(-)

diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec
index 7cb04d61b1..e48ce2e95b 100644
--- a/EmbeddedPkg/EmbeddedPkg.dec
+++ b/EmbeddedPkg/EmbeddedPkg.dec
@@ -86,7 +86,6 @@ [Ppis]
 
 [PcdsFeatureFlag.common]
   gEmbeddedTokenSpaceGuid.PcdPrePiProduceMemoryTypeInformationHob|FALSE|BOOLEAN|0x0000001b
-  gEmbeddedTokenSpaceGuid.PcdCacheEnable|FALSE|BOOLEAN|0x00000042
   gEmbeddedTokenSpaceGuid.PcdGdbSerial|FALSE|BOOLEAN|0x00000053
 
   gEmbeddedTokenSpaceGuid.PcdSataSiI3132FeaturePMPSupport|FALSE|BOOLEAN|0x00000050
-- 
2.11.0

Re: [PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency

[Ard Biesheuvel]

On 8 February 2018 at 19:19, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to
> actually drop it as a dependency for BeagleBoardLib.
>
> Get rid of it, so the module will still build when the Pcd is _really_
> removed.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

For the series:
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> index e004d6f10b..3b62f3cbf7 100644
> --- a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> +++ b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> @@ -44,9 +44,6 @@ [Sources.common]
>    BeagleBoardHelper.S    | GCC
>    BeagleBoardHelper.asm  | RVCT
>
> -[FeaturePcd]
> -  gEmbeddedTokenSpaceGuid.PcdCacheEnable
> -
>  [FixedPcd]
>    gArmTokenSpaceGuid.PcdFdBaseAddress
>    gArmTokenSpaceGuid.PcdFdSize
> --
> 2.11.0
>

Re: [PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency

[Leif Lindholm]

On Thu, Feb 08, 2018 at 07:22:33PM +0000, Ard Biesheuvel wrote:
> On 8 February 2018 at 19:19, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to
> > actually drop it as a dependency for BeagleBoardLib.
> >
> > Get rid of it, so the module will still build when the Pcd is _really_
> > removed.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> For the series:
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks!
Pushed as ce2818e418..6791175f05.

> > ---
> >  BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> > index e004d6f10b..3b62f3cbf7 100644
> > --- a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> > +++ b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> > @@ -44,9 +44,6 @@ [Sources.common]
> >    BeagleBoardHelper.S    | GCC
> >    BeagleBoardHelper.asm  | RVCT
> >
> > -[FeaturePcd]
> > -  gEmbeddedTokenSpaceGuid.PcdCacheEnable
> > -
> >  [FixedPcd]
> >    gArmTokenSpaceGuid.PcdFdBaseAddress
> >    gArmTokenSpaceGuid.PcdFdSize
> > --
> > 2.11.0
> >