public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH edk2-platforms] Platform/Hisilicon: fix D03/D05 capsule image names
Date: Fri, 9 Feb 2018 13:31:42 +0000	[thread overview]
Message-ID: <20180209133142.ttqz2cxiymozvrhg@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu9F_L2hXXeXqVdxJJMRtZ8qiLaJYT+y=EDJcwzKF_7qzA@mail.gmail.com>

On Fri, Feb 09, 2018 at 01:20:16PM +0000, Ard Biesheuvel wrote:
> On 9 February 2018 at 13:16, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > Due to copy-paste error, both d03 and d05 ended up with capsule sections
> > named Capsule.StyxFirmwareUpdateCapsuleFmpPkcs7 in their .fdf files.
> > Change these to the actual platform names.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks - pushed as a235eabe39.

> > ---
> >  Platform/Hisilicon/D03/D03.fdf | 2 +-
> >  Platform/Hisilicon/D05/D05.fdf | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf
> > index e6a4820256..09613fb8f6 100644
> > --- a/Platform/Hisilicon/D03/D03.fdf
> > +++ b/Platform/Hisilicon/D03/D03.fdf
> > @@ -400,7 +400,7 @@ [FmpPayload.FmpPayloadSystemFirmwarePkcs7]
> >
> >    FV = SystemFirmwareUpdateCargo
> >
> > -[Capsule.StyxFirmwareUpdateCapsuleFmpPkcs7]
> > +[Capsule.D03FirmwareUpdateCapsuleFmpPkcs7]
> >  CAPSULE_GUID                = 6dcbd5ed-e82d-4c44-bda1-7194199ad92a # gEfiFmpCapsuleGuid
> >  CAPSULE_HEADER_SIZE         = 0x20
> >  CAPSULE_HEADER_INIT_VERSION = 0x1
> > diff --git a/Platform/Hisilicon/D05/D05.fdf b/Platform/Hisilicon/D05/D05.fdf
> > index 22609bb588..17a43d8edb 100644
> > --- a/Platform/Hisilicon/D05/D05.fdf
> > +++ b/Platform/Hisilicon/D05/D05.fdf
> > @@ -425,7 +425,7 @@ [FmpPayload.FmpPayloadSystemFirmwarePkcs7]
> >
> >    FV = SystemFirmwareUpdateCargo
> >
> > -[Capsule.StyxFirmwareUpdateCapsuleFmpPkcs7]
> > +[Capsule.D05FirmwareUpdateCapsuleFmpPkcs7]
> >  CAPSULE_GUID                = 6dcbd5ed-e82d-4c44-bda1-7194199ad92a # gEfiFmpCapsuleGuid
> >  CAPSULE_HEADER_SIZE         = 0x20
> >  CAPSULE_HEADER_INIT_VERSION = 0x1
> > --
> > 2.11.0
> >


      reply	other threads:[~2018-02-09 13:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09 13:16 [PATCH edk2-platforms] Platform/Hisilicon: fix D03/D05 capsule image names Leif Lindholm
2018-02-09 13:20 ` Ard Biesheuvel
2018-02-09 13:31   ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180209133142.ttqz2cxiymozvrhg@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox