From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 37B90222DE14C for ; Mon, 12 Feb 2018 03:39:21 -0800 (PST) Received: by mail-wr0-x242.google.com with SMTP id q11so3082009wre.8 for ; Mon, 12 Feb 2018 03:45:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=el8fAueq+3HQDIuVSEYNi5ygPiaw+IU4E6g1nWuoA6M=; b=QWbySNZM9oU5Re/5gb9i+GGEp+XoXGH032riMe7Vv+Z5FX/Ea+8COTKKBjYSt0mOdW gQ4pmASoljBDwrrbW6KAjDAnxWTHH1qb3v2NLF3T4wzgoErbwPaAkfA2rNndXkgnR6Qf DXWL7C+QTwbYp4uTmxPni3pI5Onuc7R4dKjH0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=el8fAueq+3HQDIuVSEYNi5ygPiaw+IU4E6g1nWuoA6M=; b=r40319hmdlfSHnIMeoeTg0EvjsF7ad8wjMaGFYdJi3h7+uQnynrlTBfXg62r4jrJdk I5PjFvRpif2le7UjvSwJ/MY0CuNTMRMiQbCm0JvoBHXQP6/MuYqRu0hleQwpuEwHXfYI zyCcHxMq2nzYAbv9PTs2DUfh82tIKjdUGmt0CCih3KhnfAQLzrSLi1mDCJRQJ/nqaCLE /Vs4JW8O3DkV5abpD3qVhKZEd3+5ipZhA6GsEJ8FriPC/ctaElCsMdl5WL2ACWGkdgmK oLfh1BHt9zsv9e7/2pkiZguYBrDAeI3Mu2fG+YwqeDGXp9tCHzUiYpPvulLP+sgS+LKh lutg== X-Gm-Message-State: APf1xPDuLrmSBoEZBu+FioQuV7pGVLVtF1+MIgq66rt3XLdJz2gn31Zn mCYl1H/X7v4XOVvOl3Bevscqfw== X-Google-Smtp-Source: AH8x227GvMA49y50+5v++2z07C0WhkJrAs5jK98MDbunDgwGJkQ5Z086F5uZaDDmtfsjkFXw2aiUgg== X-Received: by 10.223.196.78 with SMTP id a14mr10339932wrg.251.1518435909751; Mon, 12 Feb 2018 03:45:09 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v107sm9717232wrc.17.2018.02.12.03.45.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Feb 2018 03:45:08 -0800 (PST) Date: Mon, 12 Feb 2018 11:45:06 +0000 From: Leif Lindholm To: Haojian Zhuang Cc: edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org, ard.sheuvel@linaro.org, heyi.guo@linaro.org Message-ID: <20180212114506.gfu4hfz566jg7vvw@bivouac.eciton.net> References: <1518197467-32526-1-git-send-email-haojian.zhuang@linaro.org> <1518197467-32526-4-git-send-email-haojian.zhuang@linaro.org> MIME-Version: 1.0 In-Reply-To: <1518197467-32526-4-git-send-email-haojian.zhuang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 11:39:22 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Feb 10, 2018 at 01:31:06AM +0800, Haojian Zhuang wrote: > With the SerialPortLib and DebugLib, Dxe runtime driver can't > be executed well on HiKey. Serial logs are missing. "Can't be executed well"? Does this mean it crashes? > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang > --- > Platform/Hisilicon/D02/Pv660D02.dsc | 2 ++ > Platform/Hisilicon/D03/D03.dsc | 1 + > Platform/Hisilicon/D05/D05.dsc | 1 + > Silicon/Hisilicon/Hisilicon.dsc.inc | 2 -- > 4 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Platform/Hisilicon/D02/Pv660D02.dsc b/Platform/Hisilicon/D02/Pv660D02.dsc > index 9e826ae..018e149 100644 > --- a/Platform/Hisilicon/D02/Pv660D02.dsc > +++ b/Platform/Hisilicon/D02/Pv660D02.dsc > @@ -80,6 +80,8 @@ > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > I2CLib|Silicon/Hisilicon/Library/I2CLib/I2CLibRuntime.inf > + SerialPortLib|Silicon/Hisilicon/Library/Dw8250SerialPortRuntimeLib/Dw8250SerialPortRuntimeLib.inf This change I agree with - this is a clear fix. > + DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf But this one just causes duplication of boilerplate. Could you instead put the fragment in Hisilicon.dsc.inc ... > > [BuildOptions] > GCC:*_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/Silicon/Hisilicon/Pv660/Include > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > index c496306..b9bce66 100644 > --- a/Platform/Hisilicon/D03/D03.dsc > +++ b/Platform/Hisilicon/D03/D03.dsc > @@ -97,6 +97,7 @@ > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > I2CLib|Silicon/Hisilicon/Library/I2CLib/I2CLibRuntime.inf > SerialPortLib|Silicon/Hisilicon/Hi1610/Library/Uart/LpcSerialPortLib/LpcSerialPortLib.inf > + DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > [BuildOptions] > GCC:*_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/Silicon/Hisilicon/Hi1610/Include > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > index 0792b08..dfee09b 100644 > --- a/Platform/Hisilicon/D05/D05.dsc > +++ b/Platform/Hisilicon/D05/D05.dsc > @@ -105,6 +105,7 @@ > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > I2CLib|Silicon/Hisilicon/Library/I2CLib/I2CLibRuntime.inf > SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf > + DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > [BuildOptions] > GCC:*_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/Silicon/Hisilicon/Hi1616/Include > diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc > index 5766829..b5b9e7e 100644 > --- a/Silicon/Hisilicon/Hisilicon.dsc.inc > +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc > @@ -208,8 +208,6 @@ > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > - SerialPortLib|Silicon/Hisilicon/Library/Dw8250SerialPortRuntimeLib/Dw8250SerialPortRuntimeLib.inf ... behind a conditional like !ifndef CONFIG_NO_DEBUGLIB > - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf !endif ? And correspondingly set CONFIG_NO_DEBUGLIB in hikey/hikey960 .dscs? Also, if this is a problem causes by using Hisilicon.dsc.inc, it should really go in before 2/4. This is great, by the way - I was not expecting that you would be able to reuse that, I thought there would be a separate .inc for hikey/hikey960. / Leif > > [LibraryClasses.AARCH64] > ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf > -- > 2.7.4 >