From: Leif Lindholm <leif.lindholm@linaro.org>
To: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org,
ard.sheuvel@linaro.org, heyi.guo@linaro.org
Subject: Re: [PATCH v2 1/4] Platform/Hisilicon/HiKey: include DxePcdLib for HiiDatabase
Date: Mon, 12 Feb 2018 11:45:45 +0000 [thread overview]
Message-ID: <20180212114545.tlg65kb7uffrpv2x@bivouac.eciton.net> (raw)
In-Reply-To: <1518197467-32526-2-git-send-email-haojian.zhuang@linaro.org>
On Sat, Feb 10, 2018 at 01:31:04AM +0800, Haojian Zhuang wrote:
> Include DxePcdLib for HiiDatabase. Otherwise, PlatformBootManager
> can't be launched successfully.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Platform/Hisilicon/HiKey/HiKey.dsc | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> index e8cb957..c7d931e 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> @@ -1,5 +1,5 @@
> #
> -# Copyright (c) 2014-2017, Linaro Limited. All rights reserved.
> +# Copyright (c) 2014-2018, Linaro Limited. All rights reserved.
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the BSD License
> @@ -422,7 +422,10 @@
> # Bds
> #
> MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> - MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> + MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf {
> + <LibraryClasses>
> + PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> + }
> MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-02-12 11:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 17:31 [PATCH v2 0/4] support HiKey960 Haojian Zhuang
2018-02-09 17:31 ` [PATCH v2 1/4] Platform/Hisilicon/HiKey: include DxePcdLib for HiiDatabase Haojian Zhuang
2018-02-12 11:45 ` Leif Lindholm [this message]
2018-02-09 17:31 ` [PATCH v2 2/4] Platform/Hisilicon/HiKey: use Hisilicon common file Haojian Zhuang
2018-02-12 11:46 ` Leif Lindholm
2018-02-09 17:31 ` [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from " Haojian Zhuang
2018-02-12 11:45 ` Leif Lindholm
2018-02-12 11:47 ` Haojian Zhuang
2018-02-12 12:05 ` Ard Biesheuvel
2018-02-12 12:19 ` Haojian Zhuang
2018-02-12 12:22 ` Ard Biesheuvel
2018-02-12 12:57 ` Haojian Zhuang
2018-02-15 15:41 ` Leif Lindholm
2018-02-16 0:55 ` Haojian Zhuang
2018-02-13 0:23 ` Guo Heyi
2018-02-13 0:59 ` Haojian Zhuang
2018-02-13 2:26 ` Guo Heyi
2018-02-09 17:31 ` [PATCH v2 4/4] Platform/Hisilicon/HiKey960: add skeleton of HiKey960 Haojian Zhuang
2018-02-12 11:50 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212114545.tlg65kb7uffrpv2x@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox