* [PATCH 1/4] OvmfPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions
2018-02-12 13:45 [PATCH 0/4] minuscule cleanups for Shell library resolutions Laszlo Ersek
@ 2018-02-12 13:45 ` Laszlo Ersek
2018-02-12 14:25 ` Ard Biesheuvel
2018-02-12 13:45 ` [PATCH 2/4] EmulatorPkg: " Laszlo Ersek
` (4 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Laszlo Ersek @ 2018-02-12 13:45 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Ard Biesheuvel, Jordan Justen
These are listed under "ShellPkg/Application/Shell/Shell.inf", but they
have been commented out ever since commit 345a0c8fce38 ("OvmfPkg: Add
support for UEFI shell", 2011-06-26). No such lib classes exist in edk2.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/OvmfPkgIa32.dsc | 2 --
OvmfPkg/OvmfPkgIa32X64.dsc | 2 --
OvmfPkg/OvmfPkgX64.dsc | 2 --
3 files changed, 6 deletions(-)
diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
index e10f8986077d..fbe0f790e431 100644
--- a/OvmfPkg/OvmfPkgIa32.dsc
+++ b/OvmfPkg/OvmfPkgIa32.dsc
@@ -807,8 +807,6 @@ [Components]
!endif
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
-# SafeBlockIoLib|ShellPkg/Library/SafeBlockIoLib/SafeBlockIoLib.inf
-# SafeOpenProtocolLib|ShellPkg/Library/SafeOpenProtocolLib/SafeOpenProtocolLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
<PcdsFixedAtBuild>
diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
index a31c7919ad0f..fb10e0b0f2e4 100644
--- a/OvmfPkg/OvmfPkgIa32X64.dsc
+++ b/OvmfPkg/OvmfPkgIa32X64.dsc
@@ -816,8 +816,6 @@ [Components.X64]
!endif
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
-# SafeBlockIoLib|ShellPkg/Library/SafeBlockIoLib/SafeBlockIoLib.inf
-# SafeOpenProtocolLib|ShellPkg/Library/SafeOpenProtocolLib/SafeOpenProtocolLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
<PcdsFixedAtBuild>
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index bc433a972400..a31551f5ae24 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
+++ b/OvmfPkg/OvmfPkgX64.dsc
@@ -814,8 +814,6 @@ [Components]
!endif
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
-# SafeBlockIoLib|ShellPkg/Library/SafeBlockIoLib/SafeBlockIoLib.inf
-# SafeOpenProtocolLib|ShellPkg/Library/SafeOpenProtocolLib/SafeOpenProtocolLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
<PcdsFixedAtBuild>
--
2.14.1.3.gb7cf6e02401b
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 1/4] OvmfPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions
2018-02-12 13:45 ` [PATCH 1/4] OvmfPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions Laszlo Ersek
@ 2018-02-12 14:25 ` Ard Biesheuvel
0 siblings, 0 replies; 11+ messages in thread
From: Ard Biesheuvel @ 2018-02-12 14:25 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: edk2-devel-01, Jordan Justen
On 12 February 2018 at 13:45, Laszlo Ersek <lersek@redhat.com> wrote:
> These are listed under "ShellPkg/Application/Shell/Shell.inf", but they
> have been commented out ever since commit 345a0c8fce38 ("OvmfPkg: Add
> support for UEFI shell", 2011-06-26). No such lib classes exist in edk2.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> OvmfPkg/OvmfPkgIa32.dsc | 2 --
> OvmfPkg/OvmfPkgIa32X64.dsc | 2 --
> OvmfPkg/OvmfPkgX64.dsc | 2 --
> 3 files changed, 6 deletions(-)
>
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index e10f8986077d..fbe0f790e431 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -807,8 +807,6 @@ [Components]
> !endif
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> -# SafeBlockIoLib|ShellPkg/Library/SafeBlockIoLib/SafeBlockIoLib.inf
> -# SafeOpenProtocolLib|ShellPkg/Library/SafeOpenProtocolLib/SafeOpenProtocolLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
> <PcdsFixedAtBuild>
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index a31c7919ad0f..fb10e0b0f2e4 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -816,8 +816,6 @@ [Components.X64]
> !endif
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> -# SafeBlockIoLib|ShellPkg/Library/SafeBlockIoLib/SafeBlockIoLib.inf
> -# SafeOpenProtocolLib|ShellPkg/Library/SafeOpenProtocolLib/SafeOpenProtocolLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
> <PcdsFixedAtBuild>
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index bc433a972400..a31551f5ae24 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -814,8 +814,6 @@ [Components]
> !endif
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> -# SafeBlockIoLib|ShellPkg/Library/SafeBlockIoLib/SafeBlockIoLib.inf
> -# SafeOpenProtocolLib|ShellPkg/Library/SafeOpenProtocolLib/SafeOpenProtocolLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
> <PcdsFixedAtBuild>
> --
> 2.14.1.3.gb7cf6e02401b
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/4] EmulatorPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions
2018-02-12 13:45 [PATCH 0/4] minuscule cleanups for Shell library resolutions Laszlo Ersek
2018-02-12 13:45 ` [PATCH 1/4] OvmfPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions Laszlo Ersek
@ 2018-02-12 13:45 ` Laszlo Ersek
2018-02-12 13:45 ` [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency Laszlo Ersek
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Laszlo Ersek @ 2018-02-12 13:45 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Andrew Fish, Jordan Justen
These are listed under "ShellPkg/Application/Shell/Shell.inf", but they
have been commented out ever since commit 3f2035e7a27a ("EmulatorPkg: Fix
build break.", 2011-06-28). No such lib classes exist in edk2.
Cc: Andrew Fish <afish@apple.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
EmulatorPkg/EmulatorPkg.dsc | 2 --
1 file changed, 2 deletions(-)
diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index ef56a86a322c..60688a4b1266 100644
--- a/EmulatorPkg/EmulatorPkg.dsc
+++ b/EmulatorPkg/EmulatorPkg.dsc
@@ -399,8 +399,6 @@ [Components]
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
-# SafeBlockIoLib|ShellPkg/Library/SafeBlockIoLib/SafeBlockIoLib.inf
-# SafeOpenProtocolLib|ShellPkg/Library/SafeOpenProtocolLib/SafeOpenProtocolLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
--
2.14.1.3.gb7cf6e02401b
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency
2018-02-12 13:45 [PATCH 0/4] minuscule cleanups for Shell library resolutions Laszlo Ersek
2018-02-12 13:45 ` [PATCH 1/4] OvmfPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions Laszlo Ersek
2018-02-12 13:45 ` [PATCH 2/4] EmulatorPkg: " Laszlo Ersek
@ 2018-02-12 13:45 ` Laszlo Ersek
2018-02-13 0:51 ` Zeng, Star
2018-02-13 2:50 ` Ni, Ruiyu
2018-02-12 13:45 ` [PATCH 4/4] ShellPkg: remove superfluous TimerLib resolution Laszlo Ersek
` (2 subsequent siblings)
5 siblings, 2 replies; 11+ messages in thread
From: Laszlo Ersek @ 2018-02-12 13:45 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Eric Dong, Jaben Carsey, Ruiyu Ni, Star Zeng
In commit 3a039a567a5f ("MdeModulePkg/UefiBootManagerLib: Remove the
useless perf codes", 2018-02-12), the BmWriteBootToOsPerformanceData()
function was removed. No TimerLib API calls are left, thus remove the
TimerLib class dependency from "InternalBm.h" and "UefiBootManagerLib.inf"
as well.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 -
MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
index 1adffd70d06a..8d5b89ea2970 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
+++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
@@ -52,7 +52,6 @@ [LibraryClasses]
PcdLib
BaseLib
UefiLib
- TimerLib
DebugLib
PrintLib
BaseMemoryLib
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
index ed0cd16ef322..25a1d522fe84 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
+++ b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
@@ -68,7 +68,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#include <Library/PcdLib.h>
#include <Library/PeCoffGetEntryPointLib.h>
#include <Library/UefiBootManagerLib.h>
-#include <Library/TimerLib.h>
#include <Library/DxeServicesLib.h>
#include <Library/ReportStatusCodeLib.h>
#include <Library/CapsuleLib.h>
--
2.14.1.3.gb7cf6e02401b
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency
2018-02-12 13:45 ` [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency Laszlo Ersek
@ 2018-02-13 0:51 ` Zeng, Star
2018-02-13 2:50 ` Ni, Ruiyu
1 sibling, 0 replies; 11+ messages in thread
From: Zeng, Star @ 2018-02-13 0:51 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-01
Cc: Dong, Eric, Carsey, Jaben, Ni, Ruiyu, Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
Thanks,
Star
-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com]
Sent: Monday, February 12, 2018 9:45 PM
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Dong, Eric <eric.dong@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency
In commit 3a039a567a5f ("MdeModulePkg/UefiBootManagerLib: Remove the useless perf codes", 2018-02-12), the BmWriteBootToOsPerformanceData() function was removed. No TimerLib API calls are left, thus remove the TimerLib class dependency from "InternalBm.h" and "UefiBootManagerLib.inf"
as well.
Cc: Eric Dong <eric.dong@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 -
MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
index 1adffd70d06a..8d5b89ea2970 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
+++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
@@ -52,7 +52,6 @@ [LibraryClasses]
PcdLib
BaseLib
UefiLib
- TimerLib
DebugLib
PrintLib
BaseMemoryLib
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
index ed0cd16ef322..25a1d522fe84 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
+++ b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
@@ -68,7 +68,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
#include <Library/PcdLib.h>
#include <Library/PeCoffGetEntryPointLib.h>
#include <Library/UefiBootManagerLib.h> -#include <Library/TimerLib.h> #include <Library/DxeServicesLib.h> #include <Library/ReportStatusCodeLib.h> #include <Library/CapsuleLib.h>
--
2.14.1.3.gb7cf6e02401b
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency
2018-02-12 13:45 ` [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency Laszlo Ersek
2018-02-13 0:51 ` Zeng, Star
@ 2018-02-13 2:50 ` Ni, Ruiyu
1 sibling, 0 replies; 11+ messages in thread
From: Ni, Ruiyu @ 2018-02-13 2:50 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-01; +Cc: Eric Dong, Jaben Carsey, Star Zeng
On 2/12/2018 9:45 PM, Laszlo Ersek wrote:
> In commit 3a039a567a5f ("MdeModulePkg/UefiBootManagerLib: Remove the
> useless perf codes", 2018-02-12), the BmWriteBootToOsPerformanceData()
> function was removed. No TimerLib API calls are left, thus remove the
> TimerLib class dependency from "InternalBm.h" and "UefiBootManagerLib.inf"
> as well.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 -
> MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> index 1adffd70d06a..8d5b89ea2970 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -52,7 +52,6 @@ [LibraryClasses]
> PcdLib
> BaseLib
> UefiLib
> - TimerLib
> DebugLib
> PrintLib
> BaseMemoryLib
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
> index ed0cd16ef322..25a1d522fe84 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
> @@ -68,7 +68,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> #include <Library/PcdLib.h>
> #include <Library/PeCoffGetEntryPointLib.h>
> #include <Library/UefiBootManagerLib.h>
> -#include <Library/TimerLib.h>
> #include <Library/DxeServicesLib.h>
> #include <Library/ReportStatusCodeLib.h>
> #include <Library/CapsuleLib.h>
>
Thanks!
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
--
Thanks,
Ray
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 4/4] ShellPkg: remove superfluous TimerLib resolution
2018-02-12 13:45 [PATCH 0/4] minuscule cleanups for Shell library resolutions Laszlo Ersek
` (2 preceding siblings ...)
2018-02-12 13:45 ` [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency Laszlo Ersek
@ 2018-02-12 13:45 ` Laszlo Ersek
2018-02-13 2:50 ` Ni, Ruiyu
2018-02-12 15:25 ` [PATCH 0/4] minuscule cleanups for Shell library resolutions Carsey, Jaben
2018-02-13 12:32 ` Laszlo Ersek
5 siblings, 1 reply; 11+ messages in thread
From: Laszlo Ersek @ 2018-02-12 13:45 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Jaben Carsey, Ruiyu Ni
TimerLib had to be resolved in commit 5ab97a64b51c ("ShellPkg/bcfg: Add
Shell Spec 2.2 modification functionality", 2017-03-01) because:
- the BCFG command started making calls to UefiBootManagerLib
(EfiBootManagerVariableToLoadOption(),
EfiBootManagerLoadOptionToVariable(), EfiBootManagerFreeLoadOption()),
- and "MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf"
depended on TimerLib.
Because TimerLib is platform-specific, but "ShellPkg/ShellPkg.dsc" is
meant to produce a UEFI shell binary that is platform-independent (see
"ShellBinPkg/ReadMe.txt"), we resolved TimerLib to
"BaseTimerLibNullTemplate.inf". (TimerLib functionality was never actually
needed on UefiBootManagerLib code paths that were exercised by the shell /
BCFG.)
Thanks to the last patch, UefiBootManagerLib no longer depends on
TimerLib, thus we can drop the TimerLib resolution entirely.
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
ShellPkg/ShellPkg.dsc | 1 -
1 file changed, 1 deletion(-)
diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc
index 29f537641285..1c923f585149 100644
--- a/ShellPkg/ShellPkg.dsc
+++ b/ShellPkg/ShellPkg.dsc
@@ -58,7 +58,6 @@ [LibraryClasses.common]
UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
- TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
--
2.14.1.3.gb7cf6e02401b
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 4/4] ShellPkg: remove superfluous TimerLib resolution
2018-02-12 13:45 ` [PATCH 4/4] ShellPkg: remove superfluous TimerLib resolution Laszlo Ersek
@ 2018-02-13 2:50 ` Ni, Ruiyu
0 siblings, 0 replies; 11+ messages in thread
From: Ni, Ruiyu @ 2018-02-13 2:50 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-01; +Cc: Jaben Carsey
On 2/12/2018 9:45 PM, Laszlo Ersek wrote:
> TimerLib had to be resolved in commit 5ab97a64b51c ("ShellPkg/bcfg: Add
> Shell Spec 2.2 modification functionality", 2017-03-01) because:
>
> - the BCFG command started making calls to UefiBootManagerLib
> (EfiBootManagerVariableToLoadOption(),
> EfiBootManagerLoadOptionToVariable(), EfiBootManagerFreeLoadOption()),
>
> - and "MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf"
> depended on TimerLib.
>
> Because TimerLib is platform-specific, but "ShellPkg/ShellPkg.dsc" is
> meant to produce a UEFI shell binary that is platform-independent (see
> "ShellBinPkg/ReadMe.txt"), we resolved TimerLib to
> "BaseTimerLibNullTemplate.inf". (TimerLib functionality was never actually
> needed on UefiBootManagerLib code paths that were exercised by the shell /
> BCFG.)
>
> Thanks to the last patch, UefiBootManagerLib no longer depends on
> TimerLib, thus we can drop the TimerLib resolution entirely.
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> ShellPkg/ShellPkg.dsc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc
> index 29f537641285..1c923f585149 100644
> --- a/ShellPkg/ShellPkg.dsc
> +++ b/ShellPkg/ShellPkg.dsc
> @@ -58,7 +58,6 @@ [LibraryClasses.common]
>
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> - TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>
Very great clean up.
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
--
Thanks,
Ray
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/4] minuscule cleanups for Shell library resolutions
2018-02-12 13:45 [PATCH 0/4] minuscule cleanups for Shell library resolutions Laszlo Ersek
` (3 preceding siblings ...)
2018-02-12 13:45 ` [PATCH 4/4] ShellPkg: remove superfluous TimerLib resolution Laszlo Ersek
@ 2018-02-12 15:25 ` Carsey, Jaben
2018-02-13 12:32 ` Laszlo Ersek
5 siblings, 0 replies; 11+ messages in thread
From: Carsey, Jaben @ 2018-02-12 15:25 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-01
Cc: Andrew Fish, Ard Biesheuvel, Dong, Eric, Justen, Jordan L,
Ni, Ruiyu, Zeng, Star
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Monday, February 12, 2018 5:45 AM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Cc: Andrew Fish <afish@apple.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Dong, Eric <eric.dong@intel.com>; Carsey,
> Jaben <jaben.carsey@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [PATCH 0/4] minuscule cleanups for Shell library resolutions
> Importance: High
>
> Repo: https://github.com/lersek/edk2.git
> Branch: shell_libs_cleanup
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
>
> Thanks
> Laszlo
>
> Laszlo Ersek (4):
> OvmfPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions
> EmulatorPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib
> resolutions
> MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib
> dependency
> ShellPkg: remove superfluous TimerLib resolution
>
> EmulatorPkg/EmulatorPkg.dsc | 2 --
> MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h | 1 -
> MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 -
> OvmfPkg/OvmfPkgIa32.dsc | 2 --
> OvmfPkg/OvmfPkgIa32X64.dsc | 2 --
> OvmfPkg/OvmfPkgX64.dsc | 2 --
> ShellPkg/ShellPkg.dsc | 1 -
> 7 files changed, 11 deletions(-)
>
> --
> 2.14.1.3.gb7cf6e02401b
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 0/4] minuscule cleanups for Shell library resolutions
2018-02-12 13:45 [PATCH 0/4] minuscule cleanups for Shell library resolutions Laszlo Ersek
` (4 preceding siblings ...)
2018-02-12 15:25 ` [PATCH 0/4] minuscule cleanups for Shell library resolutions Carsey, Jaben
@ 2018-02-13 12:32 ` Laszlo Ersek
5 siblings, 0 replies; 11+ messages in thread
From: Laszlo Ersek @ 2018-02-13 12:32 UTC (permalink / raw)
To: edk2-devel-01
Cc: Ruiyu Ni, Eric Dong, Ard Biesheuvel, Jordan Justen, Andrew Fish,
Jaben Carsey, Star Zeng
On 02/12/18 14:45, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: shell_libs_cleanup
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
>
> Thanks
> Laszlo
>
> Laszlo Ersek (4):
> OvmfPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions
> EmulatorPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib
> resolutions
> MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib
> dependency
> ShellPkg: remove superfluous TimerLib resolution
>
> EmulatorPkg/EmulatorPkg.dsc | 2 --
> MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h | 1 -
> MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 -
> OvmfPkg/OvmfPkgIa32.dsc | 2 --
> OvmfPkg/OvmfPkgIa32X64.dsc | 2 --
> OvmfPkg/OvmfPkgX64.dsc | 2 --
> ShellPkg/ShellPkg.dsc | 1 -
> 7 files changed, 11 deletions(-)
>
Thank you all for the feedpack; I pushed the following commits:
1 f3f80a57e164 OvmfPkg: drop stale SafeBlockIoLib and SafeOpenProtocolLib resolutions
2 bad0b5e87165 MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency
3 7a141b1306f6 ShellPkg: remove superfluous TimerLib resolution
Thanks
Laszlo
^ permalink raw reply [flat|nested] 11+ messages in thread