* [PATCH] ShellPkg/[hex]edit: Fix wrongly use gST->ConIn as the console handle
@ 2018-02-12 15:34 Ruiyu Ni
2018-02-12 17:03 ` Carsey, Jaben
0 siblings, 1 reply; 2+ messages in thread
From: Ruiyu Ni @ 2018-02-12 15:34 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
---
ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c | 2 +-
ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
index a197f80a40..4eb998bf5f 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
@@ -1497,7 +1497,7 @@ MainEditorInit (
// Find mouse in System Table ConsoleInHandle
//
Status = gBS->HandleProtocol (
- gST->ConIn,
+ gST->ConsoleInHandle,
&gEfiSimplePointerProtocolGuid,
(VOID**)&MainEditor.MouseInterface
);
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
index 065f8e95a7..2b096d7168 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
@@ -1682,7 +1682,7 @@ HMainEditorInit (
// Find mouse in System Table ConsoleInHandle
//
Status = gBS->HandleProtocol (
- gST->ConIn,
+ gST->ConsoleInHandle,
&gEfiSimplePointerProtocolGuid,
(VOID**)&HMainEditor.MouseInterface
);
--
2.16.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ShellPkg/[hex]edit: Fix wrongly use gST->ConIn as the console handle
2018-02-12 15:34 [PATCH] ShellPkg/[hex]edit: Fix wrongly use gST->ConIn as the console handle Ruiyu Ni
@ 2018-02-12 17:03 ` Carsey, Jaben
0 siblings, 0 replies; 2+ messages in thread
From: Carsey, Jaben @ 2018-02-12 17:03 UTC (permalink / raw)
To: Ni, Ruiyu, edk2-devel@lists.01.org
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Monday, February 12, 2018 7:34 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [edk2] [PATCH] ShellPkg/[hex]edit: Fix wrongly use gST->ConIn as
> the console handle
> Importance: High
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
> ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c | 2
> +-
> ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c |
> 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
> index a197f80a40..4eb998bf5f 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c
> @@ -1497,7 +1497,7 @@ MainEditorInit (
> // Find mouse in System Table ConsoleInHandle
> //
> Status = gBS->HandleProtocol (
> - gST->ConIn,
> + gST->ConsoleInHandle,
> &gEfiSimplePointerProtocolGuid,
> (VOID**)&MainEditor.MouseInterface
> );
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
> index 065f8e95a7..2b096d7168 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c
> @@ -1682,7 +1682,7 @@ HMainEditorInit (
> // Find mouse in System Table ConsoleInHandle
> //
> Status = gBS->HandleProtocol (
> - gST->ConIn,
> + gST->ConsoleInHandle,
> &gEfiSimplePointerProtocolGuid,
> (VOID**)&HMainEditor.MouseInterface
> );
> --
> 2.16.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-12 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-12 15:34 [PATCH] ShellPkg/[hex]edit: Fix wrongly use gST->ConIn as the console handle Ruiyu Ni
2018-02-12 17:03 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox