From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4003:c0f::242; helo=mail-ot0-x242.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-ot0-x242.google.com (mail-ot0-x242.google.com [IPv6:2607:f8b0:4003:c0f::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5E4BF223648B9 for ; Mon, 12 Feb 2018 16:17:24 -0800 (PST) Received: by mail-ot0-x242.google.com with SMTP id f18so15717294otf.6 for ; Mon, 12 Feb 2018 16:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MDmOUYrV1dYIU2vAb+Gahs7FuRjiBpgaAQ+kZacA5SY=; b=XaSsqj1EYU4fFYyVJOANM2mrXm+4QPyFH7Pzb3khwVCER1uUxJvgBMznICDRdTersB +21DdvdLKlX6NNh/SW94tYXLlRfnwBYVXRWekfYWQiTSvXRYcRXbZtVQyMenl2YQ39jb sWmlD31ziufOAS1lQE7jbK4goyvO9SG/vcHwk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MDmOUYrV1dYIU2vAb+Gahs7FuRjiBpgaAQ+kZacA5SY=; b=OE9FYXQXmDU9rmIYBDH4hLd5SSI8lktTyUhwy6S8IewggXkLdNv7ty1hI9sk4684uG SiHPOK4ioDhSl1T+CcjdwjOYItHDLXYt+78s1twFRLR7+/PExqq9LIfL3t1xBSS9Km+q URQzzB3y2vtEtmo0zE7ESLQ0I7DiVtc9E3yccMA0NzX5se5b87f8oKhy45vQ70029vGx eZEJZL/1BqY4BEFvXW2kuTsX6r1AUUkrtDFHH3GLrptAx4WHRLhnM1p/NnFtFAOsP4qT iqK5SEHH4ezXBm8eWGzsZLwGKna3n6bXtNhyBDft96NxacO4k8X2OmnGWEpDCUR7VdQm al1A== X-Gm-Message-State: APf1xPBU9728Z+hIVkGFuQdKUDdpQFU2llh1zqzrlzRXk1wKcUDEATVk WZl6oQZrmIb9mjSb9fZjCaa7xA== X-Google-Smtp-Source: AH8x226ZeiZ+hdAQpgZ2Ieqk4oHhfY//fubKN3DxvkX4Wo145sGYuoF0op+MIBqRfWom30ihYsgcGA== X-Received: by 10.157.44.2 with SMTP id f2mr10867320otb.180.1518481393594; Mon, 12 Feb 2018 16:23:13 -0800 (PST) Received: from SZX1000114654 ([104.237.91.79]) by smtp.gmail.com with ESMTPSA id k32sm5766024otb.69.2018.02.12.16.23.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 16:23:11 -0800 (PST) From: Guo Heyi X-Google-Original-From: Guo Heyi Date: Tue, 13 Feb 2018 08:23:07 +0800 To: Haojian Zhuang Cc: edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org, leif.lindholm@linaro.org, ard.sheuvel@linaro.org, heyi.guo@linaro.org Message-ID: <20180213002307.GA10678@SZX1000114654> References: <1518197467-32526-1-git-send-email-haojian.zhuang@linaro.org> <1518197467-32526-4-git-send-email-haojian.zhuang@linaro.org> MIME-Version: 1.0 In-Reply-To: <1518197467-32526-4-git-send-email-haojian.zhuang@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 00:17:24 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Haojian, Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there isn't such device on Hikey, then you can't use this library instance indeed. But I think PeiDxeDebugLibReportStatusCode should be some common code, however it depends on ReportStatusCodeLib and Status Code PEIM and Status code DXE driver. Have you added them too? Heyi On Sat, Feb 10, 2018 at 01:31:06AM +0800, Haojian Zhuang wrote: > With the SerialPortLib and DebugLib, Dxe runtime driver can't > be executed well on HiKey. Serial logs are missing. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang > --- > Platform/Hisilicon/D02/Pv660D02.dsc | 2 ++ > Platform/Hisilicon/D03/D03.dsc | 1 + > Platform/Hisilicon/D05/D05.dsc | 1 + > Silicon/Hisilicon/Hisilicon.dsc.inc | 2 -- > 4 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Platform/Hisilicon/D02/Pv660D02.dsc b/Platform/Hisilicon/D02/Pv660D02.dsc > index 9e826ae..018e149 100644 > --- a/Platform/Hisilicon/D02/Pv660D02.dsc > +++ b/Platform/Hisilicon/D02/Pv660D02.dsc > @@ -80,6 +80,8 @@ > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > I2CLib|Silicon/Hisilicon/Library/I2CLib/I2CLibRuntime.inf > + SerialPortLib|Silicon/Hisilicon/Library/Dw8250SerialPortRuntimeLib/Dw8250SerialPortRuntimeLib.inf > + DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > [BuildOptions] > GCC:*_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/Silicon/Hisilicon/Pv660/Include > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > index c496306..b9bce66 100644 > --- a/Platform/Hisilicon/D03/D03.dsc > +++ b/Platform/Hisilicon/D03/D03.dsc > @@ -97,6 +97,7 @@ > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > I2CLib|Silicon/Hisilicon/Library/I2CLib/I2CLibRuntime.inf > SerialPortLib|Silicon/Hisilicon/Hi1610/Library/Uart/LpcSerialPortLib/LpcSerialPortLib.inf > + DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > [BuildOptions] > GCC:*_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/Silicon/Hisilicon/Hi1610/Include > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > index 0792b08..dfee09b 100644 > --- a/Platform/Hisilicon/D05/D05.dsc > +++ b/Platform/Hisilicon/D05/D05.dsc > @@ -105,6 +105,7 @@ > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > I2CLib|Silicon/Hisilicon/Library/I2CLib/I2CLibRuntime.inf > SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf > + DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > [BuildOptions] > GCC:*_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/Silicon/Hisilicon/Hi1616/Include > diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc > index 5766829..b5b9e7e 100644 > --- a/Silicon/Hisilicon/Hisilicon.dsc.inc > +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc > @@ -208,8 +208,6 @@ > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > - SerialPortLib|Silicon/Hisilicon/Library/Dw8250SerialPortRuntimeLib/Dw8250SerialPortRuntimeLib.inf > - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > [LibraryClasses.AARCH64] > ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf > -- > 2.7.4 >