From: Guo Heyi <heyi.guo@linaro.org>
To: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: Guo Heyi <heyi.guo@linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"linaro-uefi@lists.linaro.org" <linaro-uefi@lists.linaro.org>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file
Date: Tue, 13 Feb 2018 10:26:45 +0800 [thread overview]
Message-ID: <20180213022645.GA11053@SZX1000114654> (raw)
In-Reply-To: <CY1PR15MB073096F565B694F636D4C1C197F60@CY1PR15MB0730.namprd15.prod.outlook.com>
On Tue, Feb 13, 2018 at 12:59:50AM +0000, Haojian Zhuang wrote:
> On 02/13/2018 08:23 AM, Guo Heyi wrote:
> > Hi Haojian,
> >
> > Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there
> > isn't such device on Hikey, then you can't use this library instance indeed.
> >
> > But I think PeiDxeDebugLibReportStatusCode should be some common code, however
> > it depends on ReportStatusCodeLib and Status Code PEIM and Status code DXE
> > driver. Have you added them too?
> >
> If I leave PeiDxeDebugLibReportStatusCode and move Dw8250SerialPortRuntimeLib out,
> I'll meet UEFI crash. It seems the debug lib is depended on serial port lib.
This is strange, because you should have your own SerialPortLib of your
platform, otherwise error will occur when you build your UEFI.
>
> And I consider that Dw8250 serial port is only valid on D02. So I decide to move them out.
I agree.
Regards,
Heyi
>
> Best Regards
> Haojian
next prev parent reply other threads:[~2018-02-13 2:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 17:31 [PATCH v2 0/4] support HiKey960 Haojian Zhuang
2018-02-09 17:31 ` [PATCH v2 1/4] Platform/Hisilicon/HiKey: include DxePcdLib for HiiDatabase Haojian Zhuang
2018-02-12 11:45 ` Leif Lindholm
2018-02-09 17:31 ` [PATCH v2 2/4] Platform/Hisilicon/HiKey: use Hisilicon common file Haojian Zhuang
2018-02-12 11:46 ` Leif Lindholm
2018-02-09 17:31 ` [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from " Haojian Zhuang
2018-02-12 11:45 ` Leif Lindholm
2018-02-12 11:47 ` Haojian Zhuang
2018-02-12 12:05 ` Ard Biesheuvel
2018-02-12 12:19 ` Haojian Zhuang
2018-02-12 12:22 ` Ard Biesheuvel
2018-02-12 12:57 ` Haojian Zhuang
2018-02-15 15:41 ` Leif Lindholm
2018-02-16 0:55 ` Haojian Zhuang
2018-02-13 0:23 ` Guo Heyi
2018-02-13 0:59 ` Haojian Zhuang
2018-02-13 2:26 ` Guo Heyi [this message]
2018-02-09 17:31 ` [PATCH v2 4/4] Platform/Hisilicon/HiKey960: add skeleton of HiKey960 Haojian Zhuang
2018-02-12 11:50 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213022645.GA11053@SZX1000114654 \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox