From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::234; helo=mail-io0-x234.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 801B321CF1CED for ; Mon, 12 Feb 2018 18:21:00 -0800 (PST) Received: by mail-io0-x234.google.com with SMTP id b198so19641098iof.6 for ; Mon, 12 Feb 2018 18:26:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rq/vKgZY1515liuUK3u9+71z89VmexpFesVs4kUYf18=; b=kjUxav6vwyr3sYpoPUKqsOD0EJEYqWLCNOTZ5RQpk3fXcTbLGfR37cpIn8p9i0mUBV Lej0FsXwhG/ZGytf8zqrs6O4brSEVy0EKiMcOOiOoO1MeVu6miisM1T7QVCVEfFi+Zqv 68Rt6adJ8xC87n3A5QjrK1cCd7ECgFCXpV3RI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rq/vKgZY1515liuUK3u9+71z89VmexpFesVs4kUYf18=; b=GoPMmYTmgTN2yf67v8aW9RtazZ0RSbXyCmSsWn1d86uGcy1MVwfvdwQY40WzqxYoem GFuo6AfT9/LBPjLTgK+l1wja23bxmq40xvTgNAJbtLsdSikGfI3gePbWI0cGXi5rmvKR /xjH8PzzNDVUpkQnWJZGJAOxC1bxPpJ8h3bNvjlFQ0zGbJxqRSXt3Rl+V4tCaOdN3r1N RYPDLX7z7Svs9WT/lKInBi+zBkI+nlU+3TVpFwGouux9JtA403IeVhC9WnUrK2hiL4Qo 9GToaoEvUSXjeIlhyAkE8oCijCC0yxM78+B6RSkAstYw87Zb0ehKJljNtMkHSAs+rLTi NUdg== X-Gm-Message-State: APf1xPCS1psuMB0hOyLJJyW49dc/jPcXiPFMpgQjM3ByzMxwCuSFcUqI 2F3NG3mlzvIUQb/Nb3irGO/lH14dHkk= X-Google-Smtp-Source: AH8x224GbacwDzvxD5mekFRguaR4gbuVmDUNb+H31gLoVC+UMwELzPcBma09PN53w/W+/jzLP9grJg== X-Received: by 10.107.69.8 with SMTP id s8mr2922447ioa.156.1518488809626; Mon, 12 Feb 2018 18:26:49 -0800 (PST) Received: from SZX1000114654 ([104.237.91.79]) by smtp.gmail.com with ESMTPSA id b34sm8818360itd.38.2018.02.12.18.26.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 18:26:49 -0800 (PST) From: Guo Heyi X-Google-Original-From: Guo Heyi Date: Tue, 13 Feb 2018 10:26:45 +0800 To: Haojian Zhuang Cc: Guo Heyi , "edk2-devel@lists.01.org" , "linaro-uefi@lists.linaro.org" , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Message-ID: <20180213022645.GA11053@SZX1000114654> References: <1518197467-32526-1-git-send-email-haojian.zhuang@linaro.org> <1518197467-32526-4-git-send-email-haojian.zhuang@linaro.org> <20180213002307.GA10678@SZX1000114654> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 02:21:01 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 13, 2018 at 12:59:50AM +0000, Haojian Zhuang wrote: > On 02/13/2018 08:23 AM, Guo Heyi wrote: > > Hi Haojian, > > > > Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there > > isn't such device on Hikey, then you can't use this library instance indeed. > > > > But I think PeiDxeDebugLibReportStatusCode should be some common code, however > > it depends on ReportStatusCodeLib and Status Code PEIM and Status code DXE > > driver. Have you added them too? > > > If I leave PeiDxeDebugLibReportStatusCode and move Dw8250SerialPortRuntimeLib out, > I'll meet UEFI crash. It seems the debug lib is depended on serial port lib. This is strange, because you should have your own SerialPortLib of your platform, otherwise error will occur when you build your UEFI. > > And I consider that Dw8250 serial port is only valid on D02. So I decide to move them out. I agree. Regards, Heyi > > Best Regards > Haojian