From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 38C2A220F33EB for ; Thu, 15 Feb 2018 04:43:52 -0800 (PST) Received: by mail-wm0-x243.google.com with SMTP id 141so608081wme.3 for ; Thu, 15 Feb 2018 04:49:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7fqzewKu9aqVGbfmQpE731hiR2RmWRAKPnwXT3/mMk0=; b=i7dUtn90IX5gUGlzShw4QpvIdMgZjZr7deN4wAntfSxzABWeJENjJfDfSfm3EdHY4T mQGiWVE3C1Fp/a0IMMhD/qCX56wTu9VodP6qKlj/e8+m1x6L2e0zMatMqFTgdwS3xADW N34dskSXkT52dAdlPsLDiLWqwdww3NzVJK5yY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7fqzewKu9aqVGbfmQpE731hiR2RmWRAKPnwXT3/mMk0=; b=FRfZP5p/7zMNOYDrZv9J8pr3joElntutL5tis35epoSPiN2mWEpdFMYRswmWPA94oM elIpWwS2QnGtauV/7xUHpKVrBoEq8v7lbH4o7QGxEl7sgDwLk35G2NOUTCiLBlVObpxY rnEUoZuqAWxaUETiJOP5PKyh3AkWjf1gqtIqwk0n+JluJnjWE4mtBxP9Tw0Wu7upnhRj CSt0l56RZ8kJTD/K8z7f3cXF5nlktCphqsNSPeyUWVyczKldZ7AlpvUzpFWb1posBYSJ qSBOrOqa1aQd8+/z4xt8Vab52POYGr//wsUF4k6QhDB6kbXbhEB9/RymkFizWhhhc1Dm 1bOA== X-Gm-Message-State: APf1xPBI8iuBXp5mAutRjY2LonduDVyb0PKCfPnXwpeiOqGKktiSX46v Z1ELHC4mJ1UjQDyDwWDxOlPMTQ== X-Google-Smtp-Source: AH8x225u44MsnwG0LfYNkk0t+1UqpNcdjF0FG4dyD+oTy/fLMpIOy4EMwxvSwk45DWlxl77NRtQQdw== X-Received: by 10.28.58.208 with SMTP id h199mr2134556wma.79.1518698983666; Thu, 15 Feb 2018 04:49:43 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h90sm9005974wrh.44.2018.02.15.04.49.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Feb 2018 04:49:42 -0800 (PST) Date: Thu, 15 Feb 2018 12:49:40 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20180215124940.w57gpaeca6t2kanx@bivouac.eciton.net> References: <20180215103428.25726-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180215103428.25726-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] EmbeddedPkg/FdtLib: incorporate missing overlay support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Feb 2018 12:43:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 15, 2018 at 10:34:28AM +0000, Ard Biesheuvel wrote: > Commit a099239015eb ("EmbeddedPkg/FdtLib: Update FdtLib to v1.4.5") > updated our FdtLib implementation to a more recent upstream version, > but omitted fdt_overlay.c due to its ambiguous licensing situation. > This has been resolved now, so take the latest upstream version of > the file (which received no other modifications in the mean time) > and add it to FdtLib. > > Note that fdt_overlay.c has a dependency on strtoul() which EDK does > not provide natively, so add a private implementation that wraps the > BaseLib routines that do roughly the same. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel LGTM Reviewed-by: Leif Lindholm > --- > EmbeddedPkg/Include/libfdt.h | 31 + > EmbeddedPkg/Library/FdtLib/FdtLib.inf | 6 + > EmbeddedPkg/Library/FdtLib/fdt_overlay.c | 914 ++++++++++++++++++++ > EmbeddedPkg/Library/FdtLib/fdt_strtoul.c | 38 + > 4 files changed, 989 insertions(+)