From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B411F220F33C8 for ; Thu, 15 Feb 2018 07:36:02 -0800 (PST) Received: by mail-wm0-x243.google.com with SMTP id v71so1640752wmv.2 for ; Thu, 15 Feb 2018 07:41:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=83bjVXQ6V1P27ZLLQJUS230qzonE95m/7SIWJQDIc/w=; b=Luh55SGeoZd50FROsXRgBeVkwLOf0IllCZslFqiM5Y21HrETnq4NAxrwPcjHt5/H3W ycOOcquQkHFYfTFtgmIIG3/TjRVAUiSW08XWG085EvqofkRimpwqCxuhNL1437CQFrZ3 Ze36fhBCHqIYOkBJKguTbTIbUQ13+vbptlj7c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=83bjVXQ6V1P27ZLLQJUS230qzonE95m/7SIWJQDIc/w=; b=DtcNVsL984YPvhe9LQy5hkxrQqEWA6X3ZiVFesKCquAjyb+LDGGD9NMFbmw3GzMDKQ PgcTpPE2bPawjs/gVSSgL2gi/6evIDsvG7KNXOZickJQrj30aFYKHJEwlYeF2o9u02Nr hmxIvlGz8W/09QpYfrqQ6VP+CYW0djYQnZ92KYFMNkHwTICIrUVY1q77sbnGnWotADMn IyG5WX9GbAGcpZV/msow3AgSh8xqo0LOAOEo52h3u1VG9nRe6BBxYAqucKIuLRbYdMYy vEHCr0JLCff8tkMLj9xkYVzzNR5Pn5tss8QLd4YqI+jpz0lAK25+zPfhKnLGDnrQc5N4 nv5g== X-Gm-Message-State: APf1xPC5gWB/iHlX7yNN0My2wIsHD9NGG2S3gejod2x0YFS3KnRh+PDW Pv8xTajg+96dQtWGiEnPtzx2Fw== X-Google-Smtp-Source: AH8x227pinoOmqQwVIDsTxXlqdGUU/z7KM0pe6cXOQuwEssPaoRfp5Qf9NDktaY3jwiyCa8Yyt+PBg== X-Received: by 10.28.136.139 with SMTP id k133mr2330143wmd.11.1518709314031; Thu, 15 Feb 2018 07:41:54 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z1sm15918488wre.25.2018.02.15.07.41.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Feb 2018 07:41:52 -0800 (PST) Date: Thu, 15 Feb 2018 15:41:51 +0000 From: Leif Lindholm To: Haojian Zhuang Cc: edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org, ard.biesheuvel@linaro.org, heyi.guo@linaro.org Message-ID: <20180215154151.lr6gvbdbl3fqsxys@bivouac.eciton.net> References: <1518197467-32526-1-git-send-email-haojian.zhuang@linaro.org> <1518197467-32526-4-git-send-email-haojian.zhuang@linaro.org> <20180212114506.gfu4hfz566jg7vvw@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: <20180212114506.gfu4hfz566jg7vvw@bivouac.eciton.net> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Feb 2018 15:36:03 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 12, 2018 at 11:45:06AM +0000, Leif Lindholm wrote: > On Sat, Feb 10, 2018 at 01:31:06AM +0800, Haojian Zhuang wrote: > > With the SerialPortLib and DebugLib, Dxe runtime driver can't > > be executed well on HiKey. Serial logs are missing. > > "Can't be executed well"? Does this mean it crashes? You replied to this question, but not the further ones below. Can you have a look, please? / Leif > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Haojian Zhuang > > --- > > Platform/Hisilicon/D02/Pv660D02.dsc | 2 ++ > > Platform/Hisilicon/D03/D03.dsc | 1 + > > Platform/Hisilicon/D05/D05.dsc | 1 + > > Silicon/Hisilicon/Hisilicon.dsc.inc | 2 -- > > 4 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/Platform/Hisilicon/D02/Pv660D02.dsc b/Platform/Hisilicon/D02/Pv660D02.dsc > > index 9e826ae..018e149 100644 > > --- a/Platform/Hisilicon/D02/Pv660D02.dsc > > +++ b/Platform/Hisilicon/D02/Pv660D02.dsc > > @@ -80,6 +80,8 @@ > > > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > I2CLib|Silicon/Hisilicon/Library/I2CLib/I2CLibRuntime.inf > > + SerialPortLib|Silicon/Hisilicon/Library/Dw8250SerialPortRuntimeLib/Dw8250SerialPortRuntimeLib.inf > > This change I agree with - this is a clear fix. > > > + DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > But this one just causes duplication of boilerplate. > Could you instead put the fragment in Hisilicon.dsc.inc ... > > > > > [BuildOptions] > > GCC:*_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/Silicon/Hisilicon/Pv660/Include > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > > index c496306..b9bce66 100644 > > --- a/Platform/Hisilicon/D03/D03.dsc > > +++ b/Platform/Hisilicon/D03/D03.dsc > > @@ -97,6 +97,7 @@ > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > I2CLib|Silicon/Hisilicon/Library/I2CLib/I2CLibRuntime.inf > > SerialPortLib|Silicon/Hisilicon/Hi1610/Library/Uart/LpcSerialPortLib/LpcSerialPortLib.inf > > + DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > > > [BuildOptions] > > GCC:*_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/Silicon/Hisilicon/Hi1610/Include > > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > > index 0792b08..dfee09b 100644 > > --- a/Platform/Hisilicon/D05/D05.dsc > > +++ b/Platform/Hisilicon/D05/D05.dsc > > @@ -105,6 +105,7 @@ > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > I2CLib|Silicon/Hisilicon/Library/I2CLib/I2CLibRuntime.inf > > SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf > > + DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > > > [BuildOptions] > > GCC:*_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/Silicon/Hisilicon/Hi1616/Include > > diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc > > index 5766829..b5b9e7e 100644 > > --- a/Silicon/Hisilicon/Hisilicon.dsc.inc > > +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc > > @@ -208,8 +208,6 @@ > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > > - SerialPortLib|Silicon/Hisilicon/Library/Dw8250SerialPortRuntimeLib/Dw8250SerialPortRuntimeLib.inf > > ... behind a conditional like > > !ifndef CONFIG_NO_DEBUGLIB > > - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > !endif > > ? > > And correspondingly set CONFIG_NO_DEBUGLIB in hikey/hikey960 .dscs? > > Also, if this is a problem causes by using Hisilicon.dsc.inc, it > should really go in before 2/4. > This is great, by the way - I was not expecting that you would be able > to reuse that, I thought there would be a separate .inc for > hikey/hikey960. > > / > Leif > > > > > [LibraryClasses.AARCH64] > > ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerPhyCounterLib/ArmGenericTimerPhyCounterLib.inf > > -- > > 2.7.4 > >