public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH edk2-platforms] AMD, Hisilicon, Socionext: fix build after DxeCapsuleLibFmp changes
Date: Thu, 15 Feb 2018 16:32:38 +0000	[thread overview]
Message-ID: <20180215163238.lnnbsfrnvw3jtpgk@bivouac.eciton.net> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B8966F4F@ORSMSX113.amr.corp.intel.com>

On Wed, Feb 14, 2018 at 09:11:59PM +0000, Kinney, Michael D wrote:
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Thanks - pushed as ce6c2604be.

Regards,

Leif

> Mike
> 
> > -----Original Message-----
> > From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> > Sent: Tuesday, February 13, 2018 8:46 AM
> > To: edk2-devel@lists.01.org
> > Cc: ard.biesheuvel@linaro.org; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: [PATCH edk2-platforms] AMD, Hisilicon,
> > Socionext: fix build after DxeCapsuleLibFmp changes
> > 
> > edk2 commit 1ec2e7d0e8db
> > ("MdeModulePkg/DxeCapsuleLibFmp: Use BmpSupportLib")
> > broke the build of
> > all platforms that include DxeCapsuleLibFmp, since none
> > of them included
> > a BmpSupportLib (added as part of the same series).
> > 
> > BmpSupportLib itself depends on SafeIntLib, so add the
> > two libraries to
> > all affected platforms.
> > 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> >  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > | 2 ++
> >  Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> > | 2 ++
> > 
> > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.
> > dsc | 2 ++
> >  Silicon/Hisilicon/Hisilicon.dsc.inc
> > | 2 ++
> >  4 files changed, 8 insertions(+)
> > 
> > diff --git
> > a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > index 48018abc69..7d85b78642 100644
> > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > @@ -49,6 +49,8 @@ [LibraryClasses.common]
> > 
> > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErro
> > rLevelLib/BaseDebugPrintErrorLevelLib.inf
> > 
> >    BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> > +
> > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base
> > BmpSupportLib.inf
> > +
> > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i
> > nf
> > 
> > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/
> > BaseSynchronizationLib.inf
> > 
> > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base
> > PerformanceLibNull.inf
> >    PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> > diff --git
> > a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> > b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> > index 7e69eaba9b..3c109b495f 100644
> > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> > @@ -75,6 +75,8 @@ [LibraryClasses.common]
> > 
> > ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerP
> > hyCounterLib/ArmGenericTimerPhyCounterLib.inf
> > 
> >    BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> > +
> > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base
> > BmpSupportLib.inf
> > +
> > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i
> > nf
> > 
> > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/
> > BaseSynchronizationLib.inf
> > 
> > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base
> > PerformanceLibNull.inf
> >    PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> > diff --git
> > a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar
> > d.dsc
> > b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar
> > d.dsc
> > index e35c17f0bc..45ab2afc40 100644
> > ---
> > a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar
> > d.dsc
> > +++
> > b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar
> > d.dsc
> > @@ -75,6 +75,8 @@ [LibraryClasses.common]
> > 
> > ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerP
> > hyCounterLib/ArmGenericTimerPhyCounterLib.inf
> > 
> >    BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> > +
> > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base
> > BmpSupportLib.inf
> > +
> > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i
> > nf
> > 
> > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/
> > BaseSynchronizationLib.inf
> > 
> > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base
> > PerformanceLibNull.inf
> >    PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> > diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc
> > b/Silicon/Hisilicon/Hisilicon.dsc.inc
> > index 57668294cb..1d6d20ca1d 100644
> > --- a/Silicon/Hisilicon/Hisilicon.dsc.inc
> > +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc
> > @@ -22,6 +22,8 @@ [LibraryClasses.common]
> > 
> > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErro
> > rLevelLib/BaseDebugPrintErrorLevelLib.inf
> > 
> >    BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> > +
> > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base
> > BmpSupportLib.inf
> > +
> > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i
> > nf
> > 
> > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/
> > BaseSynchronizationLib.inf
> > 
> > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base
> > PerformanceLibNull.inf
> >    PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> > --
> > 2.11.0
> 


      reply	other threads:[~2018-02-15 16:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13 16:45 [PATCH edk2-platforms] AMD, Hisilicon, Socionext: fix build after DxeCapsuleLibFmp changes Leif Lindholm
2018-02-13 18:27 ` Kinney, Michael D
2018-02-14 21:11 ` Kinney, Michael D
2018-02-15 16:32   ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180215163238.lnnbsfrnvw3jtpgk@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox