From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 48433220F33C3 for ; Thu, 15 Feb 2018 08:26:50 -0800 (PST) Received: by mail-wr0-x242.google.com with SMTP id n7so263059wrn.5 for ; Thu, 15 Feb 2018 08:32:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hru9md+DZxh2HI7NB7B//+47Q7NI2esaFB35QdIDzhE=; b=IqbmwCtrNEXql23OG6nhhkVpxJWKjM3x6971rMrRZB4S+99q8mAvAYzMGRCWACH3vv uBmmvUegXfWQygnrKtoS3Q3+L3ulszfmFDqNyh5L7K7TchlfxT1x69XTzCepu/gayuQU BVBwfFt1p8AYa45Pr0IOsu4hIgs264FRK0raA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hru9md+DZxh2HI7NB7B//+47Q7NI2esaFB35QdIDzhE=; b=n7i8X6sBiP8IV40RaPumBQ4UiInyRNXVI5/uULhcZHSv8jws++MHY032SrGzHDlFFF LR5hpl72pRzR7Cv8SH6rguqpmjxHtHoIPNU6CySgo2qOSuvFo6eYKT6dxdC0B1ovH5E0 u6MbVp1ok7Es2eZ3we78d2twSyfaTuC+JZILiHXaD/avye7YJOYRoFKVxs5WFV3T/eYd NwFYHDG7PgPI7BgP0HNQvGa277xCEKkcT9k1SXabBjFl5U8gGDHNhKRipePCCcrhm1bR m32vfgGSPNWC59pMn9GCAAPOayhMyHHsXyeF3CUv4U8Ob3s24ZJpFuzgDmFCtGC3xqwS ATmQ== X-Gm-Message-State: APf1xPAyZGGN7TX5TYXSfisidQiFcaUbT29sWMvTxR2Jm6BAbLg8b0V4 UnCKiofstMYMW5oDU5oPMrt7zA== X-Google-Smtp-Source: AH8x224AfXLpCTeR5kAhiUwTd5xViWfaRc4NGxkDbNhviidoSsF0NNSBwwgVjhC4Yo84S/fLLkvO7A== X-Received: by 10.223.173.163 with SMTP id w32mr3174926wrc.204.1518712361681; Thu, 15 Feb 2018 08:32:41 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id i4sm11772545wmf.3.2018.02.15.08.32.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Feb 2018 08:32:40 -0800 (PST) Date: Thu, 15 Feb 2018 16:32:38 +0000 From: Leif Lindholm To: "Kinney, Michael D" Cc: "edk2-devel@lists.01.org" , "ard.biesheuvel@linaro.org" Message-ID: <20180215163238.lnnbsfrnvw3jtpgk@bivouac.eciton.net> References: <20180213164554.5333-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms] AMD, Hisilicon, Socionext: fix build after DxeCapsuleLibFmp changes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Feb 2018 16:26:50 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 14, 2018 at 09:11:59PM +0000, Kinney, Michael D wrote: > Reviewed-by: Michael D Kinney Thanks - pushed as ce6c2604be. Regards, Leif > Mike > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Tuesday, February 13, 2018 8:46 AM > > To: edk2-devel@lists.01.org > > Cc: ard.biesheuvel@linaro.org; Kinney, Michael D > > > > Subject: [PATCH edk2-platforms] AMD, Hisilicon, > > Socionext: fix build after DxeCapsuleLibFmp changes > > > > edk2 commit 1ec2e7d0e8db > > ("MdeModulePkg/DxeCapsuleLibFmp: Use BmpSupportLib") > > broke the build of > > all platforms that include DxeCapsuleLibFmp, since none > > of them included > > a BmpSupportLib (added as part of the same series). > > > > BmpSupportLib itself depends on SafeIntLib, so add the > > two libraries to > > all affected platforms. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Leif Lindholm > > --- > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > | 2 ++ > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > | 2 ++ > > > > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard. > > dsc | 2 ++ > > Silicon/Hisilicon/Hisilicon.dsc.inc > > | 2 ++ > > 4 files changed, 8 insertions(+) > > > > diff --git > > a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > index 48018abc69..7d85b78642 100644 > > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > @@ -49,6 +49,8 @@ [LibraryClasses.common] > > > > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErro > > rLevelLib/BaseDebugPrintErrorLevelLib.inf > > > > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > > + > > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base > > BmpSupportLib.inf > > + > > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i > > nf > > > > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/ > > BaseSynchronizationLib.inf > > > > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base > > PerformanceLibNull.inf > > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > > diff --git > > a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > index 7e69eaba9b..3c109b495f 100644 > > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > @@ -75,6 +75,8 @@ [LibraryClasses.common] > > > > ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerP > > hyCounterLib/ArmGenericTimerPhyCounterLib.inf > > > > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > > + > > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base > > BmpSupportLib.inf > > + > > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i > > nf > > > > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/ > > BaseSynchronizationLib.inf > > > > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base > > PerformanceLibNull.inf > > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > > diff --git > > a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar > > d.dsc > > b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar > > d.dsc > > index e35c17f0bc..45ab2afc40 100644 > > --- > > a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar > > d.dsc > > +++ > > b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar > > d.dsc > > @@ -75,6 +75,8 @@ [LibraryClasses.common] > > > > ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerP > > hyCounterLib/ArmGenericTimerPhyCounterLib.inf > > > > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > > + > > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base > > BmpSupportLib.inf > > + > > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i > > nf > > > > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/ > > BaseSynchronizationLib.inf > > > > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base > > PerformanceLibNull.inf > > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > > diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc > > b/Silicon/Hisilicon/Hisilicon.dsc.inc > > index 57668294cb..1d6d20ca1d 100644 > > --- a/Silicon/Hisilicon/Hisilicon.dsc.inc > > +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc > > @@ -22,6 +22,8 @@ [LibraryClasses.common] > > > > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErro > > rLevelLib/BaseDebugPrintErrorLevelLib.inf > > > > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > > + > > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base > > BmpSupportLib.inf > > + > > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i > > nf > > > > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/ > > BaseSynchronizationLib.inf > > > > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base > > PerformanceLibNull.inf > > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > > -- > > 2.11.0 >