From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1A007223C179C for ; Tue, 20 Feb 2018 06:16:50 -0800 (PST) Received: by mail-wr0-x241.google.com with SMTP id v65so14851364wrc.11 for ; Tue, 20 Feb 2018 06:22:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iFv6gHZnH/ymFWofV51mwCsrl178NNzOD1RsjJcaHb0=; b=hdUxzd7ycQFDHLXm9w8ykaJSY+ruNfRWTvDYPiRPq1vkSFoS89MVmmBudzmAJorNHQ Popb19PObEmniZMfbCxuguenLkCimxmONdZHZuoJj356bHI67WchdJclc8d8St9EEMgb zXLU32Bs1tPQNPfxdRFoebz/n2XiZ1urX4PV4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iFv6gHZnH/ymFWofV51mwCsrl178NNzOD1RsjJcaHb0=; b=Uo9aLyke6Yg13QnmjGMIIwoDAXq4tNuzN1U8K2P8OdYcYrsBflinqeMB/jcRwlOfI9 HHuuDL78jKv2o3ty0TSPkdjV5QEFhGuvau5/UaUKW6bIREIKaMOkUXlzzA/h7np4fYg+ AXdmgvx6T++YA6P7dsTLqOfVdPvaGhaaSLOtXMD8uN1SPnVcaeDJ597w173HkxDOVK44 +u5S0M0KcEubIWA6IqTgdjFNq7KsbALI/0+l3di77Dv6kY+moqPSc3fgvOSbfLp3O8+V iAfYDYSDw+HsCuhPc9oG15h9mg2htKVu5UJ5ggttQHKTYU98BImWOfGtRnb3a48NF7V/ 9+RA== X-Gm-Message-State: APf1xPBxYAOrtoGX3jOEBkDrBddJT5NAbadG9wJDXc9hAFoCMElFeRsQ pqn34UrNRstk842JsMA9TR1fww== X-Google-Smtp-Source: AH8x226Z7awe3yDpoXCyk5BCDLPAdMCzmGaXVRn7eaYCckfVdVWHjdtS2In8nRvWYAw2n/+ruCCxTg== X-Received: by 10.223.160.125 with SMTP id l58mr6882853wrl.264.1519136567478; Tue, 20 Feb 2018 06:22:47 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e67sm60949483wmf.7.2018.02.20.06.22.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Feb 2018 06:22:46 -0800 (PST) Date: Tue, 20 Feb 2018 14:22:44 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, ruiyu.ni@intel.com, michael.d.kinney@intel.com, liming.gao@intel.com, lersek@redhat.com, star.zeng@intel.com, afish@apple.com Message-ID: <20180220142244.i6sbbeph2mbycayz@bivouac.eciton.net> References: <20180220110524.9050-1-ard.biesheuvel@linaro.org> <20180220110524.9050-4-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180220110524.9050-4-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 3/3] MdePkg/BaseDebugLibSerialPort: blacklist for use by DXE runtime drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2018 14:16:51 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 20, 2018 at 11:05:24AM +0000, Ard Biesheuvel wrote: > BaseDebugLibSerialPort is not suitable for use by DXE_RUNTIME_DRIVER > modules, so blacklist it for use by such modules. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf b/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > index 823511b22f6b..25da1fb9363a 100644 > --- a/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > +++ b/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > @@ -21,7 +21,7 @@ [Defines] > FILE_GUID = BB83F95F-EDBC-4884-A520-CD42AF388FAE > MODULE_TYPE = BASE > VERSION_STRING = 1.0 > - LIBRARY_CLASS = DebugLib > + LIBRARY_CLASS = DebugLib|SEC PEI_CORE PEIM DXE_CORE DXE_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION SMM_CORE MM_STANDALONE MM_CORE_STANDALONE Not a comment on this patch as such (which looks sensible to me), but what you're doing here isn't blacklisting DXE_RUNTIME_DRIVER, but rather whitelisting every other module type. Could we use a ! operator added to the syntax? / Leif > CONSTRUCTOR = BaseDebugLibSerialPortConstructor > > # > -- > 2.11.0 >