From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2179A2034D8F0 for ; Thu, 22 Feb 2018 02:26:34 -0800 (PST) Received: by mail-it0-x242.google.com with SMTP id l187so5925005ith.4 for ; Thu, 22 Feb 2018 02:32:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=f88+qx25KgQRKnw0tMjG/6vIvz+qV5LMTlPxgd+r404=; b=UyfqkftArmgSlFSmf7hhohzU7wKBn0A0P5J89OrwwuvAmt0CNK3w+05QigsTL/kFVs HMNNiwv7gGYIs+vLOCyo8ZHkz34HaizrwZsYE/kuimiUoxBO3AM110dUThZwm6F772TD Cm45su33LFBtJsOTLa+YfnUC3WOnmzs2Yy1qM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f88+qx25KgQRKnw0tMjG/6vIvz+qV5LMTlPxgd+r404=; b=dxduYiFF9tEjFJKYium0xSoRVpXwoyM0J4GElgKhP9kVFIvk/z1HGhWoF6q2RAzRtl OJxku6a9JlTASgqc80K3RKbPM49Maw1Tw3kBOuuRSTrERRw/kVJD29G2f/rp0kLtYnLD 8uDNjGZMxCAXYBcKTVKCj85ubSxKtQ47Ka0gh+m5RH/5V6wUOy2EyXBAAHPuYhUVmSvo ycTj4nOJ4gWy0PCsTNq93bhXfa8DodB1IuihQNPeenGsNEylFUOP/qytTg6gQG30Mg67 AQeJYlhf3O/SX2LhiBO5wruFAwF/CBYZKp2xBAhFgSgapFg+5jZzI2M2KlN2xhtoDJ3V dUfA== X-Gm-Message-State: APf1xPBKdf8KrhpfI4kCtEEPUfBYqtVeQpkRnpDPVddMXTitdh6ARWU+ jT0vOIqZwHhXmmEsgiulGvt/1g== X-Google-Smtp-Source: AH8x225w3bew7FrvLPjZlTQS7rOaum7TBSNsKTLVXD626dlZ81H9s3CJq35eZ3l/nO+Fs10uRQAhIA== X-Received: by 10.36.154.134 with SMTP id l128mr7367473ite.32.1519295554513; Thu, 22 Feb 2018 02:32:34 -0800 (PST) Received: from SZX1000114654 ([45.56.152.187]) by smtp.gmail.com with ESMTPSA id o124sm115647ith.12.2018.02.22.02.32.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Feb 2018 02:32:34 -0800 (PST) From: Guo Heyi X-Google-Original-From: Guo Heyi Date: Thu, 22 Feb 2018 18:32:29 +0800 To: Laszlo Ersek , Ruiyu Ni Cc: Heyi Guo , edk2-devel@lists.01.org, Ruiyu Ni , Ard Biesheuvel , Star Zeng , Eric Dong , Michael D Kinney Message-ID: <20180222103229.GC95440@SZX1000114654> References: <1519282474-94811-1-git-send-email-heyi.guo@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [RFC v2 0/2] Add translation support to generic PCIHostBridge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 10:26:35 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks Ray and Laszlo; I think I'd better refine comments and commit message first, or it is rather confusing for review. I'll send v3 ASAP. Regards, Gary On Thu, Feb 22, 2018 at 11:06:13AM +0100, Laszlo Ersek wrote: > On 02/22/18 07:54, Heyi Guo wrote: > > v2: > > Changs are made according to the discussion on the mailing list, including: > > > > 1. PciRootBridgeIo->Configuration should return CPU view address, as well as > > PciIo->GetBarAttributes, and Translation Offset should be equal to PCI view > > address - CPU view address. > > > 3. PciHostBridge driver internally used Base Address is still based on PCI view > > address, and translation offset = CPU view - PCI view, which follows the > > definition in ACPI, and not the same as that in UEFI spec. > > I find these opposite interpretations incredibly confusing. My review > for v2 1/2, point (1) namely, is likely wrong because of this. > > This information absolutely needs to go into the commit message of patch > #1, and also into the code as comments. > > Thanks > Laszlo