From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::236; helo=mail-wm0-x236.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E45E32034D8C3 for ; Thu, 22 Feb 2018 03:26:56 -0800 (PST) Received: by mail-wm0-x236.google.com with SMTP id t82so2974194wmt.5 for ; Thu, 22 Feb 2018 03:32:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vccTERYJD3+qud/FngZgsieLdWoFePeYZJN7UGDceLo=; b=ClKuOOd9DStLvDgpH0Y/vD+0BDV3weJrKbLxSXaTe53ogn1dVkwF6czyNNOTF7GG6F ranV4lz3aN4/lhMMmjDFy3u/Ve3Q01Fyaw0hAeTzKsicQ3rpON0+u16xhXAkKJSdTw3j 9mf4/7Z4Zrr5KkrxHmKBZsY0KhONiABwLVmrg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vccTERYJD3+qud/FngZgsieLdWoFePeYZJN7UGDceLo=; b=iMdtale6mIjHYp9yg/UdViPyKQeOiOACIb+0Q+BDchG3lnMY4l/Z8nvV3dNpqT064C qmA8nS7I6lUHGqeZGfLFGQA0cADjG7V5610ZX+EboCeASGvopHNr7053XS04Ym0Q79by 3Cz4hsXgScW++gDQR2dPwYgOZeZwiCqtA9bvIDGdmXs9PuxnBcwqimCBAbZJeN1WL9ae bziFtHp9POuFRS3B0Ohz2+XSoOOzTBusMzYxA/GaB25/2MhsuwzwKK6wueuO5cAzmdf4 l6ILZLTcoo6lLJyGssu0RrEeFxvHvUU2Mht9izapoERaac5V2iHmw9WZ6vYp3S+YdwS0 MGjQ== X-Gm-Message-State: APf1xPDdOb55vysl3nFnV6X6DrdrNTCjqXKQa83UNhDthuZ5p7vaEMWM SWvE4iyFlSZdiNejcPqC3lYQe6JO91Y= X-Google-Smtp-Source: AH8x225crsHw9F49QTzh4PXGQa0u2k0X6Fc8FW6ILOS8XF8bQTP3PKnUxfLNKSQJHjtDze8f38QVNA== X-Received: by 10.28.71.70 with SMTP id u67mr4435662wma.46.1519299175526; Thu, 22 Feb 2018 03:32:55 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v9sm28572568wre.8.2018.02.22.03.32.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Feb 2018 03:32:54 -0800 (PST) Date: Thu, 22 Feb 2018 11:32:52 +0000 From: Leif Lindholm To: Laszlo Ersek Cc: "haojian.zhuang@linaro.org" , "edk2-devel@lists.01.org" , "ard.biesheuvel@linaro.org" , "linaro-uefi@lists.linaro.org" Message-ID: <20180222113252.vkpdvbtsehu522op@bivouac.eciton.net> References: <1518707649-16912-1-git-send-email-haojian.zhuang@linaro.org> <1518707649-16912-2-git-send-email-haojian.zhuang@linaro.org> <51cc9548-3c02-09c6-30a4-5846b03a1374@redhat.com> <61c94cc9-1b5c-95a7-fdd9-812609c68561@redhat.com> MIME-Version: 1.0 In-Reply-To: <61c94cc9-1b5c-95a7-fdd9-812609c68561@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 1/2] Platform/Hisilicon/HiKey960: add boot options X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 11:26:57 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 22, 2018 at 11:56:22AM +0100, Laszlo Ersek wrote: > Sorry, I don't understand how this follows. Again: why is it only a > temporary solution to implement a PlatformBootManagerLib instance for HiKey? > > The library class says "Platform" in the name. Platforms are supposed to > provide it, one way or another. This is probably triggered by me. I have been pushing people to stay away from duplicating the generic PlatformBootManagerLib unless they really need to. > If you want to minimize code duplication between ArmPkg and HiKey, it > should be possible to factor out another library class from ArmPkg's > PlatformBootManagerLib instance. It could be a function that returns the > list of platform-specific boot options -- as an array of > EFI_BOOT_MANAGER_LOAD_OPTION elements -- that should always exist. Then > ArmPkg's PlatformBootManagerLib would perform the iteration that I > described above. This sounds like an excellent idea. / Leif