From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH edk2-platforms v2 1/7] Silicon/Atmel: add support for AtSha204a RNG
Date: Thu, 22 Feb 2018 13:08:42 +0000 [thread overview]
Message-ID: <20180222130842.hhiuvxaupr4zpg3z@bivouac.eciton.net> (raw)
In-Reply-To: <20180220174944.525-2-ard.biesheuvel@linaro.org>
On Tue, Feb 20, 2018 at 05:49:38PM +0000, Ard Biesheuvel wrote:
> This adds support for using the random number generator in the Atmel
> AtSha204a over I2C. Other functionality of the chip is currently
> unsupported.
>
> Note that the the I2C support in this device essentially violates the
> protocol layering, by requiring that the device is woken up by driving
> SDA low for a certain amount of time, which is something that cannot be
> expressed in terms of an I2C packet sent to the device's slave address.
> Instead, the slave address 0x0 is added to the device's address array,
> and the wake is sent by sending a dummy write to address 0x0, and
> ignoring the subsequent error. This requires the I2C bus to be clocked
> at 100 kHz.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
All of my feedback from v1 has been addressed, so:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
next prev parent reply other threads:[~2018-02-22 13:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 17:49 [PATCH edk2-platforms v2 0/7] Add Secure96 mezzanine support Ard Biesheuvel
2018-02-20 17:49 ` [PATCH edk2-platforms v2 1/7] Silicon/Atmel: add support for AtSha204a RNG Ard Biesheuvel
2018-02-22 13:08 ` Leif Lindholm [this message]
2018-02-23 15:33 ` Ard Biesheuvel
2018-02-20 17:49 ` [PATCH edk2-platforms v2 2/7] Platform/NinetySixBoards: introduce package and mezzanine protocol Ard Biesheuvel
2018-02-22 13:15 ` Leif Lindholm
2018-02-22 13:21 ` Ard Biesheuvel
2018-02-22 13:44 ` Leif Lindholm
2018-02-22 15:13 ` Ard Biesheuvel
2018-02-20 17:49 ` [PATCH edk2-platforms v2 3/7] Platform/NinetySixBoards: introduce I2C driver Ard Biesheuvel
2018-02-20 17:49 ` [PATCH edk2-platforms v2 4/7] Platform/NinetySixBoards: introduce LsConnector protocol Ard Biesheuvel
2018-02-22 15:29 ` Leif Lindholm
2018-02-20 17:49 ` [PATCH edk2-platforms v2 5/7] Platform/NinetySixBoards: add a driver for the Secure96 mezzanine board Ard Biesheuvel
2018-02-22 15:38 ` Leif Lindholm
2018-02-20 17:49 ` [PATCH edk2-platforms v2 6/7] Platform/NinetySixBoards: add core driver for LS connector and config Ard Biesheuvel
2018-02-22 15:59 ` Leif Lindholm
2018-02-22 19:00 ` Ard Biesheuvel
2018-02-22 19:10 ` Ard Biesheuvel
2018-02-22 20:21 ` Leif Lindholm
2018-02-20 17:49 ` [PATCH edk2-platforms v2 7/7] Platform/Socionext/DeveloperBox: add 96boards mezzanine support Ard Biesheuvel
2018-02-22 16:04 ` [PATCH edk2-platforms v2 0/7] Add Secure96 " Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222130842.hhiuvxaupr4zpg3z@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox