From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5174D220F33D7 for ; Thu, 22 Feb 2018 05:02:45 -0800 (PST) Received: by mail-wr0-x242.google.com with SMTP id v65so10479786wrc.11 for ; Thu, 22 Feb 2018 05:08:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fH5rdY8DnKpuZ/vDjqK7JRrMIgOV4LsjX8wJLWF9cgw=; b=aoaQIcKBozrMWrx93HXDd7XkNSi6Ee/Szs4iEUBbsc/J23SXIN/gmkTLRnfB5L337N fb6kLW90IVDOXGlrRc+/5UySC/bkfU46tofACjdy65w4IZfeqbisvqPHea88iThu1gDV T8zaw73djm6R+oeFCIYV+wMrqebaa8iRX++/k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fH5rdY8DnKpuZ/vDjqK7JRrMIgOV4LsjX8wJLWF9cgw=; b=HSaIU6mA2c6e9Q5VHWRNtpkBpTxBkw3LMzSPjVBeVI0eCtGRgnCHRsqYX5OcRtoLM4 1gHnFM1wG8GyaC8yyg/vtYZYihF3GMNguOm0JRGH//Mlwr/+C34HZeL4gYjp/F87NR6J wCqiP14Kxuxy0GRv32LtcByJHbPcCRt1ZHXT/FRWAyOKGTVzigDegPbmZ/rfQwbVHDJ0 TJDsUc1DEwngDrZ+U1AsUNB9TL9CYI4ZpaktiBqVkaA2BIXIw/d5u7oPKRcgmuUNdbHF AktJn8Fc9gL2HosUdQt56ULQzpXLb60f28D/UbLTgGLva0R8mA+CiJ1gyp9lykYYDQik SmEQ== X-Gm-Message-State: APf1xPAsJQOB+h75bKoHMaXqnSzC9OSj+hsAuWerJKNqKheN+svwsSmp joDmPdxXmDU+QT8dLV08ox56DQ== X-Google-Smtp-Source: AH8x224w+b6vcCPQDYeeJblVY0GQov7lU/ebEIkd4AgIoGLjpo6XuiT5MMnsUWvsbiSiWNln6kXnAw== X-Received: by 10.223.138.130 with SMTP id y2mr5864675wry.242.1519304925219; Thu, 22 Feb 2018 05:08:45 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y23sm98329wra.9.2018.02.22.05.08.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Feb 2018 05:08:44 -0800 (PST) Date: Thu, 22 Feb 2018 13:08:42 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20180222130842.hhiuvxaupr4zpg3z@bivouac.eciton.net> References: <20180220174944.525-1-ard.biesheuvel@linaro.org> <20180220174944.525-2-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20180220174944.525-2-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 1/7] Silicon/Atmel: add support for AtSha204a RNG X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 13:02:47 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 20, 2018 at 05:49:38PM +0000, Ard Biesheuvel wrote: > This adds support for using the random number generator in the Atmel > AtSha204a over I2C. Other functionality of the chip is currently > unsupported. > > Note that the the I2C support in this device essentially violates the > protocol layering, by requiring that the device is woken up by driving > SDA low for a certain amount of time, which is something that cannot be > expressed in terms of an I2C packet sent to the device's slave address. > Instead, the slave address 0x0 is added to the device's address array, > and the wake is sent by sending a dummy write to address 0x0, and > ignoring the subsequent error. This requires the I2C bus to be clocked > at 100 kHz. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel All of my feedback from v1 has been addressed, so: Reviewed-by: Leif Lindholm