From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22b; helo=mail-wm0-x22b.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B39EE2034D8EE for ; Thu, 22 Feb 2018 05:38:31 -0800 (PST) Received: by mail-wm0-x22b.google.com with SMTP id z9so3773619wmb.3 for ; Thu, 22 Feb 2018 05:44:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gRh9IGwIEn0z4l/PS1nSib1OjNOBrMUIuyBi2edZenA=; b=gB+JmzCExCxykNzUiMZ5UiA3Jw5dmBoPgiLQLqAK6jL1YsBy3X5psE9GBk3fd+1AOl y67hLzIkg1Lh7Cq7ccok+uFwM3gIkYYWLPOeALFFHclBGvJLyqxDEIvgeAG6XZSJ3JrZ R5CBNfjzMbhWVa7v+wn0+TSfyWD+jzSizxy/A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gRh9IGwIEn0z4l/PS1nSib1OjNOBrMUIuyBi2edZenA=; b=qO20pbfVAwJ4wA9BZKb3Zv4JKjaypON92YkHJqlwyPab6PKDKymAkt/hlaN2vujFXR KMORafIvDYQXgI12BL0Fqm4IJfQ+tVtf3NhEHnYliUQVJyWTOf3KWpi7mkMxQA9Dr0O1 TO3KCF9pVulyabznEQKGU9W7z3nUaiGoZtkGh90ZkMeGtiJgf+oQKVIm6YNmB4Q+J2q/ DsAgvDt5nJRvVL/U7iDR2bxMn4K6PwewC4MyhkRMPVxwdRbwcmhLFzquhqM7vUMze7xe RHKY6KQgtI42U1nbyHx8NXiB0muMUPy94QID78g2IB+92dEDW5QiipO3zuHumCG/e77a IDZA== X-Gm-Message-State: APf1xPBMX3dychnCD0b3/d43vCUpO6w8mvgy//J7TBSPjt1/8VYLG4x2 D7hOII2sHU8qMuS2IXeo7lgkMg== X-Google-Smtp-Source: AH8x227CewH+oylBb2ZB1nCXFkQvHTYTR7/K+3xtiyZ3kGXrDsB8RJFWqeMqwpuoALRKT+QonIAm3A== X-Received: by 10.28.20.206 with SMTP id 197mr4831333wmu.19.1519307070608; Thu, 22 Feb 2018 05:44:30 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r136sm551961wmf.18.2018.02.22.05.44.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Feb 2018 05:44:29 -0800 (PST) Date: Thu, 22 Feb 2018 13:44:27 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" Message-ID: <20180222134427.22s3lgzyg4iwxoir@bivouac.eciton.net> References: <20180220174944.525-1-ard.biesheuvel@linaro.org> <20180220174944.525-3-ard.biesheuvel@linaro.org> <20180222131553.dixmsbldbufxdgat@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v2 2/7] Platform/NinetySixBoards: introduce package and mezzanine protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 13:38:32 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 22, 2018 at 01:21:37PM +0000, Ard Biesheuvel wrote: > On 22 February 2018 at 13:15, Leif Lindholm wrote: > > On Tue, Feb 20, 2018 at 05:49:39PM +0000, Ard Biesheuvel wrote: > >> Introduce the mezzanine protocol and the 96boards package defining > >> the PCDs and GUIDs that may be used by implementations of the > >> protocol. > > > > This looks really good. Comments below are all style related. > > > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Ard Biesheuvel > >> --- > >> Platform/NinetySixBoards/Include/Protocol/Mezzanine.h | 71 ++++++++++++++++++++ > >> Platform/NinetySixBoards/NinetySixBoards.dec | 67 ++++++++++++++++++ > > > > Why NinetySixBoards? Is 96Boards ENOTENOUGHCAMEL? > > > > That is what I started out with, but having CPP macros and lots of VFR > identifiers and other bits and pieces using leading digits was making > me nervous about whether it is supported in all configurations, so I > bit the bullet and renamed everything. I understand the paranoia, but we do have PcAtChipsetPkg/8259InterruptControllerDxe and PcAtChipsetPkg/8254TimerDxe so I would expect this to actually be reasonably well supported. We may not have to worry about 3com and 3ware anymore, but if someone wants to write drivers for ancient cards, I'd still prefer to be able to give them predictable paths. / Leif