Re: [PATCH edk2-platforms v2 4/7] Platform/NinetySixBoards: introduce LsConnector protocol

[Leif Lindholm <leif.lindholm@linaro.org>]

On Tue, Feb 20, 2018 at 05:49:41PM +0000, Ard Biesheuvel wrote:
> Introduce a protocol describing the presence of a 96boards LS connector,

Can you expand the LS here?
(It's used as a proper name, so I don't consider it needing expansion
below, but useful for introduction.)

> and identifying the type of mezzanine that has been installed.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  Platform/NinetySixBoards/Include/Protocol/LsConnector.h | 35 ++++++++++++++++++++
>  Platform/NinetySixBoards/NinetySixBoards.dec            |  3 ++
>  2 files changed, 38 insertions(+)
> 
> diff --git a/Platform/NinetySixBoards/Include/Protocol/LsConnector.h b/Platform/NinetySixBoards/Include/Protocol/LsConnector.h
> new file mode 100644
> index 000000000000..a1f0132c85ae
> --- /dev/null
> +++ b/Platform/NinetySixBoards/Include/Protocol/LsConnector.h
> @@ -0,0 +1,35 @@
> +/** @file
> +
> +  Copyright (c) 2018, Linaro, Ltd. All rights reserved.<BR>
> +
> +  This program and the accompanying materials are licensed and made available
> +  under the terms and conditions of the BSD License which accompanies this
> +  distribution. The full text of the license may be found at
> +  http://opensource.org/licenses/bsd-license.php
> +
> +  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +
> +**/
> +
> +#ifndef _LS_CONNECTOR_H_
> +#define _LS_CONNECTOR_H_
> +
> +#define LS_CONNECTOR_PROTOCOL_GUID \
> +  { 0xae548d4c, 0x9062, 0x4eed, { 0x83, 0x5f, 0xf5, 0x10, 0xf8, 0xfc, 0x48, 0xaf } }
> +
> +typedef struct _LS_CONNECTOR_PROTOCOL LS_CONNECTOR_PROTOCOL;
> +
> +typedef enum {
> +  MezzanineUnknown,
> +  MezzanineSecure96,
> +  MezzanineMax
> +} MEZZANINE_TYPE;
> +
> +struct _LS_CONNECTOR_PROTOCOL {
> +  MEZZANINE_TYPE      MezzanineType;
> +};
> +
> +extern EFI_GUID gNinetySixBoardsLsConnectorProtocolGuid;
> +
> +#endif // _LS_CONNECTOR_H_
> diff --git a/Platform/NinetySixBoards/NinetySixBoards.dec b/Platform/NinetySixBoards/NinetySixBoards.dec
> index f7e2b01459d7..5c3fe43dbb24 100644
> --- a/Platform/NinetySixBoards/NinetySixBoards.dec
> +++ b/Platform/NinetySixBoards/NinetySixBoards.dec
> @@ -25,6 +25,9 @@ [Protocols]
>    ## Include/Protocol/Mezzanine.h
>    gNinetySixBoardsMezzanineProtocolGuid = { 0xf0467a37, 0x3436, 0x40ef, { 0x94, 0x09, 0x4d, 0x1d, 0x7f, 0x51, 0x06, 0xd3 } }
>  
> +  ## Include/Protocol/LsConnector.h
> +  gNinetySixBoardsLsConnectorProtocolGuid = { 0xae548d4c, 0x9062, 0x4eed, { 0x83, 0x5f, 0xf5, 0x10, 0xf8, 0xfc, 0x48, 0xaf } }
> +
>  [Guids]
>    # PCD scope GUID
>    gNinetySixBoardsTokenSpaceGuid = { 0xe0d2f33a, 0xb7dd, 0x4a69, { 0xb6, 0x76, 0xda, 0xe8, 0xa4, 0x17, 0xa7, 0xb5 } }
> -- 
> 2.11.0
>