public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH edk2-platforms v2 0/7] Add Secure96 mezzanine support
Date: Thu, 22 Feb 2018 16:04:27 +0000	[thread overview]
Message-ID: <20180222160427.pcvfevuosaf3efja@bivouac.eciton.net> (raw)
In-Reply-To: <20180220174944.525-1-ard.biesheuvel@linaro.org>

So, the ones I haven't commented on in this series, I'm happy with,
but since there may be non-trivial refactoring I'm not posting R-b on yet.

On Tue, Feb 20, 2018 at 05:49:37PM +0000, Ard Biesheuvel wrote:
> Almost a complete rewrite of the v1. I omitted the patches that add SPI
> and I2C DT nodes to the SynQuacer DTS. I did include the v2 of the Atmel
> AtSha204a driver, since the latter patches depend on it.
> 
> This version implements a complete split between the generic 96boards
> LS connector support and its associated plumbing (defining which I2C,
> SPI and GPIO controllers are connected) on the one hand, and support
> for the Secure96 mezzanine board in particular on the other. More
> specifically, all Secure96 PCDs were dropped, and the only platform
> specific configuration that remains is including the Secure96 driver
> and the driver for its peripherals to the build.
> 
> Patch #1 is v2 of the AtSha204a driver, with Leif's review comments
> addressed.
> 
> Patch #2 introduces the mezzanine protocol, which abstracts away from
> any particular mezzanine implementation.
> 
> Patch #3 introduces the generic I2C plumbing for any mezzanine that exposes
> I2C peripherals.
> 
> Patch #4 implements the protocol that asserts the presence of a 96boards LS
> connector and the type of mezzanine connected to it.
> 
> Patch #5 adds the Secure96 driver, which incorporates the DT overlay, and
> a description of the I2C peripheral.
> 
> Patch #6 adds a generic driver for configuring the type of mezzanine, and
> to interface with it at end of DXE time to install the appropriate DT
> overlay.
> 
> Patch #7 wires everything up for the DeveloperBox platform.
> 
> Ard Biesheuvel (7):
>   Silicon/Atmel: add support for AtSha204a RNG
>   Platform/NinetySixBoards: introduce package and mezzanine protocol
>   Platform/NinetySixBoards: introduce I2C driver
>   Platform/NinetySixBoards: introduce LsConnector protocol
>   Platform/NinetySixBoards: add a driver for the Secure96 mezzanine
>     board
>   Platform/NinetySixBoards: add core driver for LS connector and config
>   Platform/Socionext/DeveloperBox: add 96boards mezzanine support
> 
>  Platform/NinetySixBoards/Include/Guid/FormSet.h                          |  23 ++
>  Platform/NinetySixBoards/Include/Protocol/LsConnector.h                  |  35 +++
>  Platform/NinetySixBoards/Include/Protocol/Mezzanine.h                    |  71 +++++
>  Platform/NinetySixBoards/NinetySixBoards.dec                             |  73 +++++
>  Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsDxe.c         | 221 ++++++++++++++
>  Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsDxe.h         |  32 ++
>  Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsDxe.inf       |  57 ++++
>  Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsHii.uni       |  27 ++
>  Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsHii.vfr       |  51 ++++
>  Platform/NinetySixBoards/NinetySixBoardsI2cDxe/NinetySixBoardsI2cDxe.c   | 202 +++++++++++++
>  Platform/NinetySixBoards/NinetySixBoardsI2cDxe/NinetySixBoardsI2cDxe.inf |  51 ++++
>  Platform/NinetySixBoards/Secure96Dxe/Secure96.dts                        |  76 +++++
>  Platform/NinetySixBoards/Secure96Dxe/Secure96.h                          |  26 ++
>  Platform/NinetySixBoards/Secure96Dxe/Secure96Dxe.c                       | 211 +++++++++++++
>  Platform/NinetySixBoards/Secure96Dxe/Secure96Dxe.inf                     |  67 +++++
>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                         |  34 +++
>  Platform/Socionext/DeveloperBox/DeveloperBox.fdf                         |  10 +
>  Silicon/Atmel/AtSha204a/AtSha204a.dec                                    |  22 ++
>  Silicon/Atmel/AtSha204a/AtSha204aDriver.c                                | 309 ++++++++++++++++++++
>  Silicon/Atmel/AtSha204a/AtSha204aDriver.h                                |  81 +++++
>  Silicon/Atmel/AtSha204a/AtSha204aDxe.inf                                 |  52 ++++
>  Silicon/Atmel/AtSha204a/ComponentName.c                                  | 186 ++++++++++++
>  Silicon/Atmel/AtSha204a/DriverBinding.c                                  | 242 +++++++++++++++
>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c            |   9 +
>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf          |   2 +
>  25 files changed, 2170 insertions(+)
>  create mode 100644 Platform/NinetySixBoards/Include/Guid/FormSet.h
>  create mode 100644 Platform/NinetySixBoards/Include/Protocol/LsConnector.h
>  create mode 100644 Platform/NinetySixBoards/Include/Protocol/Mezzanine.h
>  create mode 100644 Platform/NinetySixBoards/NinetySixBoards.dec
>  create mode 100644 Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsDxe.c
>  create mode 100644 Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsDxe.h
>  create mode 100644 Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsDxe.inf
>  create mode 100644 Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsHii.uni
>  create mode 100644 Platform/NinetySixBoards/NinetySixBoardsDxe/NinetySixBoardsHii.vfr
>  create mode 100644 Platform/NinetySixBoards/NinetySixBoardsI2cDxe/NinetySixBoardsI2cDxe.c
>  create mode 100644 Platform/NinetySixBoards/NinetySixBoardsI2cDxe/NinetySixBoardsI2cDxe.inf
>  create mode 100644 Platform/NinetySixBoards/Secure96Dxe/Secure96.dts
>  create mode 100644 Platform/NinetySixBoards/Secure96Dxe/Secure96.h
>  create mode 100644 Platform/NinetySixBoards/Secure96Dxe/Secure96Dxe.c
>  create mode 100644 Platform/NinetySixBoards/Secure96Dxe/Secure96Dxe.inf
>  create mode 100644 Silicon/Atmel/AtSha204a/AtSha204a.dec
>  create mode 100644 Silicon/Atmel/AtSha204a/AtSha204aDriver.c
>  create mode 100644 Silicon/Atmel/AtSha204a/AtSha204aDriver.h
>  create mode 100644 Silicon/Atmel/AtSha204a/AtSha204aDxe.inf
>  create mode 100644 Silicon/Atmel/AtSha204a/ComponentName.c
>  create mode 100644 Silicon/Atmel/AtSha204a/DriverBinding.c
> 
> -- 
> 2.11.0
> 


      parent reply	other threads:[~2018-02-22 15:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20 17:49 [PATCH edk2-platforms v2 0/7] Add Secure96 mezzanine support Ard Biesheuvel
2018-02-20 17:49 ` [PATCH edk2-platforms v2 1/7] Silicon/Atmel: add support for AtSha204a RNG Ard Biesheuvel
2018-02-22 13:08   ` Leif Lindholm
2018-02-23 15:33     ` Ard Biesheuvel
2018-02-20 17:49 ` [PATCH edk2-platforms v2 2/7] Platform/NinetySixBoards: introduce package and mezzanine protocol Ard Biesheuvel
2018-02-22 13:15   ` Leif Lindholm
2018-02-22 13:21     ` Ard Biesheuvel
2018-02-22 13:44       ` Leif Lindholm
2018-02-22 15:13         ` Ard Biesheuvel
2018-02-20 17:49 ` [PATCH edk2-platforms v2 3/7] Platform/NinetySixBoards: introduce I2C driver Ard Biesheuvel
2018-02-20 17:49 ` [PATCH edk2-platforms v2 4/7] Platform/NinetySixBoards: introduce LsConnector protocol Ard Biesheuvel
2018-02-22 15:29   ` Leif Lindholm
2018-02-20 17:49 ` [PATCH edk2-platforms v2 5/7] Platform/NinetySixBoards: add a driver for the Secure96 mezzanine board Ard Biesheuvel
2018-02-22 15:38   ` Leif Lindholm
2018-02-20 17:49 ` [PATCH edk2-platforms v2 6/7] Platform/NinetySixBoards: add core driver for LS connector and config Ard Biesheuvel
2018-02-22 15:59   ` Leif Lindholm
2018-02-22 19:00     ` Ard Biesheuvel
2018-02-22 19:10       ` Ard Biesheuvel
2018-02-22 20:21         ` Leif Lindholm
2018-02-20 17:49 ` [PATCH edk2-platforms v2 7/7] Platform/Socionext/DeveloperBox: add 96boards mezzanine support Ard Biesheuvel
2018-02-22 16:04 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222160427.pcvfevuosaf3efja@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox